On Sat, Feb 23, 2008 at 02:35:33PM -0800, Junio C Hamano wrote:

quoted text
> > Hmm. Actually, we just set SHELL_PATH to SHELL in the Makefile. So I
> > really don't see the point of SHELL_PATH at all, unless there are some
> > setups where it is already set outside of git.
> 
> Well, on one of my machines, I seem to be getting SHELL=bash
> (not /bin/bash).

My point is that nothing ever turns that into /bin/bash, unless there is
something totally outside of git setting up SHELL_PATH (which is not set
up on any of my systems). I would think to handle the case you're
talking about, you would want to change

  SHELL_PATH ?= $(SHELL)

to something like

  SHELL_PATH ?= $(shell which $(SHELL))

quoted text
> Honestly, I do not think it matters getting the value from
> Makefile for this particular case, but I'd rather get people
> into habits to run "make tXXXX-name", not "sh ./tXXXX-name.sh",
> unless they know what they are doing.

Why?

-Peff
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html