On Sat, Feb 23, 2008 at 10:09:41PM +0100, Johannes Sixt wrote:

quoted text
> On Saturday 23 February 2008 21:34, Junio C Hamano wrote:
> > -echo "#!$SHELL" >fake-editor
> > +echo "#!$SHELL_PATH" >fake-editor.sh
> 
> Hm, when we run the test outside make, like
> 
>    $ sh t3404-rebase-interactive.sh
> 
> then the fake-editor.sh script begins with this line:
> 
>    #!
> 
> Isn't this a trap similar to what Jeff wanted to avoid?

Well, the trap I wanted to avoid is that "/bin/sh" specifically is
broken. But yes, I think losing the ability to run the tests from the
commandline is bad.

Ideally we figured out a sane shell for our shell scripts in the main
build process, and we want to always use that here.  I think "git
rev-parse --sane-shell-path" is probably overkill. Maybe test-lib.sh can
source a file of build-time options? The "diff -u" vs "cmp" thing could
go there, as well.

-Peff
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html