[PATCH 06/11] Better error handling in compress_all()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <gitster@...>
Cc: <git@...>, Marco Costalba <mcostalba@...>
Date: Saturday, February 2, 2008 - 7:35 am

Also let the caller to xmalloc() the buffer
int compress_start()

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
---
 compress.c |   19 +++++++++----------
 1 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/compress.c b/compress.c
index f6986c3..0d0b9d9 100644
--- a/compress.c
+++ b/compress.c
@@ -12,7 +12,7 @@ int compress_start(z_stream *stream,
                    unsigned char *in, unsigned long in_size,
                    unsigned char *out, unsigned long out_size)
 {
-	stream->next_out = (out ? out : xmalloc(out_size));
+	stream->next_out = out;
 	stream->avail_out = out_size;
 	stream->next_in = in;
 	stream->avail_in = in_size;
@@ -36,19 +36,18 @@ unsigned long compress_free(z_stream *stream)
 	return stream->total_out;
 }
 
-unsigned long compress_all(int level, unsigned char *data,
-                           unsigned long size, unsigned char **out)
+unsigned long compress_all(int level, unsigned char *in,
+                           unsigned long in_size, unsigned char **out)
 {
-	int bound, result;
+	unsigned long out_size;
 	z_stream stream;
 
-	bound = compress_alloc(&stream, level, size);
-	compress_start(&stream, data, size, NULL, bound);
+	out_size = compress_alloc(&stream, level, in_size);
+	*out = xmalloc(out_size);
 
-	*out = stream.next_out;
-	result = compress_next(&stream, Z_FINISH);
-
-	if (result != Z_STREAM_END) {
+	if (   compress_start(&stream, in, in_size, *out, out_size) != Z_OK
+	    || compress_next(&stream, Z_FINISH) != Z_STREAM_END)
+	{
 		compress_free(&stream);
 		free(*out);
 		*out = NULL;
-- 
1.5.4.rc4.39.g524a

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 01/11] Introduce stream compress helpers, Marco Costalba, (Sat Feb 2, 7:35 am)
[PATCH 02/11] Use new compress helpers in git files, Marco Costalba, (Sat Feb 2, 7:35 am)
[PATCH 03/11] Use new compress helpers in fast-import, Marco Costalba, (Sat Feb 2, 7:35 am)
Re: [PATCH 03/11] Use new compress helpers in fast-import, Shawn O. Pearce, (Sun Feb 3, 9:41 pm)
[PATCH 04/11] Use new compress helpers in http-push.c, Marco Costalba, (Sat Feb 2, 7:35 am)
[PATCH 05/11] Use new compress helpers in sha1_file.c, Marco Costalba, (Sat Feb 2, 7:35 am)
[PATCH 06/11] Better error handling in compress_all(), Marco Costalba, (Sat Feb 2, 7:35 am)
[PATCH 07/11] Introduce stream decompress helpers, Marco Costalba, (Sat Feb 2, 7:35 am)