| From | Subject | Date |
|---|---|---|
| Stefan Monnier | Re: Merge-Recursive Improvements
Having such 3-parts conflicts helps tremendously when you have to do
the merge by hand, so I'm 100% in favor of such a change.
BUT Please, please, pretty please, don't follow Perforce who blindly
disregards previous standards. Instead use the format used by diff3
which has been there for ages:
<<<<<<< foo
original text
||||||| bar
ancestor
=======
new text
I can live with that. As long as the conflict is clearly marked with
all 3 parts, I can us...
| Feb 12, 7:03 pm 2008 |
| Junio C Hamano | [PATCH/RFC] diff --relative: output paths as relative to the...
This adds --relative option to diff family. When you start from
a subdirectory,
$ git diff --relative
shows only the diff that is inside your current subdirectory,
and without $prefix part. People who usually live in
subdirectories may like it.
There are a few things I should also mention about the change:
- This works not just with diff but also works with the log
family of commands, but the history pruning is not affected.
In other words, if you go to a subdirectory, ...
| Feb 12, 6:26 pm 2008 |
| Linus Torvalds | Re: [PATCH/RFC] diff --relative: output paths as relative to...
Ack, except I think it should allow you to actually *set* what the diff is
relative to.
An example of that could be something like
git diff --relative=drivers/scsi/ a..b -- drivers/scsi/
where you aren't actually *in* that subdirectory, but for one reason or
another you're limiting the diff to just stuff in that subdirectory, and
want a diff that is relative to that one.
Hmm?
Linus
-
| Feb 12, 7:33 pm 2008 |
| Junio C Hamano | Re: [PATCH/RFC] diff --relative: output paths as relative to...
Your example is shorter to type as:
(cd drivers/scsi && git diff --relative a..b --)
Do you envision a useful case where --relative=<foo> does not
cover the pathspec you give? IOW, with the "temporarily chdir
there" approach, you cannot express:
git diff --relative=block/ a..b -- drivers/scsi
but I do not think it is useful. On the other hand,
git diff --relative=drivers a..b -- drivers/scsi
does make sense but again that is:
(cd drivers && git diff --rel...
| Feb 12, 7:43 pm 2008 |
| Linus Torvalds | Re: [PATCH/RFC] diff --relative: output paths as relative to...
No it isn't. The above doesn't even work for bare repositories, or when
you want to look at a branch that has a different directory structure than
the currently-checked-out one.
Linus
-
| Feb 12, 7:53 pm 2008 |
| Voltage Spike | Merge-Recursive Improvements
I would like to make a series of significant improvements to the
merge-recursive mechanism in git, but I was hoping to solicit some early
feedback before submitting patches.
First, git is overly zealous at merging differences and two functions
added
at the same point in a file become intertwined during the merge. A
trivial
example of this behavior:
<<<<<<< HEAD:file.txt
void newfunc1()
=======
void newfunc2()
>>>>>>> merge:file.txt...
| Feb 12, 6:16 pm 2008 |
| Linus Torvalds | Re: Merge-Recursive Improvements
Hmm. Have you tested what happens if you use XDL_MERGE_EAGER instead of
XDL_MERGE_ZEALOUS in the "level" argument to xdl_merge() in
merge-recursive.c?
(No, I didn't test it myself, but it may get you the behaviour you want,
and we could make it a config option for people who want a less aggressive
merge)
Linus
-
| Feb 12, 7:48 pm 2008 |
| Junio C Hamano | Re: Merge-Recursive Improvements
This lacks illustration of what you change that example to, which
makes the proposal harder to judge.
I suspect you are saying that you would want to coalesce
adjacent hunks that have too small number of lines between '>>>'
of the previous hunk and '<<<' of the current hunk by duplicate
the common hunks, like this:
<<<<<<< HEAD:file.txt
void newfunc1()
{
int err;
err = doSomething();
=======
void newfunc2()
{
int err...
| Feb 12, 7:11 pm 2008 |
| Junio C Hamano | Re: [PATCH] Add gitattributes file making whitespace checkin...
You are quoting an older draft. The rules applied to 'master'
is actually a bit more lenient:
- Unless otherwise specified, indent with SP that could be
replaced with HT are not "bad". But SP before HT in the
indent is "bad", and trailing whitespaces are "bad".
- For C source files, initial indent by SP that can be replaced
with HT is also "bad".
- Test scripts in t/ and test vectors in its subdirectories can
contain anything, so we make it unrestricted for now.
So your p...
| Feb 12, 5:42 pm 2008 |
| Junio C Hamano | Re: [PATCH 1/2] config api: Add git_config_magic_int()
I do not think this has much to do with any "magic".
An instruction "use 0 threads" when taken literally would mean
"do not use any CPU" which would not make much sense. In that
sense, giving a magic meaning of "guess an appropriate value" to
0 may be a good idea. A valid alternative would be to make 0
mean the same thing as 1, but that is much more boring ;-)
But if you did so, that means "var = 0" invokes the same magic
as "var = auto". The magic lives in "0", and not in "auto".
I think...
| Feb 12, 5:41 pm 2008 |
| Linus Torvalds | [PATCH updated] Add "--dirstat" for some directory statistics
This adds a new form of overview diffstat output, doing something that I
have occasionally ended up doing manually (and badly, because it's
actually pretty nasty to do), and that I think is very useful for an
project like the kernel that has a fairly deep and well-separated
directory structure with semantic meaning.
What I mean by that is that it's often interesting to see exactly which
sub-directories are impacted by a patch, and to what degree - even if you
don't perhaps care so much abou...
| Feb 12, 5:26 pm 2008 |
| Linus Torvalds | Re: [PATCH updated] Add "--dirstat" for some directory stati...
Side note: this latter one is actually a good example of two
different issues.
First off, it's an example of where --cumulative really does make sense,
since it reports:
10.0% Documentation/
4.9% contrib/
5.7% git-gui/lib/
13.9% git-gui/macosx/
8.7% git-gui/po/
31.4% git-gui/
4.6% gitk-git/
13.1% t/
ie it makes it clear that almost a third of changes between 1.5.0 and
1.5.4 was in git-gui/.
But secondly, it's an example of how the whole --dirstat is...
| Feb 12, 5:56 pm 2008 |
| Frans Pop | [BUG] git bisect should not expand file globs in log
Hi,
During a git bisect session I ended up with the following in the
.git/BISECT_LOG:
# bad: [38a382ae5dd4f4d04e3046816b0a41836094e538] Kobject: convert
arch/alpha arch/arm arch/avr32 arch/blackfin arch/cris arch/frv arch/h8300
arch/ia64 arch/m32r arch/m68k arch/m68knommu arch/mips arch/parisc
arch/powerpc arch/ppc arch/s390 arch/sh arch/sh64 arch/sparc arch/sparc64
arch/um arch/v850 arch/x86 arch/x86_64 arch/xtensa from
kobject_unregister() to kobject_put()
git-bisect bad 38a382ae5dd4f4d0...
| Feb 12, 3:23 pm 2008 |
| Alex Riesen | [PATCH] Fix shell quoting in git-bisect
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
This should fix it
git-bisect.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-bisect.sh b/git-bisect.sh
index 5385249..0bb51d7 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -131,7 +131,7 @@ bisect_write() {
*) die "Bad bisect_write argument: $state" ;;
esac
git update-ref "refs/bisect/$tag" "$rev"
- echo "# $state: "$(git show-branch $rev) >>"$GIT_DIR/BISECT_LOG"
+ echo "# $state:...
| Feb 12, 4:06 pm 2008 |
| Johannes Schindelin | Re: [BUG] git bisect should not expand file globs in log
Hi,
does this help? (It is a really trivial patch...)
-- snipsnap --
[PATCH] bisect: use verbatim commit subject in the bisect log
Due to a typo, the commit subject was shell expanded in the bisect log.
That is, if you had some shell pattern in the commit subject, bisect
would happily put all matching file names into the log.
Noticed by Frans Pop.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
git-bisect.sh | 2 +-
1 files changed, 1 insertions(+), 1 dele...
| Feb 12, 3:50 pm 2008 |
| Frans Pop | Re: [BUG] git bisect should not expand file globs in log
Yes, it does. Thanks.
You beat Alex by about 15 minutes. If I'd known this was just shell script,
Tested-by: Frans Pop <elendil@planet.nl>
-
| Feb 12, 5:10 pm 2008 |
| Nikita V. Youshchenko | git apply fails because of 'index xxxxxxx..yyyyyyy' line?
Hello
I was playing with 'git quiltimport' feature, trying to import a large quilt
patchset (coming from vendor) into a local git repository containing linux
kernel tree.
Some of quilt patches in the patchset have been created by picking single
git commits, likely with 'git show XXXXXX > file.patch.
And I found that such patches fail to apply with 'git apply' (which is
internally used by 'git quiltimport'). Git complains:
fatal: patch with only garbage at line 3
However, if I edit patc...
| Feb 12, 2:55 pm 2008 |
| Catalin Marinas | Re: new stacked git feature
Hi Jason,
Sorry for the loooooong delay. I've been pretty busy and not able to do
much work on StGIT (though the other contributors did a lot of changes).
Now I'm trying to get up to speed with the latest StGIT structure :-).
I cc'ed the other StGIT people and the GIT mailing list.
The background of this discussion is to have two or more StGIT
repositories and keep them in sync. An idea is to share the exported
patches directory and automatically synchronise them between various
repositori...
| Feb 12, 12:42 pm 2008 |
| pradeep singh rautela | git-clone fails with out of memory,malloc failed7
Hi All,
I compiled a fresh git 1.5.4 and tried to clone Ingo's kgdb-lite tree.
I got rather strange out of memory. malloc failed7 error.
I am using a 32 bit kernel on a pentium D processor with 1 GB of ram.
Is this a git issue or something else?
Can someone help me in telling me which is the correct place to report this?
Better if this is a known issue ?
isn't 1 GB of RAM enough for git???
luser@helvella:/opt/repo/archive$ sudo git-clone
git://git.kernel.org/pub/scm/linux/kernel/git/mingo...
| Feb 12, 11:57 am 2008 |
| Nicolas Pitre | Re: git-clone fails with out of memory,malloc failed7
I just cloned the above repository with Git v1.5.4 with no problem at
all, and index-pack never used more than 52 megs of actual memory.
Puzzled.
Nicolas
-
| Feb 12, 1:23 pm 2008 |
| pradeep singh rautela | Re: git-clone fails with out of memory,malloc failed7
because I(as luser :) ) did not have write permissions in the
me too.Thought it may be some git issue so reported.
Seems like it is once in a blue moon situation.
Nevermind, thanks for reply.
Cu,
--Pradeep
--
Pradeep Singh Rautela
http://eagain.wordpress.com
http://emptydomain.googlepages.com
-
| Feb 12, 1:52 pm 2008 |
| Tommy Thorn | Re: [PATCH 2/3] git-p4: support exclude paths
Alas, this change needs more work - the exclude paths needs to
be maintained in the commit messages as otherwise we pull in new
files in the excluded path. I haven't done this yet.
However, the other patch (git-p4: no longer keep all file contents while cloning)
is IMO critical. You simply cannot clone a non-trivial Perforce repository
without it. Why is this being ignored? Are there no users of git-p4?
Tommy
**
-
| Feb 12, 11:53 am 2008 |
| Michal Rokos | Re: libcrypto core dump in 64bit
Hello,
yes, this is OpenSSL issue. I had to recompile OpenSSL myself to make it work
(with no-asm option)
I'm using only HP cc for building git (with all the toolchain). (No gcc here)
# uname -mrs
HP-UX B.11.23 ia64
# cc --version
cc: HP C/aC++ B3910B A.06.14 [Feb 22 2007]
Michal
-
| Feb 12, 11:26 am 2008 |
| H.Merijn Brand | Re: libcrypto core dump in 64bit
On Tue, 12 Feb 2008 15:26:16 +0000 (UTC), Michal Rokos <michal@rokos.cz>
OK, I did the same now, and the docs tell me to turn down optimization to
+O2 when you choose to do so.
Apart from that, when you create shared libs, the default build creates a
conflicting situation, so you have to throw away the files that cause dup
names: aes-ia64.o rc4-ia64.o bn-ia64.o from libcrypto.a
HP-UX 11.23/64 U rx1620/64 Itanium 2/1600(2) ia64 2037 Mb
cc: HP C/aC++ B3910B A.06.15 [May 16 2007]
Did ...
| Feb 12, 12:38 pm 2008 |
| Bill Priest | git 1.5.4.1 svn fetch stops fetching w/ "Last fetch revision...
All,
I upgraded from git 1.5.3.4.452.g09149 to git
1.5.4.1 and upon a subsequent git svn fetch I started
receiving the following:
Index mismatch:
d1437ce54ff0e90f4023ee653761c28626a8295a !=
f567f1f12e7d7ddf1d18e3889061aa9a783dfbba
rereading 1c3d0737f3eb78241eb508e7da6b80e3f3b7fa85
M src/foo.c
M src/bar.c
Last fetched revision of refs/remotes/release was
r2990, but we are about to fetch: r2985!
git svn fetch w/ 1.5.3 worked correctly and subsequent
fetches "do n...
| Feb 12, 9:42 am 2008 |
| Bill Priest | Re: git 1.5.4.1 svn fetch stops fetching w/ "Last fetch revi...
Here is an update. The problem first occurs in
1.5.4.rc0 and isn't present in 1.5.3.7
FYI,
Bill
____________________________________________________________________________________
Never miss a thing. Make Yahoo your home page.
http://www.yahoo.com/r/hs
-
| Feb 12, 10:34 am 2008 |
| Mark Wooding | Re: [PATCH] daemon: Set up PATH properly on startup.
Don't need the `exec-path': git knows the right one already. So this is
entirely equivalent to my suggestion, except that the user has to jump
through this stupid hoop.
Besides, I don't want to run `git' from inetd -- it makes distinguishing
things in /etc/hosts.deny harder. Unless I write wrapper scripts or make
symlinks for everything, I suppose, but doesn't it seem mad to invent
wrapper scripts to distinguish between things which are already distinct
Yes, of course. Silly me. It's much b...
| Feb 12, 5:31 am 2008 |
| Andreas Ericsson | [PATCH 2/2] pack-objects: Use git_config_magic_int()
This lets users specify "auto" as a valid parameter to --threads
and pack.threads instead of having to remember what the magic
number 0 actually meant. 0 still works. This is just a nicer way
of saying it.
Signed-off-by: Andreas Ericsson <ae@op5.se>
---
Documentation/config.txt | 4 ++--
Documentation/git-pack-objects.txt | 4 ++--
builtin-pack-objects.c | 16 ++++++++++------
3 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/Documentation/con...
| Feb 12, 4:23 am 2008 |
| Andreas Ericsson | [PATCH 1/2] config api: Add git_config_magic_int()
There are some values where git can reasonably guess at an
optimal value. For such occasions, this is a nifty addendum
to the config api, letting the caller specify a magic string
and a magic setting to return if the value of the variable
matches the magic string.
An example would be for threads, where 0 = auto is overly
voodoo-ish for some consumers, and typing "auto" is much
nicer and more immediately obvious.
Signed-off-by: Andreas Ericsson <ae@op5.se>
---
cache.h | 1 +
confi...
| Feb 12, 4:21 am 2008 |
| Andreas Ericsson | [PATCH] pack-objects: Add runtime detection of online CPU's
Packing objects can be done in parallell nowadays, but it's
only done if the config option pack.threads is set to a value
above 1. Because of that, the code-path used is often not the
most optimal one.
This patch adds a routine to detect the number of online CPU's
at runtime (online_cpus()). When pack.threads (or --threads=) is
given a value of 0, the number of threads is set to the number of
online CPU's. This feature is also documented.
As per Nicolas Pitre's recommendations, the default is st...
| Feb 12, 4:20 am 2008 |
| Brandon Casey | Re: [PATCH] pack-objects: Add runtime detection of online CP...
if (delta_search_threads != 1)
warning("no threads support, ignoring %s", k);
I changed this to '!= 1' since that is the only time the user gets what they
asked for when THREADED_DELTA_SEARCH is not enabled. If the user requested
nthreads == ncpus by setting delta_search_threads = 0, I think we should
let the user know that thread support is not enabled, and we are ignoring
This is in the wrong place. It should be _after_ command line arguments are
Same comment as above about warning whe...
| Feb 12, 11:44 am 2008 |
| Michael Hendricks | Re: [PATCH] pack-objects: Add runtime detection of online CP...
"we can at least get get the ..."
An extra "get" snuck in there.
--
Michael
-
| Feb 12, 10:52 am 2008 |
| Bert Wesarg | Re: [PATCH] pack-objects: Add runtime detection of online CP...
Hi,
I can't find the right pointer, but for linux it would be more usable
to use sched_getaffinity(). Than you can do thinks like this:
$ taskset 0x3 git gc ...
and you will get 2 cpus, even 4 are online.
Bert
-
| Feb 12, 7:18 am 2008 |
| Andreas Ericsson | Re: [PATCH] pack-objects: Add runtime detection of online CP...
Since you can do roughly the same by saying "git pack-objects --threads=2",
I'd rather not add a GNU/Linux specific hack for this.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
-
| Feb 12, 8:21 am 2008 |
| Johannes Sixt | Re: [PATCH] pack-objects: Add runtime detection of online CP...
And now what?
If you don't provide a pthread_* implementation for Windows, you can just
drop the #ifdef _WIN32 part as long as the THREADED_DELTA_SEARCH guards
remain.
-- Hannes
-
| Feb 12, 4:49 am 2008 |
| Shawn O. Pearce | Re: [PATCH] pack-objects: Add runtime detection of online CP...
Do we have to expose this mess of namespaces to those who include
thread-utils.h? Seems like we don't, as online_cpus has a pretty
--
Shawn.
-
| Feb 12, 4:27 am 2008 |
| Junio C Hamano | What's in git.git
Config parser fixes are in 'maint', along with many other
minor fixes.
As promised, a handful topics that have been cooking in 'next'
have graduated to 'master'.
----------------------------------------------------------------
* The 'maint' branch has these fixes since v1.5.4.1
David Steven Tweed (1):
Make git prune remove temporary packs that look like write failures
Frank Lichtenheld (1):
config: Fix --unset for continuation lines
Gerrit Pape (1):
builtin-commit: remove .git/S...
| Feb 12, 3:25 am 2008 |
| Daniel Stenberg | Re: What's in git.git
But why reinitialize libcurl at all in the first place? This "work-around"
should rather be the standard behavior since there should be no logical reason
to re-initialize libcurl's global state during a git's execution.
Even though Mike correctly identified a libcurl bug, it also indirectly
identified a git flaw: re-initialization with the curl_global_* functions is
pointless and only wastes time.
-
| Feb 12, 5:15 am 2008 |
| Mike Hommey | Re: What's in git.git
Which means there remains only one initialization. I agree it's not a
workaround anymore, but the word remained from the 3 previous attempts,
which were workarounds.
Mike
-
| Feb 12, 5:47 am 2008 |
| Daniel Stenberg | Re: What's in git.git
Ah, ok. Then I'll retract my comments! :-) Sorry for not checking out the
actual code change, I only read the description!
-
| Feb 12, 7:35 am 2008 |
| Junio C Hamano | What's cooking in git.git (topics)
Here are the topics that have been kept out of 'master'.
Commits prefixed with '-' are only in 'pu' while commits
prefixed with '+' are in 'next'. Now I am pushing 1.5.4.1 out,
mature topics will start moving to 'master'.
The topics list the commits in reverse chronological order.
My wish is to have small but short release cycle for 1.5.5 and
leave bigger ones cooking for 1.6.0.
Many topics graduated to "master". As announced, I'll rewind
and rebuild "next" with the surviving topics on top o...
| Feb 12, 3:24 am 2008 |
| Johannes Schindelin | reflog-delete, was Re: What's cooking in git.git (topics)
Hi,
Well, I was in favour of making "pop" the main user visible action.
Ciao,
Dscho
-
| Feb 12, 5:57 am 2008 |
| Bruno Ribas | [PATCH] contrib/hooks/post-receive-email: checks for gitweb...
Check repository configuration gitweb.description for project description,
if $GIT_DIR/description does not exist
Signed-off-by: Bruno Ribas <ribas@c3sl.ufpr.br>
---
contrib/hooks/post-receive-email | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index 77c88eb..bdd21fa 100644
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -614,7 +614,11 @@ if [ -z "$GIT_DIR"...
| Feb 11, 11:25 pm 2008 |
| Jakub Narebski | Re: [PATCH] contrib/hooks/post-receive-email: checks for gi...
(but this can be fixed when applying).
--
Jakub Narebski
Poland
ShadeHawk on #git
-
| Feb 12, 4:17 am 2008 |
| Brandon Casey | [PATCH 2/2] pack-objects: Default to zero threads, meaning a...
Additionally, update some tests for which the multi-threaded result
differs from the single-threaded result and the single-threaded
result is expected.
Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---
Two of the tests in t5300-pack-object.sh failed when multiple
threads were used. My fix was to set --threads=1 for all pack-objects
calls. I didn't look into it any further than that. All other tests
passed.
-brandon
builtin-pack-objects.c | 2 +-
t/t5300-pack-object.sh...
| Feb 11, 10:59 pm 2008 |
| Nicolas Pitre | Re: [PATCH 2/2] pack-objects: Default to zero threads, meani...
I think the first patch is OK, but having the _default_ be
multi-threaded is going a bit too far. IMHO you should document the
meaning of the value 0, and compile with thread support whenever Posix
threads are available, but activating threads should be done explicitly.
Nicolas
-
| Feb 12, 12:57 am 2008 |
| Elijah Newren | Unable to clone an ssh repository (with ugly installation-sp...
Hi,
I'm pretty sure this worked before, but with git-1.5.4, when trying to
clone a repository via ssh from a machine that does not have git
installed in a standard system path, I get the following:
$ git clone -u /home/enewren/software/install/linux/git/bin/git-upload-pack
ssh://enewren@remote/var/scratch/enewren/votd
Initialized empty Git repository in /home/newren/devel/votd/.git/
remote: fatal: exec pack-objects failed.
remote: aborting due to possible repository corruption on the remote side...
| Feb 11, 10:22 pm 2008 |
| Jakub Narebski | Re: Unable to clone an ssh repository (with ugly installatio...
git-pull(1)
[...]
--upload-pack <upload-pack>
When given, and the repository to fetch from is handled by
git-fetch-pack, --exec=<upload-pack> is passed to the command to
specify non-default path for the command run on the other end.
--
Jakub Narebski
Poland
ShadeHawk on #git
-
| Feb 12, 4:16 am 2008 |
| Johannes Sixt | Re: Unable to clone an ssh repository (with ugly installatio...
The OP *did* use this option (rather, its short form, -u), see above.
The problem is that git-upload-pack (which is not a built-in) does not
call setup_path() and so does not extend PATH to contain the special
installation location. Now, when git-upload-pack tries to exec
git-pack-objects, it fails since this is not in PATH.
A quick work-around for Elijah is to add
GIT_EXEC_PATH=/home/enewren/software/install/linux/git/bin
to .profile on the remote host.
-- Hannes
-
| Feb 12, 4:37 am 2008 |
| Johannes Schindelin | Re: Unable to clone an ssh repository (with ugly installatio...
Hi,
I guess you meant .bashrc, as .profile is not sourced when using ssh
transport (it does not spawn a shell) AFAIR.
Ciao,
Dscho
-
| Feb 12, 6:30 am 2008 |
| previous day | today | next day |
|---|---|---|
| February 11, 2008 | February 12, 2008 | February 13, 2008 |
| Peter Zijlstra | [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock() |
| Gabriel C | Re: 2.6.24-rc2-mm1 |
| Andrew Morton | Re: [PATCH 2.6.21] cramfs: add cramfs Linear XIP |
| Jiri Kosina | Re: 2.6.21-rc5-mm4 |
git: | |
| Gregory Haskins | [RFC PATCH 00/17] virtual-bus |
| Jarek Poplawski | Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| David Miller | [GIT]: Networking |
| Gerrit Renker | [PATCH 0/37] dccp: Feature negotiation - last call for comments |
