Re: [PATCH] Add gitattributes file making whitespace checking pickier

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Brian Downing <bdowning@...>
Cc: J. Bruce Fields <bfields@...>, Daniel Barkalow <barkalow@...>, <git@...>
Date: Tuesday, February 12, 2008 - 5:42 pm

bdowning@lavos.net (Brian Downing) writes:


You are quoting an older draft.  The rules applied to 'master'
is actually a bit more lenient:

 - Unless otherwise specified, indent with SP that could be
   replaced with HT are not "bad".  But SP before HT in the
   indent is "bad", and trailing whitespaces are "bad".

 - For C source files, initial indent by SP that can be replaced
   with HT is also "bad".

 - Test scripts in t/ and test vectors in its subdirectories can
   contain anything, so we make it unrestricted for now.

So your particular "indent without HT" is generally accepted,
and considered a violation only in C sources.

I see what you mean by "excempt from all rules" and it is
certainly a valid approach, but I at the same time think minimal
whitespace policy should be there, and flagging trailing spaces
and SP before HT is a good idea.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] Add gitattributes file making whitespace checkin..., Junio C Hamano, (Tue Feb 12, 5:42 pm)