Re: [PATCH] Add compat/fopen.c which returns NULL on attempt to open directory

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: H.Merijn Brand <h.m.brand@...>
Cc: Brandon Casey <casey@...>, Morten Welinder <mwelinder@...>, Git Mailing List <git@...>
Date: Monday, February 11, 2008 - 8:20 pm

"H.Merijn Brand" <h.m.brand@xs4all.nl> writes:


I think your "git clone" is broken and I strongly suspect it is
not your shell (at least the "if" construct in the test).

What's 

	if $?; then

In sane shells, I think this tries to execute 0 or perhaps 124
or whatever the error code from clone as if it was the name of a
command, which would most likely fail and would not take "then"
part (which reports the error).  It did not fix, but just made
it ignore the error from "git clone".

If it were

	if test $? != 0
        then

it would have made a bit more sense.

And if (this is a big "if" as I doubt any shell is so broken)
these two are equivalent to your shell, then I do not think it
is portable at all.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] Add compat/fopen.c which returns NULL on attempt..., Junio C Hamano, (Mon Feb 11, 8:20 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., Johannes Schindelin, (Fri Feb 8, 4:40 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., Johannes Schindelin, (Fri Feb 8, 5:47 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., Johannes Schindelin, (Fri Feb 8, 4:38 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., Johannes Schindelin, (Fri Feb 8, 4:44 pm)