Re: [PATCH] git-pull documentation: fix linkgit in the --rebase option description.

Previous thread: Re: Upcoming memcached releases + rambling. by Jakub Narebski on Monday, February 11, 2008 - 5:50 am. (1 message)

Next thread: problem with git rebase -i by Uwe on Monday, February 11, 2008 - 6:44 am. (4 messages)
From: Miklos Vajna
Date: Monday, February 11, 2008 - 6:28 am

We do not have newlines before NOTEs at other places either, like git clone -s
documentation and removing that newline turns 'linkgit:git\-rebase[1]' to
'\fBgit-rebase\fR(1)' properly.

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
 Documentation/git-pull.txt |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/Documentation/git-pull.txt b/Documentation/git-pull.txt
index 4cc633a..b9bc6ed 100644
--- a/Documentation/git-pull.txt
+++ b/Documentation/git-pull.txt
@@ -39,7 +39,6 @@ include::merge-strategies.txt[]
 	there is a remote ref for the upstream branch, and this branch
 	was rebased since last fetched, the rebase uses that information
 	to avoid rebasing non-local changes.
-
 	*NOTE:* This is a potentially _dangerous_ mode of operation.
 	It rewrites history, which does not bode well when you
 	published that history already.  Do *not* use this option
-- 
1.5.4

-

From: Johannes Schindelin
Date: Monday, February 11, 2008 - 8:15 am

Hi,


The intention was to force a new paragraph.  The *NOTE* should be loud and 
clear, so that those few people who read man pages are properly warned 
that --rebase is a dangerous option if you do not know what you are doing.

Ciao,
Dscho

-

From: Miklos Vajna
Date: Monday, February 11, 2008 - 11:29 am

On Mon, Feb 11, 2008 at 03:15:31PM +0000, Johannes Schindelin <Johannes.Sch=

i see your point and i played with it a bit, no success so far. if it
becomes a new paragraph, the linkgit: is not processed. maybe it's an
asciidoc bug?

(is it better to have it as a new paragraph with linkgit: shown? hmm)

thanks,
- VMiklos
From: Junio C Hamano
Date: Monday, February 11, 2008 - 12:10 pm

You probably meant to do this, then.


 Documentation/git-pull.txt |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/git-pull.txt b/Documentation/git-pull.txt
index 4cc633a..179bdfc 100644
--- a/Documentation/git-pull.txt
+++ b/Documentation/git-pull.txt
@@ -39,11 +39,11 @@ include::merge-strategies.txt[]
 	there is a remote ref for the upstream branch, and this branch
 	was rebased since last fetched, the rebase uses that information
 	to avoid rebasing non-local changes.
-
-	*NOTE:* This is a potentially _dangerous_ mode of operation.
-	It rewrites history, which does not bode well when you
-	published that history already.  Do *not* use this option
-	unless you have read linkgit:git-rebase[1] carefully.
++
+*NOTE:* This is a potentially _dangerous_ mode of operation.
+It rewrites history, which does not bode well when you
+published that history already.  Do *not* use this option
+unless you have read linkgit:git-rebase[1] carefully.
 
 \--no-rebase::
 	Override earlier \--rebase.
-

From: Johannes Schindelin
Date: Monday, February 11, 2008 - 2:13 pm

Hi,


Thanks.  At some point, it feels (at least to me) that the ease of 
use of asciidoc just vanishes...

Ciao,
Dscho
-

From: Miklos Vajna
Date: Monday, February 11, 2008 - 5:08 pm

ah, great. then i'll send a patch to change git clone -s' NOTE like
this.

thanks,
- VMiklos
Previous thread: Re: Upcoming memcached releases + rambling. by Jakub Narebski on Monday, February 11, 2008 - 5:50 am. (1 message)

Next thread: problem with git rebase -i by Uwe on Monday, February 11, 2008 - 6:44 am. (4 messages)