Home » Mailing list archives » git » 2008 » February » 11

Re: [PATCH] Add compat/fopen.c which returns NULL on attempt to open directory

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: H.Merijn Brand <h.m.brand@...>
To: H.Merijn Brand <h.m.brand@...>
Cc: Brandon Casey <casey@...>, Junio C Hamano <gitster@...>, Morten Welinder <mwelinder@...>, Git Mailing List <git@...>
Subject: Re: [PATCH] Add compat/fopen.c which returns NULL on attempt to open directory
Date: Monday, February 11, 2008 - 6:15 am

On Mon, 11 Feb 2008 10:29:50 +0100, "H.Merijn Brand" <h.m.brand@xs4all.nl>
wrote:


No, it is not. Some shell weirdness. This fixes it. Don't know off-hand
if it is portable enough

diff -pur a/t/t5701-clone-local.sh b/t/t5701-clone-local.sh
--- a/t/t5701-clone-local.sh  2008-02-02 05:09:01 +0100
+++ b/t/t5701-clone-local.sh  2008-02-11 11:13:26 +0100
@@ -37,8 +37,8 @@ test_expect_success 'local clone from x'

 test_expect_success 'local clone from x.git that does not exist' '
        cd "$D" &&
-       if git clone -l -s x.git z
-       then
+       git clone -l -s x.git z
+       if $? ; then
                echo "Oops, should have failed"
                false
        else

-- 
H.Merijn Brand         Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using & porting perl 5.6.2, 5.8.x, 5.10.x  on HP-UX 10.20, 11.00, 11.11,
& 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin.       http://qa.perl.org
http://mirrors.develooper.com/hpux/            http://www.test-smoke.org
                        http://www.goldmark.org/jeff/stupid-disclaimers/
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] opening files in remote.c should ensure it is openin..., H.Merijn Brand, (Fri Feb 8, 12:46 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., Morten Welinder, (Fri Feb 8, 4:15 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., Junio C Hamano, (Fri Feb 8, 4:33 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., Brandon Casey, (Fri Feb 8, 9:20 pm)
[PATCH] Add compat/fopen.c which returns NULL on attempt to ..., Brandon Casey, (Fri Feb 8, 10:32 pm)
Re: [PATCH] Add compat/fopen.c which returns NULL on attempt..., H.Merijn Brand, (Mon Feb 11, 5:29 am)
Re: [PATCH] Add compat/fopen.c which returns NULL on attempt..., H.Merijn Brand, (Mon Feb 11, 6:15 am)
Re: [PATCH] Add compat/fopen.c which returns NULL on attempt..., Junio C Hamano, (Mon Feb 11, 8:20 pm)
Re: [PATCH] Add compat/fopen.c which returns NULL on attempt..., H.Merijn Brand, (Tue Feb 12, 11:27 am)
Re: [PATCH] opening files in remote.c should ensure it is op..., Brandon Casey, (Fri Feb 8, 4:58 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., Junio C Hamano, (Sat Feb 9, 1:12 am)
Re: [PATCH] opening files in remote.c should ensure it is op..., Brandon Casey, (Fri Feb 8, 5:14 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., Johannes Schindelin, (Fri Feb 8, 4:40 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., Junio C Hamano, (Fri Feb 8, 5:19 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., Johannes Schindelin, (Fri Feb 8, 5:47 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., Junio C Hamano, (Fri Feb 8, 4:09 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., H.Merijn Brand, (Sat Feb 9, 6:03 am)
Re: [PATCH] opening files in remote.c should ensure it is op..., Johannes Schindelin, (Fri Feb 8, 4:38 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., Mike Ralphson, (Fri Feb 8, 1:25 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., Daniel Barkalow, (Fri Feb 8, 4:36 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., Junio C Hamano, (Sat Feb 9, 1:27 am)
Re: [PATCH] opening files in remote.c should ensure it is op..., Daniel Barkalow, (Sat Feb 9, 1:54 am)
Re: [PATCH] opening files in remote.c should ensure it is op..., Johannes Schindelin, (Fri Feb 8, 4:44 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., H.Merijn Brand, (Fri Feb 8, 4:04 pm)
Re: [PATCH] opening files in remote.c should ensure it is op..., H.Merijn Brand, (Mon Feb 18, 5:10 am)
Re: [PATCH] opening files in remote.c should ensure it is op..., Junio C Hamano, (Mon Feb 18, 5:30 am)
Re: [PATCH] opening files in remote.c should ensure it is op..., H.Merijn Brand, (Mon Feb 18, 7:31 am)