Re: [PATCH 2/5] git send-email: interpret unknown files as revision lists

Previous thread: [(v2) PATCH 1/2] tag: Check that options are only allowed in the appropriate mode by Samuel Tardieu on Tuesday, November 4, 2008 - 7:20 pm. (3 messages)

Next thread: Re: [PATCH 4/5] git send-email: ask less questions when --compose is used. by Junio C Hamano on Tuesday, November 4, 2008 - 7:54 pm. (1 message)
To: Pierre Habouzit <madcoder@...>
Cc: <git@...>
Date: Tuesday, November 4, 2008 - 7:54 pm

We seem to use File::Temp::tempdir already elsewhere, but they are in
archimport, cvsexportcommit and cvsserver, all of which are rather rarely
used ones. I think this is Perl 5.6.1 addition. Is everybody Ok with

Perhaps wording this a bit more to the point? This is triggered when
'$f' can be both a filename or a revision, so...

File '$f' exists but it could also be the range of commits
to produce patches for. Please disambiguate by...

* Saying "./$f" if you mean a file; or
* Giving -F option if you mean a range.

Earlier I suggested that "origin^0" is a way for the user to disambiguate
favouring a rev, but such a filename can exist, so we cannot blindly
suggest to say "$f^0" here. I think adding -F (or --format-patch) option
to send-email to explicitly disable file/directory interpretation would be
a cleaner solution for this (and it would allow you to drive this from a
script without worrying about what garbage files you happen to have in the
working tree).
--

To: Junio C Hamano <gitster@...>
Cc: Jeff King <peff@...>, <git@...>
Date: Wednesday, November 5, 2008 - 6:40 am

Okay, still having --[no-]format-patch is probably a good idea indeed
for scripts. Will do.

This will break previous editor syntax hilighting stuff even more, and
has the drawback that you can't put shell sniplets in here. I think it's

Probably, I kept what was done as is, but we probably want do_edit() to
die() if the user killed it.

Will do

--=20
=C2=B7O=C2=B7 Pierre Habouzit
=C2=B7=C2=B7O madcoder@debia=
n.org
OOO http://www.madism.org

To: Pierre Habouzit <madcoder@...>
Cc: Jeff King <peff@...>, <git@...>
Date: Sunday, November 9, 2008 - 2:56 pm

Thanks.
--

To: Pierre Habouzit <madcoder@...>
Cc: Jeff King <peff@...>, <git@...>
Date: Wednesday, November 5, 2008 - 11:17 am

Ah, please scratch that "I really think" --- my mistake.

I did not check nor realize "GIT:" is what send-email already does.

--

Previous thread: [(v2) PATCH 1/2] tag: Check that options are only allowed in the appropriate mode by Samuel Tardieu on Tuesday, November 4, 2008 - 7:20 pm. (3 messages)

Next thread: Re: [PATCH 4/5] git send-email: ask less questions when --compose is used. by Junio C Hamano on Tuesday, November 4, 2008 - 7:54 pm. (1 message)