Re: [RFC PATCH 0/4] deny push to current branch of non-bare repo

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jeff King <peff@...>
Cc: <git@...>, Sam Vilain <sam@...>
Date: Saturday, November 8, 2008 - 4:49 pm

Jeff King <peff@peff.net> writes:


I meant to suggest that change contained in 3/4 can instead be "set the
configuration to allow such a dangerous push upfront, and make sure the
pushes the current tests perform actually are still allowed", _if_ you are
changing the default to forbid.

I think the default should be to warn for two release cycles during which
we will give deprecation notice, and then switch the default to forbid
(and we do not touch "git init/git clone" at all --- changing the default
to forbid in newly created repositories earlier than existing repositories
would be changing the behaviour of the command between old and new
repositories, which is madness).  If we are going this route, I think we
can modify the tests 3/4 touches to set the configuration to allow such a
push and make sure that such a push is still allowed.



--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [RFC PATCH 0/4] deny push to current branch of non-bare ..., Junio C Hamano, (Sat Nov 8, 4:49 pm)
Re: [RFC PATCH 0/4] deny push to current branch of non-bare ..., Johannes Schindelin, (Sat Nov 8, 11:12 am)
[PATCH 2/4] t5516: refactor oddball tests, Jeff King, (Fri Nov 7, 6:20 pm)