Re: [PATCH (GITK) v3 3/6] gitk: Add accelerators to frequently used menu commands.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Alexander Gavrilov <angavrilov@...>
Cc: <git@...>
Date: Friday, November 7, 2008 - 7:50 am

Alexander Gavrilov writes:


This is solving the problem that the $M1T doesn't get expanded in the
call below because it's inside {}.  If we are going to have a magic
string that gets expanded like this, I'd rather it didn't look like a
variable reference, because that is confusing.

Alternatively, we could define a [meta] function that does this:

proc meta {x} {
    if {[tk windowingsystem] eq "aqua"} {
	return Cmd-$x
    }
    return Ctrl-$x
}

and then use -accelerator [meta F5] in the makemenu call, and not have
any magic string substitution in makemenu.  That will work since the
eval will evaluate the [].

Paul.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH (GITK) v3 0/6] Enhance popup dialogs in gitk., Alexander Gavrilov, (Sun Nov 2, 2:59 pm)
[PATCH (GITK) v3 1/6] gitk: Add Return and Escape bindings t..., Alexander Gavrilov, (Sun Nov 2, 2:59 pm)
[PATCH (GITK) v3 2/6] gitk: Make gitk dialog windows transie..., Alexander Gavrilov, (Sun Nov 2, 2:59 pm)
[PATCH (GITK) v3 3/6] gitk: Add accelerators to frequently u..., Alexander Gavrilov, (Sun Nov 2, 2:59 pm)
Re: [PATCH (GITK) v3 3/6] gitk: Add accelerators to frequent..., Paul Mackerras, (Fri Nov 7, 7:50 am)
Re: [PATCH (GITK) v3 3/6] gitk: Add accelerators to frequent..., Alexander Gavrilov, (Sun Nov 9, 7:21 am)
[PATCH (GITK) v3 4/6] gitk: Make cherry-pick call git-citool..., Alexander Gavrilov, (Sun Nov 2, 2:59 pm)
[PATCH (GITK) v3 5/6] gitk: Implement a user-friendly Edit V..., Alexander Gavrilov, (Sun Nov 2, 2:59 pm)