Re: overly smart rebase - bug or feature?

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Junio C Hamano <gitster@...>
Cc: Fedor Sergeev <Fedor.Sergeev@...>, <Roman.Shaposhnick@...>, <git@...>
Date: Monday, November 10, 2008 - 7:31 pm

On Mon, Nov 10, 2008 at 6:14 PM, Junio C Hamano <gitster@pobox.com> wrote:

But isn't rename detection in this case rather suspicious, since:

- the preimage already had Makefile, Makefile1, and Makefile2, thus it
is not a rename, but at most a copy, and not even a newly-created copy
in either branch;

- *two* different files match the original Makefile, but rebase has
randomly selected one but not the other;

- (I haven't verified this claim) cherry-pick and merge both correctly
identify the problem as a delete/modify conflict?

It seems that rebase should have bailed out for at least one of these
three reasons.

Avery
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
overly smart rebase - bug or feature?, Fedor Sergeev, (Mon Nov 10, 5:23 pm)
Re: overly smart rebase - bug or feature?, Junio C Hamano, (Mon Nov 10, 7:14 pm)
Re: overly smart rebase - bug or feature?, Fedor Sergeev, (Wed Nov 12, 5:39 pm)
Re: overly smart rebase - bug or feature?, Junio C Hamano, (Wed Nov 12, 6:04 pm)
Re: overly smart rebase - bug or feature?, Fedor Sergeev, (Mon Nov 10, 7:36 pm)
Re: overly smart rebase - bug or feature?, Junio C Hamano, (Mon Nov 10, 7:57 pm)
Re: overly smart rebase - bug or feature?, Avery Pennarun, (Mon Nov 10, 7:31 pm)