Re: [PATCH] git push: Interpret $GIT_DIR/branches in a Cogito compatible way

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Martin Koegler <mkoegler@...>

Cc: <git@...>

Subject: Re: [PATCH] git push: Interpret $GIT_DIR/branches in a Cogito compatible way

Date: Monday, November 10, 2008 - 7:25 pm

Martin Koegler <mkoegler@auto.tuwien.ac.at> writes:

quoted text> Current git versions ignore everything after # (called <head> in the
> following) when pushing. Older versions (before cf818348f1ab57),
> interpret #<head> as part of the URL, which make git bail out.
>
> Ignoring the <head> part for push (fetch respects them) is unlogical.
> As branches origin from Cogito, it is the best to correct this by
> using the behaviour of cg-push:
>
> push HEAD to remote refs/heads/<head>
>
> Signed-off-by: Martin Koegler <mkoegler@auto.tuwien.ac.at>

This message was addressed to me, but is it meant for inclusion?

I do not recall seeing an agreement on what the desired behaviour should
be from (ex-)Cogito users, if this change of behaviour hurts real world
usage of existing git users, andr if so how we ease this change in to the
release.

While I'd personally agree matching with whatever cg-push used to do might
make the most sense in the end, I am not sure changing of behaviour
abruptly like this is a good idea.

I am also not so sure url#branch is illogical; I'd suggest dropping that
line from the commit log message in any case.

quoted text> +
> +Depending on the operation, git will use one of the following
> +refsprecs, if you don't provide one on the command line.
> +`<branch>` is the name of this file in `$GIT_DIR/branches` and
> +`<head>` defaults to `master`.
> +
> +git fetch uses:
> +
> +------------
> +	refs/heads/<head>:refs/heads/<branch>
> +------------
> +
> +git push uses:
>  
>  ------------
> -	refs/heads/<head>:<repository>
> +	HEAD:refs/heads/<head>
>  ------------

Why isn't this "refs/heads/<head>:refs/heads/<head>", by the way?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] git push: Interpret $GIT_DIR/branches in a Cogito co..., Martin Koegler, (Mon Nov 10, 5:47 pm)

Re: [PATCH] git push: Interpret $GIT_DIR/branches in a Cogit..., Mike Ralphson, (Tue Nov 11, 4:45 am)

Re: [PATCH] git push: Interpret $GIT_DIR/branches in a Cogit..., Junio C Hamano, (Mon Nov 10, 7:25 pm)

Re: [PATCH] git push: Interpret $GIT_DIR/branches in a Cogit..., Martin Koegler, (Tue Nov 11, 4:37 am)

Re: [PATCH] git push: Interpret $GIT_DIR/branches in a Cogit..., Junio C Hamano, (Tue Nov 11, 1:25 pm)


linux-kernel:
Zach Brown	[PATCH 3 of 4] Teach paths to wake a specific void * target instead of a whole tas...
Linus Torvalds	Re: LSM conversion to static interface
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Andrew Morton	-mm merge plans for 2.6.23
git:

linux-netdev:
Gregory Haskins	[RFC PATCH 00/17] virtual-bus
David Miller	[GIT]: Networking
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
openbsd-misc:

Re: [PATCH] git push: Interpret $GIT_DIR/branches in a Cogito compatible way

Online users