Home » Mailing list archives » git » 2008 » October » 3

Re: [PATCH] rebase -i: proper prepare-commit-msg hook argument when squashing

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jeff King <peff@...>
To: SZEDER <szeder@...>
Cc: Shawn O. Pearce <spearce@...>, <git@...>
Subject: Re: [PATCH] rebase -i: proper prepare-commit-msg hook argument when squashing
Date: Friday, October 3, 2008 - 2:01 am

On Fri, Oct 03, 2008 at 02:08:21AM +0200, SZEDER Gábor wrote:


Sorry, but "cp -v" is not portable. It's not in POSIX, and this breaks
the script for (at least) Solaris.

However, it's not even clear to me why "-v" is used at all, considering
that the "squash" case above does not use it. Is it a debugging
leftover? Am I missing something?

[Aside: My Solaris 8 autobuilder is now running, which was a huge pain.
However, it is very satisfying to catch things like this in "next"
before they hit a wider audience.]

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] rebase -i: proper prepare-commit-msg hook argument w..., SZEDER Gábor, (Thu Oct 2, 8:08 pm)
Re: [PATCH] rebase -i: proper prepare-commit-msg hook argume..., Jeff King, (Fri Oct 3, 2:01 am)
rebase -i: remove leftover debugging, SZEDER , (Fri Oct 3, 5:33 am)