git mailing list

FromSubjectsort iconDate
Sverre Rabbelier
Pull request for sub-tree merge into /contrib/gitstats
My work is available in the git repository at: git://repo.or.cz/git-stats.git master Please use a subtree merge to put this in contrib/gitstats. David Symonds (2): Insert the git_stats path to the start of os.sys.path, not 1 element in. Fix some spelling mistakes. Sverre Rabbelier (237): Created a script to setup a repo to test metrics on. Converted the setupRepo script to python to allow creating the same repo. Added the use cases in text form. Added ...
Oct 29, 7:06 pm 2008
Nicolas Pitre
Re: Pull request for sub-tree merge into /contrib/gitstats
[...] ? If those are not significant enough to have a proper description, then I'd suggest you use 'git rebase -i' and its "squash" command to fold them into the appropriate commit. Nicolas --
Oct 29, 7:31 pm 2008
Sverre Rabbelier
Re: Pull request for sub-tree merge into /contrib/gitstats
They are there because the work was done incrementally, having them as seperate commits shows when the changelog was modified. Having a description for a change to the changelog is pretty senseless, since it would be the same text as what is in the diff. That said, sure, I can squash those commits no problem. -- Cheers, Sverre Rabbelier --
Oct 29, 7:38 pm 2008
Shawn O. Pearce
Re: Pull request for sub-tree merge into /contrib/gitstats
... How is this going to look in the "What's in git.git" email? We don't use ChangeLog files in git.git and we don't have notes branches, and we already have a README. Most stuff in contrib/ has its commit messages with a prefix string to make it more clear when looking at the shortlog what is being impacted. Maybe this should be re-written with filter-branch to include a prefix before it merges. -- Shawn. --
Oct 29, 7:12 pm 2008
Sverre Rabbelier
Re: Pull request for sub-tree merge into /contrib/gitstats
Sure, I'm fine with rewriting all commit messages to have a "gitstats:" prefix. -- Cheers, Sverre Rabbelier --
Oct 29, 7:39 pm 2008
Nicolas Pitre
[PATCH 9/9] pack-objects: don't leak pack window reference w...
Signed-off-by: Nicolas Pitre <nico@cam.org> --- builtin-pack-objects.c | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c index 826c762..c93d69a 100644 --- a/builtin-pack-objects.c +++ b/builtin-pack-objects.c @@ -389,22 +389,28 @@ static unsigned long write_object(struct sha1file *f, dheader[pos] = ofs & 127; while (ofs >>= 7) dheader[--pos] = 128 | (--ofs & 127); - if (limit &a...
Oct 29, 7:02 pm 2008
Nicolas Pitre
[PATCH 0/9] more robustness against pack corruptions
A few months ago I produced a set of patches to allow git to work even in the presence of pack corruption given that the corrupted objects have a good duplicate in the object store. Turns out that this work was rather incomplete and covered only a limited set of cases. This series extend coverage to all cases I could think about, and make repack-objects able to create a good pack in such conditions to "fix" the corruption without having to perform a full repack. Yes, this is all about the small ...
Oct 29, 7:02 pm 2008
Nicolas Pitre
[PATCH 1/9] close another possibility for propagating pack c...
Abstract -------- With index v2 we have a per object CRC to allow quick and safe reuse of pack data when repacking. this, however, doesn't currently prevent a stealth corruption from being propagated into a new pack when _not_ reusing pack data as demonstrated by the modification to t5302 included here. The Context ----------- The Git database is all checksumed with SHA1 hashes. Any kind of corruption can be confirmed by verifying this per object hash against corresponding data. However ...
Oct 29, 7:02 pm 2008
Nicolas Pitre
[PATCH 2/9] better validation on delta base object offsets
In one case, it was possible to have a bad offset equal to 0 effectively pointing a delta onto itself and crashing git after too many recursions. In the other cases, a negative offset could result due to off_t being signed. Catch those. Signed-off-by: Nicolas Pitre <nico@cam.org> --- builtin-pack-objects.c | 4 ++-- builtin-unpack-objects.c | 2 ++ index-pack.c | 2 +- sha1_file.c | 2 +- 4 files changed, 6 insertions(+), 4 deletions(-) diff --gi...
Oct 29, 7:02 pm 2008
Nicolas Pitre
[PATCH 3/9] make unpack_object_header() non fatal
It is possible to have pack corruption in the object header. Currently unpack_object_header() simply die() on them instead of letting the caller deal with that gracefully. So let's have unpack_object_header() return an error instead, and find a better name for unpack_object_header_gently() in that context. All callers of unpack_object_header() are ready for it. Signed-off-by: Nicolas Pitre <nico@cam.org> --- builtin-pack-objects.c | 2 +- cache.h | 2 +- sha1_file...
Oct 29, 7:02 pm 2008
Nicolas Pitre
[PATCH 4/9] make packed_object_info() resilient to pack corr...
In the same spirit as commit 8eca0b47ff, let's try to survive a pack corruption by making packed_object_info() able to fall back to alternate packs or loose objects. Signed-off-by: Nicolas Pitre <nico@cam.org> --- sha1_file.c | 36 ++++++++++++++++++++++++++++++------ 1 files changed, 30 insertions(+), 6 deletions(-) diff --git a/sha1_file.c b/sha1_file.c index 7698177..384a430 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -1314,8 +1314,10 @@ unsigned long get_size_from_delta(struct ...
Oct 29, 7:02 pm 2008
Nicolas Pitre
[PATCH 5/9] make check_object() resilient to pack corruptions
The check_object() function tries to get away with the least amount of pack access possible when it already has partial information on given object rather than calling the more costly packed_object_info(). When things don't look right, it should just give up and fall back to packed_object_info() directly instead of die()'ing. Signed-off-by: Nicolas Pitre <nico@cam.org> --- builtin-pack-objects.c | 23 +++++++++++++++++------ 1 files changed, 17 insertions(+), 6 deletions(-) diff --gi...
Oct 29, 7:02 pm 2008
Nicolas Pitre
[PATCH 6/9] make find_pack_revindex() aware of the nasty world
It currently calls die() whenever given offset is not found thinking that such thing should never happen. But this offset may come from a corrupted pack whych _could_ happen and not be found. Callers should deal with this possibility gracefully instead. Signed-off-by: Nicolas Pitre <nico@cam.org> --- builtin-pack-objects.c | 2 ++ pack-revindex.c | 3 ++- sha1_file.c | 18 ++++++++++++------ 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/built...
Oct 29, 7:02 pm 2008
Nicolas Pitre
[PATCH 7/9] pack-objects: allow "fixing" a corrupted pack wi...
When the pack data to be reused is found to be bad, let's fall back to full object access through the generic path which has its own strategies to find alternate object sources in that case. This allows for "fixing" a corrupted pack simply by copying either another pack containing the object(s) found to be bad, or the loose object itself, into the object store and launch a repack without the need for -f. Signed-off-by: Nicolas Pitre <nico@cam.org> --- builtin-pack-objects.c | 28 ++++++++...
Oct 29, 7:02 pm 2008
Nicolas Pitre
[PATCH 8/9] extend test coverage for latest pack corruption ...
Signed-off-by: Nicolas Pitre <nico@cam.org> --- t/t5303-pack-corruption-resilience.sh | 96 ++++++++++++++++++++++++++++++--- 1 files changed, 89 insertions(+), 7 deletions(-) diff --git a/t/t5303-pack-corruption-resilience.sh b/t/t5303-pack-corruption-resilience.sh index 31b20b2..ac181ea 100755 --- a/t/t5303-pack-corruption-resilience.sh +++ b/t/t5303-pack-corruption-resilience.sh @@ -41,11 +41,17 @@ create_new_pack() { git verify-pack -v ${pack}.pack } +do_repack() { + p...
Oct 29, 7:02 pm 2008
J. Longman
jgit as a jira plugin
Hey there, I've integrated jgit into a plugin for the Jira Issue tracking system. There is more information here: http://confluence.atlassian.com/display/JIRAEXT/Jira+Git+Plugin I'm new to git, jgit and jira plugin writing, so I have a number of questions. These are the ones I have for you: 1) I noticed that there is a maven pom file. Are you present in a maven repository? Also any problem with embedding a working snapshot in my plugin? 2) I'd like to find out the jgit way to achie...
Oct 29, 7:02 pm 2008
Shawn O. Pearce
Re: jgit as a jira plugin
No, we aren't hosted in any repository yet. The pom file exists to make it easier for people who prefer maven to build, but its not the Use a Transport instance to execute a default fetch (no args) on say the "remote" origin. That will download the objects to the local database, but it won't update a working directory. But I'm not sure Yea, about that, we wanted to write more tutorials on the API... ;-) -- Shawn. --
Oct 29, 7:08 pm 2008
J. Longman
Re: jgit as a jira plugin
Basically I stole the pgm.Fetch code: Transport tn = Transport.open(repository, "origin"); final FetchResult r; List<RefSpec> toget = new ArrayList<RefSpec>(); try { r = tn.fetch(new TextProgressMonitor(), toget); } finally { tn.close(); } Can I assume that this enough to update the database? If so I think I'm doing what you're suggesting. After this (and not shown) is some logging code taken from Fetch, which results in the following: From /Users/longman/workspace...
Oct 29, 7:49 pm 2008
Shawn O. Pearce
Re: jgit as a jira plugin
Well, the new changes are what "git log 131dcf5..078d43f" outputs. -- Shawn. --
Oct 29, 7:53 pm 2008
Leo Razoumov
request for pre-generated git.info pages
I am an emacs user but with my current setup I have difficulties generating git.info pages. Main Git repo already provides pre-generated man and html documentation in "man" and "html" branches. I would kindly beg to extend this privilege to "info" pages to benefit all the emacs users out there. --Leo-- --
Oct 29, 6:00 pm 2008
Jeff King
a few git notes numbers
I looked a little bit at how bad tree lookup speed would be for notes. My test implementation was a notes tree made like this: blob=`echo this is a note | git hash-object -w --stdin` export GIT_INDEX_FILE=.git/notes # attach the note to every commit; # note that this uses a less-efficient ascii encoding git rev-list HEAD | while read commit; do echo -e "100644 blob $blob\t$commit" done | git update-index --index-info tree=`git write-tree` commit=`echo notes | git commit-tree $tree` ...
Oct 29, 5:40 pm 2008
Anders Melchiorsen
[PATCH 4/7] Documentation: remove a redundant elaboration
The comment in parentheses is wrong, as one has to leave out both the colon and <dst>. This situation is covered by the section a few lines down: A parameter <ref> without a colon pushes the <ref> from the source repository to the destination repository under the same name. So, just remove the parentheses. Signed-off-by: Anders Melchiorsen <mail@cup.kalibalik.dk> --- Documentation/git-push.txt | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --...
Oct 29, 4:25 pm 2008
Anders Melchiorsen
[PATCH 5/7] Documentation: elaborate on pushing tags
Make the description of pushing tags easier to read, but move the shorthand notation towards the end of the description. This gives a better flow. Signed-off-by: Anders Melchiorsen <mail@cup.kalibalik.dk> --- Documentation/git-push.txt | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt index 9788d49..52035db 100644 --- a/Documentation/git-push.txt +++ b/Documentation/git-push.txt @@ -38,7 +38,7 @@ OPTIO...
Oct 29, 4:25 pm 2008
Daniel Barkalow
Re: [PATCH 5/7] Documentation: elaborate on pushing tags
I think this should be "When pushing a tag, ...", to avoid confusion with "--tags", which pushes (all) tags and doesn't need the "tag <tag>" arguments. -Daniel *This .sig left intentionally blank* --
Oct 29, 4:40 pm 2008
Anders Melchiorsen
[PATCH 6/7] Documentation: mention branches rather than heads
Most of the git push page talks about branches, so make it consistent also in this paragraph. Signed-off-by: Anders Melchiorsen <mail@cup.kalibalik.dk> --- Documentation/git-push.txt | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt index 52035db..4e339c7 100644 --- a/Documentation/git-push.txt +++ b/Documentation/git-push.txt @@ -53,8 +53,8 @@ Pushing an empty <src> allows you to delete the <dst&g...
Oct 29, 4:25 pm 2008
Anders Melchiorsen
[PATCH 7/7] Documentation: avoid using undefined parameters
The <ref> parameter has not been introduced, so rewrite to avoid it. Signed-off-by: Anders Melchiorsen <mail@cup.kalibalik.dk> --- Documentation/git-push.txt | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt index 4e339c7..e848ff9 100644 --- a/Documentation/git-push.txt +++ b/Documentation/git-push.txt @@ -46,8 +46,8 @@ to fast forward the remote ref that matches <dst>. If the optional leadin...
Oct 29, 4:25 pm 2008
Anders Melchiorsen
Some updates to refspec documentation
I have skimmed the git-push manpage many times over a period of several months, without fully understanding it. Today I sat down and figured it out. It took some experiments and a little reading of the source. Here I offer some updates to the refspec documentation, so that others can hopefully learn it faster than I did. As I expect some changes to be more controversial than others, I have split it up in several small parts. Feel free to squash. There is a risk that I have changed some things ...
Oct 29, 4:25 pm 2008
Anders Melchiorsen
Re: Some updates to refspec documentation
During my struggle, I also found a git push usability problem. The refspec ":dst" will delete the remote branch without warning. While this is indeed documented, you cannot blame somebody for thinking that a left out <src> will default to HEAD, as it does for so many other commands. In a CVS-like setup, with everybody pushing to master, this could cause havoc. As the "git push <repository> :<dst>" operation is destructive, I think it should be protected by the -f option. F...
Oct 29, 4:41 pm 2008
Anders Melchiorsen
Re: Some updates to refspec documentation
I actually think that <src> defaulting to HEAD would be reasonable, but it is probably less reasonable to change the meaning at this point. Anders --
Oct 29, 4:44 pm 2008
Anders Melchiorsen
[PATCH 1/7] Documentation: do not use regexp in refspec desc...
The refspec format description was a mix of regexp and BNF, making it very difficult to read. The syntax is now easier to read, though wrong: all parts of the refspec are actually optional. Signed-off-by: Anders Melchiorsen <mail@cup.kalibalik.dk> --- Documentation/git-push.txt | 2 +- Documentation/pull-fetch-param.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt index 6150b1b..df99c0b 1006...
Oct 29, 4:25 pm 2008
Anders Melchiorsen
[PATCH 2/7] Documentation: git push repository can also be a...
This is copied from pull-fetch-param.txt and helps the reader to not get stuck in the URL section. Signed-off-by: Anders Melchiorsen <mail@cup.kalibalik.dk> --- Documentation/git-push.txt | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt index df99c0b..02c7dae 100644 --- a/Documentation/git-push.txt +++ b/Documentation/git-push.txt @@ -28,7 +28,9 @@ OPTIONS ------- <repository>:: The "remote" r...
Oct 29, 4:25 pm 2008
Anders Melchiorsen
[PATCH 3/7] Documentation: rework SHA1 description in git push
Get rid of a double pair of parentheses. The arbitrary SHA1 is a special case, so it can be postponed a bit. Also mention HEAD, which is possibly the most useful SHA1 in this situation. Mention that a SHA1 cannot be automatically matched to a <dst>. Add HEAD as an example of an arbitrary SHA1. Signed-off-by: Anders Melchiorsen <mail@cup.kalibalik.dk> --- Documentation/git-push.txt | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/Documentatio...
Oct 29, 4:25 pm 2008
David Kågedal
Re: [PATCH] Implement git-staged, an alias for 'git diff --c...
One irregularity hear is that there is no way to explicitly say what you want to compare against the index (the staging area). Diff compares two things to each other, and a more regular and general way to express what it does would be something like git diff STAGE WORKTREE (like "git diff" today) git diff HEAD WORKTREE (like "git diff HEAD" today) git diff WORKTREE HEAD (like "git diff -R HEAD" today) git diff HEAD STAGE (like "git diff --cached" today) git dif...
Oct 29, 4:24 pm 2008
Teemu Likonen
A typesetting problem with git man pages
I compile git and its man pages myself and I just noticed that the man pages (invoked with "git help log", for example) have a typesetting problem. There are ".ft" commands here and there, like this: .ft C [i18n] commitencoding = ISO-8859-1 .ft Does anybody know why "man" prints those ".ft" commands? The corresponding code in git-log.1 file is this: \&.ft C [i18n] commitencoding = ISO\-8859\-1 \&.ft Recently I upgraded my system fr...
Oct 29, 3:16 pm 2008
Jeff King
Re: A typesetting problem with git man pages
I think this is Yet Another docbook or asciidoc issue. The resulting XML from asciidoc is: <literallayout> 
.ft C
 ... the actual example contents ... 
.ft
 </literallayout> which kind of seems wrong to me, since it implies that that is part of the literal layout, and would be subject to quoting. It gets rendered into git-log.1 as: \&.ft C ... the actual examples contents \&.ft so the problem is the extra \&. But ...
Oct 29, 3:39 pm 2008
Jonas Fonseca
Re: A typesetting problem with git man pages
The way I understand it is that the DocBook XSL (stylesheet) doing the conversion from xml to the manpage ensures that possible problematic characters that could break the manpage are escaped. A dot in the start of a line is problematic since it could be interpreted as markup by the manpage viewer and in the mentioned case, the code was not generated by the stylesheet, thus it must be escaped. So IMO, the stylesheet is hardly to blame, the problem is that the asciidoc.conf file defines a macro for ...
Oct 29, 4:14 pm 2008
Jonas Fonseca
Re: A typesetting problem with git man pages
I had a similar problem after upgrading on Ubuntu and came up with a patch to optionally disable some of asciidoc.conf (commit 7f55cf451c9e7). Try putting DOCBOOK_XSL_172=Yes in your config.mak. -- Jonas Fonseca --
Oct 29, 3:35 pm 2008
Teemu Likonen
Re: A typesetting problem with git man pages
Ah, thank you. That fixed it. In case someone is interested there is still a minor flaw that an example command and the following paragraph is printed with no empty line between them. Like in the beginning of "git help tutorial", for example: First, note that you can get documentation for a command such as git log --graph with: $ man git-log It is a good idea to introduce yourself to git [...] It would be nicer if there was empty line after "$ man git-log"...
Oct 29, 6:22 pm 2008
Avery Pennarun
[ANNOUNCE] Gitbuilder 0.2.0 is released
Hi all, I'd like to announce the new v0.2.0 release of gitbuilder, an auto-bisecting autobuilder tool for git-based projects. The new version incorporates several suggestions from end users, including: - a new bar at the top shows the most recent builds and their status - the RSS link is now more obvious - non-fatal warnings now turn your build yellow instead of green - we now count and report warnings, errors, and test failures separately - a new changelog script can email recent changes ...
Oct 29, 2:37 pm 2008
David Symonds
[PATCH] git-diff: Add --staged as a synonym for --cached.
--- Consider this as a replacement to the previous git-staged series. Documentation/git-diff.txt | 1 + builtin-diff.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/git-diff.txt b/Documentation/git-diff.txt index c53eba5..a2f192f 100644 --- a/Documentation/git-diff.txt +++ b/Documentation/git-diff.txt @@ -33,6 +33,7 @@ forced by --no-index. commit relative to the named <commit>. Typically you would want comparison with th...
Oct 29, 12:15 pm 2008
Jeff King
Re: [PATCH] git-diff: Add --staged as a synonym for --cached.
Hmm. I wonder if it would make it more sense to make the "official" name --staged, and leave --cached forever as a synonym. If the goal is giving sane names to end users, then we should probably advertise the sane ones. OTOH, maybe it is better to start slow, let people who are doing I had to investigate this hunk closely, as it really looks at first glance (from the function name, and the fact that there are two hunks, one here and one for cmd_diff) that this is impacting diff-index --cache...
Oct 29, 12:42 pm 2008
David Symonds
Re: [PATCH] git-diff: Add --staged as a synonym for --cached.
I agree. If there's some consensus, I can make that shift, keeping --cached as a backward-compatibility synonym. Dave. --
Oct 29, 12:50 pm 2008
Johannes Schindelin
Re: [PATCH] git-diff: Add --staged as a synonym for --cached.
Hi, Yes, I would like that, too. However, note that we have to hash out what to do about the convention that --cached traditionally means that only the staging area (formerly known as "the index") is affected, while --index means that the command touches the working directory, too. Ciao, Dscho --
Oct 29, 1:06 pm 2008
Jeff King
Re: [PATCH] git-diff: Add --staged as a synonym for --cached.
If we assume that we have only the word "stage" and variations available, then there aren't too many options. only the staging area: --stage-only, --staged-only both: --staged (as opposed to --staged-only) --stage-and-worktree (too long), --both (not descriptive enough), --stage-too (yuck) -Peff --
Oct 29, 1:11 pm 2008
Bill Lear
Using the --track option when creating a branch
We have had a few "crossed stream" problems when developers are working on a local branch and they do an unguarded git push/pull, when they really intended to do git push/pull origin branchname. We use git in a way that makes it desirable for us to only push/pull to the same remote branch. So, if I'm in branch X, I want 'git push' to push to origin/X, and 'git pull' to fetch into origin/X and then merge into X from origin/X. In other words, we want git push/pull to behave in branches other than ...
Oct 29, 11:23 am 2008
Santi Béjar
Re: Using the --track option when creating a branch
branch.autosetupmerge controls if --track is used by default (it is true by default since a long time) It should just work (at least in the lastest releases) when creating a branch from a remote branch. $ git checkout -b X origin/X or $ git branch X origin/X It it just two configs (apart from the remote repository). A help message should appear when using "git pull" without arguments and it cannot figure out the branch to merge: $ # currently in branch next $ git pull You asked me to p...
Oct 29, 12:25 pm 2008
Bill Lear
Re: Using the --track option when creating a branch
Ah, problem solved then. I'll just have everyone upgrade to the latest git. Thanks very much, Santi. Bill --
Oct 29, 4:33 pm 2008
Hannu Koivisto
Re: git bisect view's use of DISPLAY environment variable in...
Unfortunately this approach doesn't seem to work if you run git bisect view from, say, cmd (probably applies to other non-Cygwin shells as well). I'm puzzled as to why this happens; I wrote a simple shell script that echoes $SESSIONNAME and no matter how I run it from cmd it always echoes Console. It's certainly better than nothing and I wouldn't mind it ending up to the official git but... -- Hannu --
Oct 29, 9:31 am 2008
Alex Riesen
[PATCH] Use find instead of perl in t5000 to get file modifi...
The test "validate file modification time" was broken on admittedly broken combination of Windows, Cygwin, and ActiveState Perl. Something (I blame ActiveState) of the three is very confused about what time zone to use for the modification time. Signed-off-by: Alex Riesen <raa.lkml@gmail.com> --- I could not find what exactly does the ActiveState's Perl use for its stat implementation (and honestly, have no motivation to look harder). It seems to honor TZ, but the produced time does not se...
Oct 29, 6:38 am 2008
Jeff King
Re: [PATCH] Use find instead of perl in t5000 to get file mo...
$ uname -sr FreeBSD 6.1-RELEASE-p17-jc1 $ find . -printf "%T@\\n" I think that makes the most sense. -Peff --
Oct 29, 5:54 pm 2008
previous daytodaynext day
October 28, 2008October 29, 2008October 30, 2008