Re: Pull request for sub-tree merge into /contrib/gitstats

Previous thread: [PATCH 9/9] pack-objects: don't leak pack window reference when splitting packs by Nicolas Pitre on Wednesday, October 29, 2008 - 7:02 pm. (1 message)

Next thread: [PATCH] git-filter-branch: Add an example on how to remove empty commits by Petr Baudis on Wednesday, October 29, 2008 - 8:33 pm. (25 messages)
To: Junio C Hamano <gitster@...>, Git Mailinglist <git@...>
Date: Wednesday, October 29, 2008 - 7:06 pm

My work is available in the git repository at:

git://repo.or.cz/git-stats.git master

Please use a subtree merge to put this in contrib/gitstats.

David Symonds (2):
Insert the git_stats path to the start of os.sys.path, not 1 element in.
Fix some spelling mistakes.

Sverre Rabbelier (237):
Created a script to setup a repo to test metrics on.
Converted the setupRepo script to python to allow creating the same repo.
Added the use cases in text form.
Added a README.
Initial commit for notes branch
Changelog for 28-05-2008
Changelog for 29-05-2008
Changelog for 30-05-2008
Changelog for 31-05-2008
Created a script that aggregates author activity in one part of
the content.
Updated the script to handle merges and to treat '-' as 0.
Modified author.activityInArea to take a list of strings instead
of a file.
Added a module containing the wrappers for the commands.
Replaced funny characters in use-cases.txt with whitespace.
Created a script that handles index related activities.
Added a script to handle data mining related to commit history.
Created a 'touched' command in the wrapper module.
Added pathsTouched to the history module.
Created a commitTouched function and a prettyPrint helper function
Wrapped the use-cases.txt document at ~72 characters.
Created a list of metrics that can be used to indentify fixes.
Added three more data mining functions to the history module
Gave the setupRepo script some major TLC.
Added commitdiffEqual functionality to the history module.
Creating the repository in a temp directory, use tempfile.gettempdir().
Improved the metrics documentation.
Use 'os.path.join(a, b)' rather than 'a + os.sep + b'.
Removed try/except from setupRepo but added a manual raise
Use the same configurations as test-lib.sh in setupRepo
Copied the test-lib.sh script from git.git/t...

To: Junio C Hamano <gitster@...>, Git Mailinglist <git@...>
Date: Wednesday, October 29, 2008 - 8:38 pm

Which has the "gitstats:" prefix to all commit messages, and does not
have the changelog file.

--
Cheers,

Sverre Rabbelier
--

To: <sverre@...>
Cc: Junio C Hamano <gitster@...>, Git Mailinglist <git@...>
Date: Wednesday, October 29, 2008 - 7:31 pm

[...]

?

If those are not significant enough to have a proper description, then
I'd suggest you use 'git rebase -i' and its "squash" command to fold
them into the appropriate commit.

Nicolas
--

To: Nicolas Pitre <nico@...>
Cc: Junio C Hamano <gitster@...>, Git Mailinglist <git@...>
Date: Wednesday, October 29, 2008 - 7:38 pm

They are there because the work was done incrementally, having them as
seperate commits shows when the changelog was modified. Having a
description for a change to the changelog is pretty senseless, since
it would be the same text as what is in the diff.

That said, sure, I can squash those commits no problem.

--
Cheers,

Sverre Rabbelier
--

To: <sverre@...>
Cc: Junio C Hamano <gitster@...>, Git Mailinglist <git@...>
Date: Wednesday, October 29, 2008 - 7:12 pm

...

How is this going to look in the "What's in git.git" email?
We don't use ChangeLog files in git.git and we don't have
notes branches, and we already have a README.

Most stuff in contrib/ has its commit messages with a prefix string
to make it more clear when looking at the shortlog what is being
impacted. Maybe this should be re-written with filter-branch to
include a prefix before it merges.

--
Shawn.
--

To: Shawn O. Pearce <spearce@...>
Cc: Junio C Hamano <gitster@...>, Git Mailinglist <git@...>
Date: Wednesday, October 29, 2008 - 7:39 pm

Sure, I'm fine with rewriting all commit messages to have a "gitstats:" prefix.

--
Cheers,

Sverre Rabbelier
--

Previous thread: [PATCH 9/9] pack-objects: don't leak pack window reference when splitting packs by Nicolas Pitre on Wednesday, October 29, 2008 - 7:02 pm. (1 message)

Next thread: [PATCH] git-filter-branch: Add an example on how to remove empty commits by Petr Baudis on Wednesday, October 29, 2008 - 8:33 pm. (25 messages)