Home » Mailing list archives » git » 2008 » October » 29

[PATCH] Use find instead of perl in t5000 to get file modification time

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Alex Riesen <raa.lkml@...>
To: Git Mailing List <git@...>
Cc: Junio C Hamano <gitster@...>, Jeff King <peff@...>, René Scharfe <rene.scharfe@...>
Subject: [PATCH] Use find instead of perl in t5000 to get file modification time
Date: Wednesday, October 29, 2008 - 6:38 am

The test "validate file modification time" was broken on admittedly broken
combination of Windows, Cygwin, and ActiveState Perl. Something (I blame
ActiveState) of the three is very confused about what time zone
to use for the modification time.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---

I could not find what exactly does the ActiveState's Perl use for its stat
implementation (and honestly, have no motivation to look harder).
It seems to honor TZ, but the produced time does not seem to be either
local or GMT.

There can be a problem with "-printf": Open Group SUS does not specify
-printf for find(1), so it is probably a problem somewhere. I just don't know.

There is always a fallback, which is to write a small program which calls
native stat(2). Or modify test-chmtime to just print mtime when asked.

 t/t5000-tar-tree.sh |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Use find instead of perl in t5000 to get file modifi..., Alex Riesen, (Wed Oct 29, 6:38 am)
Re: [PATCH] Use find instead of perl in t5000 to get file mo..., Sam Vilain, (Thu Oct 30, 1:29 am)
Re: [PATCH] Use find instead of perl in t5000 to get file mo..., Alex Riesen, (Fri Oct 31, 3:00 am)
Re: [PATCH] Use find instead of perl in t5000 to get file mo..., Johannes Schindelin, (Fri Oct 31, 6:14 pm)
Re: [PATCH] Use find instead of perl in t5000 to get file mo..., Alex Riesen, (Fri Oct 31, 7:37 pm)
Re: [PATCH] Use find instead of perl in t5000 to get file mo..., Johannes Schindelin, (Fri Oct 31, 8:23 pm)
Re: [PATCH] Use find instead of perl in t5000 to get file mo..., Alex Riesen, (Sat Nov 1, 10:24 am)
Re: [PATCH] Use find instead of perl in t5000 to get file mo..., Johannes Schindelin, (Sat Nov 1, 4:37 pm)
Re: [PATCH] Use find instead of perl in t5000 to get file mo..., Alex Riesen, (Sun Nov 2, 10:37 am)
Re: [PATCH] Use find instead of perl in t5000 to get file mo..., Johannes Schindelin, (Sun Nov 2, 12:05 pm)
Re: [PATCH] Use find instead of perl in t5000 to get file mo..., Peter Harris, (Fri Oct 31, 8:59 am)
Re: [PATCH] Use find instead of perl in t5000 to get file mo..., Alex Riesen, (Fri Oct 31, 9:45 am)
Re: [PATCH] Use find instead of perl in t5000 to get file mo..., Jeff King, (Wed Oct 29, 5:54 pm)
Re: [PATCH] Use find instead of perl in t5000 to get file mo..., Alex Riesen, (Thu Oct 30, 3:26 am)