[PATCHv4] gitweb: use_pathinfo filenames start with /

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Giuseppe Bilotta
Date: Wednesday, October 1, 2008 - 5:10 pm

When using path info, make filenames start with a / (right after the :
that separates them from the hash base). This minimal change allows
relative navigation to work properly when viewing HTML files.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---
 gitweb/gitweb.perl |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 2c380ac..3e5b2b7 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -690,7 +690,7 @@ sub href (%) {
 		# try to put as many parameters as possible in PATH_INFO:
 		#   - project name
 		#   - action
-		#   - hash or hash_base:filename
+		#   - hash or hash_base:/filename
 
 		# Strip any trailing / from $href, or we might get double
 		# slashes when the script is the DirectoryIndex
@@ -708,11 +708,11 @@ sub href (%) {
 			delete $params{'action'};
 		}
 
-		# Finally, we put either hash_base:file_name or hash
+		# Finally, we put either hash_base:/file_name or hash
 		if (defined $params{'hash_base'}) {
 			$href .= "/".esc_url($params{'hash_base'});
 			if (defined $params{'file_name'}) {
-				$href .= ":".esc_url($params{'file_name'});
+				$href .= ":/".esc_url($params{'file_name'});
 				delete $params{'file_name'};
 			}
 			delete $params{'hash'};
-- 
1.5.6.5

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCHv4] gitweb: PATH_INFO support improvements, Giuseppe Bilotta, (Wed Oct 1, 5:10 pm)
[PATCHv4] gitweb: refactor input parameters parse/validation, Giuseppe Bilotta, (Wed Oct 1, 5:10 pm)
[PATCHv4] gitweb: generate project/action/hash URLs, Giuseppe Bilotta, (Wed Oct 1, 5:10 pm)
[PATCHv4] gitweb: use_pathinfo filenames start with /, Giuseppe Bilotta, (Wed Oct 1, 5:10 pm)
[PATCHv4] gitweb: parse parent..current syntax from pathinfo, Giuseppe Bilotta, (Wed Oct 1, 5:10 pm)
[PATCHv4] gitweb: generate parent..current URLs, Giuseppe Bilotta, (Wed Oct 1, 5:10 pm)
Re: [PATCHv4] gitweb: PATH_INFO support improvements, Jakub Narebski, (Thu Oct 2, 1:19 am)
Re: [PATCHv4] gitweb: PATH_INFO support improvements, Giuseppe Bilotta, (Thu Oct 2, 1:49 am)
Re: [PATCHv4] gitweb: PATH_INFO support improvements, Jakub Narebski, (Thu Oct 2, 3:16 am)
Re: [PATCHv4] gitweb: generate project/action/hash URLs, Jakub Narebski, (Thu Oct 2, 6:48 pm)
Re: [PATCHv4] gitweb: use_pathinfo filenames start with /, Jakub Narebski, (Fri Oct 3, 4:28 am)
Re: [PATCHv4] gitweb: generate project/action/hash URLs, Jakub Narebski, (Fri Oct 3, 6:15 pm)
Re: [PATCHv4] gitweb: generate parent..current URLs, Jakub Narebski, (Sun Oct 5, 5:17 pm)