Home » Mailing list archives » git » 2008 » January » 9

[RFC] refer to post-patch lines in whitespace warnings

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Daniel Barkalow <barkalow@...>
To: <git@...>
Subject: [RFC] refer to post-patch lines in whitespace warnings
Date: Wednesday, January 9, 2008 - 11:57 am

When I rebase series with bad whitespace, I end up with unhelpful messages 
like:

.dotest/patch:412: trailing whitespace.
-- 
.dotest/patch:446: trailing whitespace.
-- 

These line numbers obviously refer to lines in a file that's been removed 
by the time I can do anything about it. It seems to me like the message 
would be more useful if, in the case where it leaves the working tree 
modified with the non-compliant whitespace, it gave this location rather 
than the patch's location (because, even if you have the patch still, 
you'd need to revert it first in order to be able to apply a fixed version 
anyway). Anybody see any problems with this theory?

	-Daniel
*This .sig left intentionally blank*
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[RFC] refer to post-patch lines in whitespace warnings, Daniel Barkalow, (Wed Jan 9, 11:57 am)
Re: [RFC] refer to post-patch lines in whitespace warnings, Junio C Hamano, (Wed Jan 9, 4:42 pm)
Re: [RFC] refer to post-patch lines in whitespace warnings, Junio C Hamano, (Wed Jan 9, 4:22 pm)
Re: [RFC] refer to post-patch lines in whitespace warnings, Daniel Barkalow, (Wed Jan 9, 5:35 pm)