Hi,

On Wed, 9 Jan 2008, Charles Bailey wrote:

quoted text
> On Wed, Jan 09, 2008 at 01:40:46PM +0000, Johannes Schindelin wrote:
> 
> > On Wed, 9 Jan 2008, Charles Bailey wrote:
> > 
> > > --- snip ---
> > 
> > Since gitk and git-gui are separate projects (pulled at irregular 
> > intervals into git.git), your patch looks sane, but would be better 
> > done as a patch against gitk.git.
> 
> I'm sorry, I think I knew this once, but had forgotten.

Oh, my critique was not meant as harsh as it was apparently received: for 
reviewing purposes, your way was perfect, as it shows your intent better 
than the technically correct patch.

All I'm saying is that you should send the (verbose) patch, too, possibly 
referring to the smaller patch in the space between the three dashes and 
the diffstat.

(I would also prefix this patch with "gitk:", instead of writing "of 
gitk", so that people reading the log of git.git get a better idea what 
this is about.)

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html