login
Header Space

 
 

[PATCH] Fix off by one error in prep_exclude.

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <git@...>
Cc: <j.sixt@...>, <Johannes.Schindelin@...>, <gitster@...>, Shawn Bohrer <shawn.bohrer@...>
Date: Sunday, January 27, 2008 - 3:55 pm

base + current already includes the trailing slash so adding
one removes the first character of the next directory.

Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
---

This fixes the oops part of the issue Johannes found, but doesn't
address the fact that we probably should remove files that aren't
a part of the repository at in the first place.

 dir.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dir.c b/dir.c
index 3e345c2..9e5879a 100644
--- a/dir.c
+++ b/dir.c
@@ -237,7 +237,7 @@ static void prep_exclude(struct dir_struct *dir, const char *base, int baselen)
 			current = 0;
 		}
 		else {
-			cp = strchr(base + current + 1, '/');
+			cp = strchr(base + current, '/');
 			if (!cp)
 				die("oops in prep_exclude");
 			cp++;
-- 
1.5.4-rc2.GIT

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
git-clean buglet, Johannes Sixt, (Wed Jan 23, 11:14 am)
Re: git-clean buglet, Johannes Schindelin, (Wed Jan 23, 11:29 am)
Re: git-clean buglet, Johannes Sixt, (Wed Jan 23, 11:40 am)
[PATCH] Fix off by one error in prep_exclude., Shawn Bohrer, (Sun Jan 27, 3:55 pm)
Re: [PATCH] Fix off by one error in prep_exclude., Johannes Schindelin, (Sun Jan 27, 4:44 pm)
Re: [PATCH] Fix off by one error in prep_exclude., Junio C Hamano, (Sun Jan 27, 6:34 pm)
Re: [PATCH] Fix off by one error in prep_exclude., Shawn Bohrer, (Sun Jan 27, 8:34 pm)
Re: [PATCH] Fix off by one error in prep_exclude., Junio C Hamano, (Sun Jan 27, 10:52 pm)
Re: [PATCH] Fix off by one error in prep_exclude., Johannes Sixt, (Mon Jan 28, 3:12 am)
Re: [PATCH] Fix off by one error in prep_exclude., Junio C Hamano, (Mon Jan 28, 4:46 am)
Re: [PATCH] Fix off by one error in prep_exclude., Johannes Sixt, (Mon Jan 28, 5:05 am)
[RFH/PATCH] prefix_path(): disallow absolute paths, Johannes Schindelin, (Mon Jan 28, 8:33 am)
Re: [RFH/PATCH] prefix_path(): disallow absolute paths, Junio C Hamano, (Mon Jan 28, 9:23 pm)
Re: [RFH/PATCH] prefix_path(): disallow absolute paths, しらいしななこ, (Tue Jan 29, 5:53 pm)
Re: [RFH/PATCH] prefix_path(): disallow absolute paths, Junio C Hamano, (Tue Jan 29, 8:43 pm)
Re: [RFH/PATCH] prefix_path(): disallow absolute paths, Johannes Sixt, (Tue Jan 29, 3:20 am)
Re: [RFH/PATCH] prefix_path(): disallow absolute paths, Junio C Hamano, (Tue Jan 29, 3:28 am)
Re: [RFH/PATCH] prefix_path(): disallow absolute paths, Johannes Sixt, (Tue Jan 29, 3:43 am)
Re: [RFH/PATCH] prefix_path(): disallow absolute paths, Junio C Hamano, (Tue Jan 29, 4:31 am)
Re: [RFH/PATCH] prefix_path(): disallow absolute paths, Johannes Schindelin, (Mon Jan 28, 10:37 pm)
Re: [RFH/PATCH] prefix_path(): disallow absolute paths, Junio C Hamano, (Mon Jan 28, 10:45 pm)
Re: [RFH/PATCH] prefix_path(): disallow absolute paths, Johannes Schindelin, (Mon Jan 28, 10:59 pm)
Re: [RFH/PATCH] prefix_path(): disallow absolute paths, Junio C Hamano, (Mon Jan 28, 10:03 pm)
Re: [RFH/PATCH] prefix_path(): disallow absolute paths, Junio C Hamano, (Tue Jan 29, 3:02 am)
[PATCH] More test cases for sanitized path names, Robin Rosenberg, (Fri Feb 1, 12:34 am)
Re: [PATCH] More test cases for sanitized path names, Junio C Hamano, (Fri Feb 1, 3:17 am)
[PATCH for post 1.5.4] Sane use of test_expect_failure, Junio C Hamano, (Fri Feb 1, 5:50 am)
Re: [PATCH] Sane use of test_expect_failure, Junio C Hamano, (Sat Feb 2, 6:06 am)
Re: [PATCH] More test cases for sanitized path names, Robin Rosenberg, (Fri Feb 1, 5:10 am)
Re: [PATCH] More test cases for sanitized path names, Junio C Hamano, (Fri Feb 1, 6:22 am)
Re: [PATCH] More test cases for sanitized path names, Robin Rosenberg, (Fri Feb 1, 10:17 am)
Re: [PATCH] More test cases for sanitized path names, Junio C Hamano, (Fri Feb 1, 1:45 pm)
Re: [PATCH] More test cases for sanitized path names, Junio C Hamano, (Fri Feb 1, 6:51 am)
Re: [PATCH] More test cases for sanitized path names, Junio C Hamano, (Fri Feb 1, 7:10 am)
[PATCH] Make blame accept absolute paths, Robin Rosenberg, (Fri Feb 1, 12:07 am)
Re: [RFH/PATCH] prefix_path(): disallow absolute paths, Junio C Hamano, (Mon Jan 28, 10:03 pm)
[PATCH] prefix_path(): disallow absolute paths, Johannes Schindelin, (Mon Jan 28, 11:05 am)
Re: [PATCH] Fix off by one error in prep_exclude., Junio C Hamano, (Mon Jan 28, 5:22 am)
[PATCH] Fix off by one error in prep_exclude., Shawn Bohrer, (Sun Jan 27, 8:37 pm)
Re: [PATCH] Fix off by one error in prep_exclude., Johannes Schindelin, (Mon Jan 28, 7:59 am)
Re: [PATCH] Fix off by one error in prep_exclude., Junio C Hamano, (Mon Jan 28, 8:04 am)
Re: [PATCH] Fix off by one error in prep_exclude., Shawn Bohrer, (Sun Jan 27, 5:15 pm)
Re: git-clean buglet, Johannes Sixt, (Wed Jan 23, 11:24 am)
speck-geostationary