Home » Mailing list archives » git » 2008 » January » 20

Re: [PATCH] git-fsck: report missing author/commit line in a commit as an error

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Johannes Schindelin <Johannes.Schindelin@...>
To: Martin Koegler <mkoegler@...>
Cc: Junio C Hamano <gitster@...>, <git@...>
Subject: Re: [PATCH] git-fsck: report missing author/commit line in a commit as an error
Date: Sunday, January 20, 2008 - 3:20 pm

Hi,

On Sun, 20 Jan 2008, Martin Koegler wrote:


s/commiter/committer/

It makes me wonder, though, if that's correct.  AFAICT it is the committer 
date, and the rest of the line _might_ be just fine.

Why not be less intrusive and just change the printf() into a return 
objerror(), like the commit message suggests?

Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] git-fsck: report missing author/commit line in a com..., Martin Koegler, (Sun Jan 20, 2:59 pm)
Re: [PATCH] git-fsck: report missing author/commit line in a..., Johannes Schindelin, (Sun Jan 20, 3:20 pm)
Re: [PATCH] git-fsck: report missing author/commit line in a..., Martin Koegler, (Mon Jan 21, 3:00 am)