Home » Mailing list archives » git » 2008 » January » 18

fast-import.c: zlib_compression_level vs pack_compression_level

Previous thread: git-svn should default to --repack by Kevin Ballard on Friday, January 18, 2008 - 8:17 am. (30 messages)

Next thread: [PATCH] git-commit: add a prepare-commit-msg hook by Paolo Bonzini on Friday, January 18, 2008 - 10:51 am. (16 messages)
[view original message]
From: Marco Costalba <mcostalba@...>
To: Junio C Hamano <gitster@...>
Cc: Git Mailing List <git@...>
Subject: fast-import.c: zlib_compression_level vs pack_compression_level
Date: Friday, January 18, 2008 - 9:04 am

Just a small thing I would like to bring to your attention before 1.5.4 is out


During my work on compression/decompression cleanup I have found that

in fast-import.c the zlib_compression_level is used, while in

builtin-pack-objects is used pack_compression_level instead.


This 2 flags corresponds, more or less directly, (some cleanup is

needed also in that area, but this is another story) to:


core.loosecompression


and


pack.compression


config settings.


My question is, does fast-import should use pack.compression instead

of core.loosecompression?


Thanks

Marco

-
[view original message]
From: Nicolas Pitre <nico@...>
To: Marco Costalba <mcostalba@...>
Cc: Junio C Hamano <gitster@...>, Git Mailing List <git@...>
Subject: Re: fast-import.c: zlib_compression_level vs pack_compression_level
Date: Friday, January 18, 2008 - 11:44 am

Yes it should.


Nicolas

-
[view original message]
From: Marco Costalba <mcostalba@...>
To: Nicolas Pitre <nico@...>
Cc: Junio C Hamano <gitster@...>, Git Mailing List <git@...>
Subject: Re: fast-import.c: zlib_compression_level vs pack_compression_level
Date: Saturday, January 19, 2008 - 4:47 am

I have a patch on top of my comrpession cleanup series, if people

agree I would leave this as is now. It's really not a biggie and 1.5.4

_seems_ very near.


Marco

-
Previous thread: git-svn should default to --repack by Kevin Ballard on Friday, January 18, 2008 - 8:17 am. (30 messages)

Next thread: [PATCH] git-commit: add a prepare-commit-msg hook by Paolo Bonzini on Friday, January 18, 2008 - 10:51 am. (16 messages)