login
Header Space

 
 

Re: [PATCH] http-push: fix double free()

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Johannes Schindelin <Johannes.Schindelin@...>
Cc: <git@...>, <gitster@...>, <nigel.magnay@...>
Date: Friday, January 18, 2008 - 2:34 am

On Thu, Jan 17, 2008 at 07:45:11PM +0000, Johannes Schindelin wrote:

Mmmmmm the free(url) you remove has been added in 3a462bc9 and the
free(url) in the if clauses before have been removed in the same commit.
I fail to see how that could lead to a double free().

Actually, I do see how, because git show 64be904 displays an obviously
wrong remote_exists. OTOH, neither next, master nor pu have such code...

Mike
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] http-push: fix double free(), Johannes Schindelin, (Thu Jan 17, 3:45 pm)
Re: [PATCH] http-push: fix double free(), Mike Hommey, (Fri Jan 18, 2:34 am)
Re: [PATCH] http-push: fix double free(), Johannes Schindelin, (Fri Jan 18, 10:54 am)
Re: [PATCH] http-push: fix double free(), Johannes Schindelin, (Fri Jan 18, 8:14 am)
speck-geostationary