Re: [PATCH v2] Do not show "diff --git" metainfo with --no-prefix

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Johannes Schindelin <Johannes.Schindelin@...>

Cc: Junio C Hamano <gitster@...>, Daniel Barkalow <barkalow@...>, Linus Torvalds <torvalds@...>, Chris Ortman <chrisortman@...>, <git@...>

Subject: Re: [PATCH v2] Do not show "diff --git" metainfo with --no-prefix

Date: Thursday, January 17, 2008 - 10:49 am

On Thu, Jan 17, 2008 at 01:48:54AM +0000, Johannes Schindelin wrote:

quoted text> > While we are discussing about diff, there is one thing that has been 
> > bugging me occasionally, but the annoyance factor has not motivated me 
> > enough to look into it myself, because I do not use it often: 
> > --color-words.  It appears that it shows lines that do not have any word 
> > differences in bold (whatever diff.color.meta is configured) and I think 
> > it should use plain color instead.
> > 
> > Was this intentional, or just a simple plain bug?
> 
> Plain bug.  I even meant to implement your suggestion of having a variable 
> set of non-word characters, but never came around to work on it.  

Hmm. I happen to set my "meta" color to something a little less
attention-grabbing (magenta), and I find the alternate coloring to be a
nice visual indicator of "nothing happened on this line". I can see how
bold would be very distracting, though. Perhaps there should be a
color.diff.unimportant?

-Peff
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[FEATURE REQUEST] git-svn format-patch, Chris Ortman, (Tue Jan 15, 9:59 am)

Re: [FEATURE REQUEST] git-svn format-patch, Jean-Luc Herren, (Tue Jan 15, 4:14 pm)

Re: [FEATURE REQUEST] git-svn format-patch, Chris Ortman, (Tue Jan 15, 4:30 pm)

Re: [FEATURE REQUEST] git-svn format-patch, Daniel Barkalow, (Tue Jan 15, 10:20 pm)

Re: [FEATURE REQUEST] git-svn format-patch, Nigel Magnay, (Tue Mar 11, 1:38 pm)

Re: [FEATURE REQUEST] git-svn format-patch, Daniel Barkalow, (Wed Mar 12, 12:38 am)

Re: [FEATURE REQUEST] git-svn format-patch, Jan Hudec, (Tue Mar 11, 3:22 pm)

Re: [FEATURE REQUEST] git-svn format-patch, Johannes Schindelin, (Tue Jan 15, 10:45 am)

Re: [FEATURE REQUEST] git-svn format-patch, Chris Ortman, (Tue Jan 15, 11:58 am)

Re: [FEATURE REQUEST] git-svn format-patch, Daniel Barkalow, (Tue Jan 15, 7:11 pm)

Re: [FEATURE REQUEST] git-svn format-patch, Chris Ortman, (Tue Jan 15, 10:01 pm)

Re: [FEATURE REQUEST] git-svn format-patch, Junio C Hamano, (Tue Jan 15, 8:19 pm)

[PATCH/RFC] Do not show "diff --git" metainfo with --no-prefix, Junio C Hamano, (Tue Jan 15, 8:58 pm)

[PATCH v2] Do not show "diff --git" metainfo with --no-prefix, Junio C Hamano, (Tue Jan 15, 10:08 pm)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Linus Torvalds, (Tue Jan 15, 11:09 pm)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Junio C Hamano, (Wed Jan 16, 12:18 am)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Daniel Barkalow, (Tue Jan 15, 11:56 pm)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Jan Hudec, (Sat Jan 19, 5:36 am)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Linus Torvalds, (Tue Jan 15, 11:26 pm)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Junio C Hamano, (Wed Jan 16, 1:22 pm)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Daniel Barkalow, (Wed Jan 16, 12:04 am)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Linus Torvalds, (Wed Jan 16, 12:22 am)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Junio C Hamano, (Wed Jan 16, 4:19 pm)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Junio C Hamano, (Fri Jan 18, 4:22 am)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Daniel Barkalow, (Wed Jan 16, 4:39 pm)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Junio C Hamano, (Wed Jan 16, 8:57 pm)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Johannes Schindelin, (Wed Jan 16, 9:11 pm)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Junio C Hamano, (Wed Jan 16, 9:34 pm)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Johannes Schindelin, (Wed Jan 16, 9:48 pm)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Jeff King, (Thu Jan 17, 10:49 am)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Jeff King, (Thu Jan 17, 11:03 am)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Johannes Schindelin, (Thu Jan 17, 11:12 am)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Jeff King, (Thu Jan 17, 11:18 am)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Junio C Hamano, (Wed Jan 16, 10:42 pm)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Johannes Schindelin, (Wed Jan 16, 10:45 pm)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Junio C Hamano, (Wed Jan 16, 9:19 pm)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Johannes Schindelin, (Wed Jan 16, 9:54 pm)

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Junio C Hamano, (Wed Jan 16, 10:28 pm)

Re: [PATCH/RFC] Do not show "diff --git" metainfo with --no-..., Johannes Schindelin, (Tue Jan 15, 9:37 pm)

Re: [PATCH/RFC] Do not show "diff --git" metainfo with --no-..., Junio C Hamano, (Tue Jan 15, 9:46 pm)

Re: [PATCH/RFC] Do not show "diff --git" metainfo with --no-..., Johannes Schindelin, (Tue Jan 15, 9:53 pm)

Re: [PATCH/RFC] Do not show "diff --git" metainfo with --no-..., Daniel Barkalow, (Tue Jan 15, 10:04 pm)

Re: [PATCH/RFC] Do not show "diff --git" metainfo with --no-..., Junio C Hamano, (Tue Jan 15, 10:15 pm)

Re: [FEATURE REQUEST] git-svn format-patch, Pascal Obry, (Tue Jan 15, 1:10 pm)

Re: [FEATURE REQUEST] git-svn format-patch, Johannes Schindelin, (Tue Jan 15, 12:13 pm)

Re: [FEATURE REQUEST] git-svn format-patch, Chris Ortman, (Tue Jan 15, 12:23 pm)

Re: [FEATURE REQUEST] git-svn format-patch, Johannes Schindelin, (Tue Jan 15, 12:52 pm)

Re: [FEATURE REQUEST] git-svn format-patch, Chris Ortman, (Tue Jan 15, 1:07 pm)

Re: [FEATURE REQUEST] git-svn format-patch, Johannes Schindelin, (Tue Jan 15, 1:11 pm)

Re: [FEATURE REQUEST] git-svn format-patch, Chris Ortman, (Tue Jan 15, 3:04 pm)

Re: [FEATURE REQUEST] git-svn format-patch, Jan Hudec, (Tue Jan 15, 4:15 pm)

Re: [FEATURE REQUEST] git-svn format-patch, Miles Bader, (Wed Jan 16, 2:41 am)

Re: [FEATURE REQUEST] git-svn format-patch, Shawn O. Pearce, (Wed Jan 16, 2:54 am)

Navigation

Popular discussions


linux-kernel:
Tony Lindgren	[PATCH 26/90] ARM: OMAP: abstract debug card setup (smc, leds)
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Vladislav Bolkhovitin	Re: Integration of SCST in the mainstream Linux kernel
Jesper Juhl	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
git:

linux-netdev:
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Frans Pop	svc: failed to register lockdv1 RPC service (errno 97).
openbsd-misc:

Colocation donated by:

Online users

zeekec

Syndicate