Home » Mailing list archives » git » 2008 » January » 17

[BUG] git send-email brakes patches with very long lines

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Adam Piatyszek <ediap@...>
To: <git-owner@...>
Cc: <gitster@...>, Ryan Anderson <ryan@...>
Subject: [BUG] git send-email brakes patches with very long lines
Date: Thursday, January 17, 2008 - 6:10 am

Hi Giters,

I suspect that "git send-email" has problems with sending patches with 
very long lines.

Please find the attached two emails, which show this problem. The 
original file (0001-Add-Dolph-Chebyshev-window.patch) was produced with 
"git format-patch" from one of my private Git repositories. The other 
file (0001-Add-Dolph-Chebyshev-window-sent.patch) includes the same 
patch but sent with "git send-email". The problem is with the last hunk, 
which is somehow broken by the "git send-email" tool. The very long 
lines are wrapped and some exclamation marks are inserted.

The result of applying such a broken patch in my repository is as follows:

===== >8 =====
ediap@lespaul ~/git/itpp $ git am 0001-Add-Dolph-Chebyshev-window-sent.patch
Applying Add Dolph Chebyshev window.
fatal: corrupt patch at line 126
Patch failed at 0001.
When you have resolved this problem run "git-am --resolved".
If you would prefer to skip this patch, instead run "git-am --skip".
===== >8 =====

If I send the same patch with mutt inlined or attached, the patch is not 
broken and applies cleanly.

This problem was observed for the following git versions:
- 1.5.3.8
- 1.5.4.rc3.4.g1633

BR,
/Adam


PS. Email and IP addresses have been removed from the attached patches.

-- 
.:.  Adam Piatyszek (ediap)  .:.....................................:.
.:.  ediap@users.sourceforge.net  .:................................:.
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[BUG] git send-email brakes patches with very long lines, Adam Piatyszek, (Thu Jan 17, 6:10 am)
Re: [BUG] git send-email brakes patches with very long lines, Adam Piatyszek, (Thu Jan 17, 9:13 am)
Re: [BUG] git send-email brakes patches with very long lines, Adam Piatyszek, (Thu Jan 17, 9:26 am)
Re: [BUG] git send-email brakes patches with very long lines, Jeff King, (Thu Jan 17, 11:32 am)
[PATCH] git-send-email.perl: check for lines longer than 998..., Adam Piątyszek, (Fri Jan 18, 3:47 am)
Re: [PATCH] git-send-email.perl: check for lines longer than..., Johannes Sixt, (Fri Jan 18, 4:12 am)
Re: [PATCH] git-send-email.perl: check for lines longer than..., Adam Piatyszek, (Fri Jan 18, 5:42 am)
Re: [PATCH] git-send-email.perl: check for lines longer than..., Johannes Sixt, (Fri Jan 18, 6:01 am)
Re: [PATCH] git-send-email.perl: check for lines longer than..., Junio C Hamano, (Fri Jan 18, 6:08 am)
Re: [PATCH] git-send-email.perl: check for lines longer than..., Jeff King, (Fri Jan 18, 10:16 am)
[PATCH 3/3] send-email: add no-validate option, Jeff King, (Fri Jan 18, 10:20 am)
[PATCH 2/3] send-email: validate patches before sending anyt..., Jeff King, (Fri Jan 18, 10:19 am)
Re: [PATCH 2/3] send-email: validate patches before sending ..., Jay Soffian, (Fri Jan 18, 1:39 pm)
Re: [PATCH 2/3] send-email: validate patches before sending ..., Jeff King, (Fri Jan 18, 3:12 pm)
Re: [PATCH 2/3] send-email: validate patches before sending ..., Johannes Sixt, (Fri Jan 18, 11:09 am)
Re: [PATCH 2/3] send-email: validate patches before sending ..., Jeff King, (Fri Jan 18, 3:09 pm)
[PATCH 1/3] send-email: detect invocation errors earlier, Jeff King, (Fri Jan 18, 10:19 am)
Re: [PATCH] git-send-email.perl: check for lines longer than..., Adam Piatyszek, (Fri Jan 18, 6:37 am)
Re: [PATCH] git-send-email.perl: check for lines longer than..., Junio C Hamano, (Fri Jan 18, 7:01 am)