login
Header Space

 
 

Re: [PATCH v2] Do not show "diff --git" metainfo with --no-prefix

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Linus Torvalds <torvalds@...>
Cc: Daniel Barkalow <barkalow@...>, Chris Ortman <chrisortman@...>, Johannes Schindelin <Johannes.Schindelin@...>, <git@...>
Date: Wednesday, January 16, 2008 - 12:18 am

Linus Torvalds <torvalds@linux-foundation.org> writes:


Although the discussion was triggered by that Tortoise thing,
the RFC patch was not about helping that.  That's a new feature
asked long after we went into rc freeze, and I am not interested
in discussing such a feature, especially when I am sick.

The only objective was to make sure that a patch that is not
kosher in git-apply's eyes is not marked with "diff --git";
otherwise, its output will confuse git-apply.  As --no-prefix
will be a new feature in 1.5.4, we would be shipping with a
known-to-be-bad new feature that is --no-prefix, unless we do
something about it.  Fixing that breakage was the sole
motivation behind my patch.

I think a reasonable short-term solution might be to disable any
git specific stuff (renames, rewrites, etc) when --no-prefix and
its friends are used, along with the patch you are commenting on
to remove " --git" from the header.  That would at least make
sure that the --no-prefix feature is safe.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[FEATURE REQUEST] git-svn format-patch, Chris Ortman, (Tue Jan 15, 9:59 am)
Re: [FEATURE REQUEST] git-svn format-patch, Jean-Luc Herren, (Tue Jan 15, 4:14 pm)
Re: [FEATURE REQUEST] git-svn format-patch, Chris Ortman, (Tue Jan 15, 4:30 pm)
Re: [FEATURE REQUEST] git-svn format-patch, Daniel Barkalow, (Tue Jan 15, 10:20 pm)
Re: [FEATURE REQUEST] git-svn format-patch, Nigel Magnay, (Tue Mar 11, 1:38 pm)
Re: [FEATURE REQUEST] git-svn format-patch, Daniel Barkalow, (Wed Mar 12, 12:38 am)
Re: [FEATURE REQUEST] git-svn format-patch, Jan Hudec, (Tue Mar 11, 3:22 pm)
Re: [FEATURE REQUEST] git-svn format-patch, Johannes Schindelin, (Tue Jan 15, 10:45 am)
Re: [FEATURE REQUEST] git-svn format-patch, Chris Ortman, (Tue Jan 15, 11:58 am)
Re: [FEATURE REQUEST] git-svn format-patch, Daniel Barkalow, (Tue Jan 15, 7:11 pm)
Re: [FEATURE REQUEST] git-svn format-patch, Chris Ortman, (Tue Jan 15, 10:01 pm)
Re: [FEATURE REQUEST] git-svn format-patch, Junio C Hamano, (Tue Jan 15, 8:19 pm)
Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Junio C Hamano, (Wed Jan 16, 12:18 am)
Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Johannes Schindelin, (Wed Jan 16, 9:11 pm)
Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Johannes Schindelin, (Wed Jan 16, 9:48 pm)
Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Johannes Schindelin, (Thu Jan 17, 11:12 am)
Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Johannes Schindelin, (Wed Jan 16, 10:45 pm)
Re: [PATCH v2] Do not show "diff --git" metainfo with --no-p..., Johannes Schindelin, (Wed Jan 16, 9:54 pm)
Re: [PATCH/RFC] Do not show "diff --git" metainfo with --no-..., Johannes Schindelin, (Tue Jan 15, 9:37 pm)
Re: [PATCH/RFC] Do not show "diff --git" metainfo with --no-..., Johannes Schindelin, (Tue Jan 15, 9:53 pm)
Re: [FEATURE REQUEST] git-svn format-patch, Pascal Obry, (Tue Jan 15, 1:10 pm)
Re: [FEATURE REQUEST] git-svn format-patch, Johannes Schindelin, (Tue Jan 15, 12:13 pm)
Re: [FEATURE REQUEST] git-svn format-patch, Chris Ortman, (Tue Jan 15, 12:23 pm)
Re: [FEATURE REQUEST] git-svn format-patch, Johannes Schindelin, (Tue Jan 15, 12:52 pm)
Re: [FEATURE REQUEST] git-svn format-patch, Chris Ortman, (Tue Jan 15, 1:07 pm)
Re: [FEATURE REQUEST] git-svn format-patch, Johannes Schindelin, (Tue Jan 15, 1:11 pm)
Re: [FEATURE REQUEST] git-svn format-patch, Chris Ortman, (Tue Jan 15, 3:04 pm)
Re: [FEATURE REQUEST] git-svn format-patch, Jan Hudec, (Tue Jan 15, 4:15 pm)
Re: [FEATURE REQUEST] git-svn format-patch, Miles Bader, (Wed Jan 16, 2:41 am)
Re: [FEATURE REQUEST] git-svn format-patch, Shawn O. Pearce, (Wed Jan 16, 2:54 am)
speck-geostationary