Re: [PATCH] Teach remote machinery about remotes.default config variable

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Junio C Hamano
Date: Sunday, January 13, 2008 - 6:50 pm

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:


That happens to match my personal feeling.

HOWEVER.

We treat 'origin' in a special way when you do this:

	$ git clone somewhere new.git
        $ cd new.git
        $ git checkout HEAD^0
        $ git pull

And we already have "clone -o" and claim to support that option.
I think that it is very reasonable from the consistency point of
view to make sure that the following sequence treats 'frotz' the
same special way the above treats 'origin' specially:

	$ git clone -o frotz somewhere new.git
        $ cd new.git
        $ git checkout HEAD^0
        $ git pull

A purist alternative is to deprecate "git clone -o" and
eventually remove it.

Note that I was agreeing only with this specific aspect of the
argument.  I am not at all interested in getting involved in
refining or re-defining the existing submodule semantics this
late in the cycle before 1.5.4.  But I can very well see that
fixing this specific inconsistency can be separated out from the
rest of Mark's series and viewed as a set of trivially correct
fixes.


Currently the ones I looked at and consider possible 1.5.4
material are http-push fixes from Grégoire Barbier and
parse_commit_buffer() tightening from Martin Koegler.

Recently I looked at the following patches and topics but I do
not think any of them belongs to 1.5.4.  None of them is obvious
and trivially correct fix to regressions or serious existing
bugs:

 * compress/decompress abstraction (Marco)

 * crlf (Steffen Prohaska and Dmitry Potapov)

 * whitespace error: "cr at eol is ok" (me)

 * various conflicting submodule changes(Ping Yin, Mark
   Levedahl, Imran M Yousuf)

 * unconfigured ident safety (Stephen Sinclair)

 * gitweb feed from commit to commitdiff (Florian La Rouche --
   Jakub seems to be on top of this so I am not worried about it
   too much).

 * color.ui (Matthias Kestenholz)

 * test scripts to use valgrind (Jeff King, but there was another
   one in the past -- can their efforts compared and coordinated
   better?).

 * various lstat(2) reduction changes (me).

 * pathname safety on insane filesystems (Linus, Robin
   Rosenberg, me).

(yes, some of the above list do not even have any code).

I am hoping that authors will resend the ones they really care
about after 1.5.4, as I do not want to take patches early.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] git-clone - Set remotes.origin config variable, Mark Levedahl, (Sun Jan 13, 9:27 am)
Re: [PATCH] Teach remote machinery about remotes.default c ..., Johannes Schindelin, (Sun Jan 13, 2:27 pm)
Re: [PATCH] Teach remote machinery about remotes.default c ..., Junio C Hamano, (Sun Jan 13, 6:50 pm)
safecrlf not in 1.5.4 (was Re: [PATCH] Teach remote machin ..., Steffen Prohaska, (Sun Jan 13, 11:49 pm)
Re: safecrlf not in 1.5.4, Junio C Hamano, (Mon Jan 14, 12:30 am)
Re: [msysGit] Re: safecrlf not in 1.5.4, Steffen Prohaska, (Mon Jan 14, 1:29 am)
Re: safecrlf not in 1.5.4, Dmitry Potapov, (Mon Jan 14, 2:04 am)
Re: [PATCH] Teach remote machinery about remotes.default c ..., Johannes Schindelin, (Mon Jan 14, 4:18 am)
Re: safecrlf not in 1.5.4, Pierre Habouzit, (Mon Jan 14, 10:35 am)
Re: [msysGit] Re: safecrlf not in 1.5.4, Junio C Hamano, (Mon Jan 14, 12:41 pm)
What's not in 'master' but should be, Junio C Hamano, (Fri Jan 18, 2:41 am)
Re: What's not in 'master' but should be, Lars Hjemli, (Fri Jan 18, 3:15 am)
Re: What's not in 'master' but should be, Junio C Hamano, (Fri Jan 18, 3:24 am)
What's not in 'master', and likely not to be until 1.5.4, Junio C Hamano, (Fri Jan 18, 3:40 am)
Re: What's not in 'master' but should be, Lars Hjemli, (Fri Jan 18, 3:53 am)
Re: What's not in 'master' but should be, Junio C Hamano, (Fri Jan 18, 4:09 am)
Re: What's not in 'master' but should be, Lars Hjemli, (Fri Jan 18, 4:54 am)
Re: What's not in 'master' but should be, Johannes Schindelin, (Fri Jan 18, 5:34 am)
Re: What's not in 'master', and likely not to be until 1.5.4, Steffen Prohaska, (Fri Jan 18, 5:53 am)
Re: What's not in 'master', and likely not to be until 1.5.4, Steffen Prohaska, (Fri Jan 18, 6:04 am)
Re: What's not in 'master', and likely not to be until 1.5.4, Johannes Schindelin, (Fri Jan 18, 6:09 am)
Re: What's not in 'master', and likely not to be until 1.5.4, Johannes Schindelin, (Fri Jan 18, 6:11 am)
Re: What's not in 'master', and likely not to be until 1.5.4, Steffen Prohaska, (Fri Jan 18, 6:23 am)
Re: What's not in 'master' but should be, Lars Hjemli, (Fri Jan 18, 7:19 am)
Re: What's not in 'master' but should be, Johannes Schindelin, (Fri Jan 18, 11:28 am)
Re: What's not in 'master' but should be, Johannes Schindelin, (Fri Jan 18, 11:36 am)
Re: What's not in 'master', and likely not to be until 1.5.4, Johannes Schindelin, (Fri Jan 18, 1:36 pm)
Re: What's not in 'master', and likely not to be until 1.5.4, Johannes Schindelin, (Fri Jan 18, 1:58 pm)
Re: What's not in 'master' but should be, Mike Hommey, (Fri Jan 18, 11:14 pm)
Re: [PATCH] http-push: fix webdav lock leak., Grégoire Barbier, (Sat Jan 19, 8:21 am)
Re: [PATCH] http-push: fix webdav lock leak., Johannes Schindelin, (Sat Jan 19, 4:38 pm)
Re: What's not in 'master', and likely not to be until 1.5.4, Shawn O. Pearce, (Sun Jan 20, 9:46 pm)
Re: What's not in 'master', and likely not to be until 1.5.4, Imran M Yousuf, (Sun Jan 20, 10:55 pm)
Re: What's not in 'master', and likely not to be until 1.5.4, Junio C Hamano, (Sun Jan 20, 11:29 pm)
[PATCH] submodule: Document the details of the command lin ..., Steffen Prohaska, (Sun Jan 20, 11:41 pm)
Re: What's not in 'master', and likely not to be until 1.5.4, Steffen Prohaska, (Sun Jan 20, 11:42 pm)
Re: What's not in 'master', and likely not to be until 1.5.4, Johannes Schindelin, (Mon Jan 21, 3:37 am)
Re: What's not in 'master', and likely not to be until 1.5.4, Shawn O. Pearce, (Tue Jan 22, 9:44 pm)
Re: What's not in 'master', and likely not to be until 1.5.4, Johannes Schindelin, (Wed Jan 23, 4:12 am)
Re: What's not in 'master' but should be, Johannes Schindelin, (Mon Feb 18, 12:57 pm)