Re: [PATCH] Add committer and author names to top of COMMIT_EDITMSG.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Stephen Sinclair <radarsat1@...>
Cc: Junio C Hamano <gitster@...>, <git@...>
Date: Saturday, January 12, 2008 - 12:57 am

"Stephen Sinclair" <radarsat1@gmail.com> writes:


They are both valid means to make sure you did not misconfigure.

You omitted the part that matters from the part you quoted
above, but this discussion was about "showing AUTHOR if it is
different from me", which was _one of_ the two conditions I
suggested in my counterproposal, and I was saying that it is
useless to expect that you would be able to find a
misconfiguration when AUTHOR is shown for this first reason.
This part is _not_ about catching your misconfiguration.

The other part is about the misconfiguration catching.


Yes, and earlier you said one of the undesirable ones was
"yourname@foo.local" (and others were "yourname@foo.(none)").
IOW, "localhost" is one of the things you want to catch as
unconfigured bogosity that you want to catch, isn't it?

And that is _the other_ condition in my counterproposal to show
AUTHOR.

To rephrase, you would show AUTHOR when one of the conditions
holds true, either:

 (1) "not me" (so that we can remind that other's commit is
     being amended); _OR_ 

 (2) "funny me" (so that we can catch misconfiguration.


The latter would not have to trigger once you configure your
~/.gitconfig (or .git/config) properly.


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] Add committer and author names to top of COMMIT_..., Stephen Sinclair, (Fri Jan 11, 10:25 pm)
Re: [PATCH] Add committer and author names to top of COMMIT_..., Junio C Hamano, (Sat Jan 12, 12:57 am)
Re: [PATCH] Add committer and author names to top of COMMIT_..., Johannes Schindelin, (Fri Jan 11, 5:26 pm)