Re: CRLF problems with Git on Win32

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Gregory Jefferis <jefferis@...>
Cc: Junio C Hamano <gitster@...>, Steffen Prohaska <prohaska@...>, Git Mailing List <git@...>
Date: Thursday, January 10, 2008 - 8:02 pm

On Thu, 10 Jan 2008, Gregory Jefferis wrote:

Why? You can screw yourself more, and much more easily (and much more 
subtly), by leaving CRLF alone on Windows.

The thing is, 99.9% of all people will be *much* better off with 
autocrlf=true on Windows than with it defaulting to off (or even fail).

Isn't *that* the whole point of having a default? Pick the thing that is 
the right thing for almost everybody?

And no, "but think of the children.." is not a valid argument. Sure, you 
*can* corrupt binary imags with CRLF conversion. But it's really quite 
hard, since the git heuristics for guessing are rather good. You really 
have to work at it, and if you do, you're pretty damn likely to know about 
the issue, so that 0.1% that really needs to not convert (and it's usually 
one specific file type!) would probably not even turn off CRLF, but rather 
add a .gitattributes entry for that one filetype!

(Side note: if there are known filetype extensions that have problems with 
the git guessing, we sure as heck could take the filename into account 
when guessing! There's absolutely nothing that says that we only have to 
look at the contents when guessing about the text/binary thing!)

			Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
CRLF problems with Git on Win32, Peter Karlsson, (Mon Jan 7, 5:16 am)
Re: CRLF problems with Git on Win32, Steffen Prohaska, (Mon Jan 7, 5:57 am)
Re: CRLF problems with Git on Win32, Peter Klavins, (Mon Jan 7, 6:13 am)
Re: CRLF problems with Git on Win32, Peter Karlsson, (Mon Jan 7, 9:50 am)
Re: CRLF problems with Git on Win32, Steffen Prohaska, (Mon Jan 7, 12:05 pm)
Re: CRLF problems with Git on Win32, Peter Klavins, (Mon Jan 7, 10:14 am)
Re: CRLF problems with Git on Win32, Steffen Prohaska, (Mon Jan 7, 8:58 am)
Re: CRLF problems with Git on Win32, Jeff King, (Mon Jan 7, 6:12 am)
Re: CRLF problems with Git on Win32, Robin Rosenberg, (Mon Jan 7, 2:47 pm)
Re: CRLF problems with Git on Win32, Johannes Schindelin, (Mon Jan 7, 3:16 pm)
Re: CRLF problems with Git on Win32, Robin Rosenberg, (Mon Jan 7, 5:03 pm)
Re: CRLF problems with Git on Win32, Thomas Neumann, (Mon Jan 7, 5:42 pm)
Re: CRLF problems with Git on Win32, Peter Karlsson, (Tue Jan 8, 6:56 am)
Re: CRLF problems with Git on Win32, Jan Hudec, (Wed Jan 9, 2:46 pm)
Re: CRLF problems with Git on Win32, Peter Harris, (Tue Jan 8, 9:07 am)
Re: CRLF problems with Git on Win32, Dmitry Potapov, (Tue Jan 8, 5:33 pm)
Re: CRLF problems with Git on Win32, Kelvie Wong, (Tue Jan 8, 11:58 am)
Re: CRLF problems with Git on Win32, Peter Karlsson, (Tue Jan 8, 11:20 am)
Re: CRLF problems with Git on Win32, Johannes Schindelin, (Tue Jan 8, 7:52 am)
Re: CRLF problems with Git on Win32, Jeff King, (Tue Jan 8, 7:07 am)
Re: CRLF problems with Git on Win32, Johannes Schindelin, (Tue Jan 8, 7:54 am)
Re: CRLF problems with Git on Win32, Linus Torvalds, (Mon Jan 7, 5:36 pm)
Re: CRLF problems with Git on Win32, Peter Karlsson, (Tue Jan 8, 5:26 pm)
Re: CRLF problems with Git on Win32, Johannes Schindelin, (Wed Jan 9, 6:56 am)
Re: CRLF problems with Git on Win32, Steffen Prohaska, (Wed Jan 9, 8:41 am)
Re: CRLF problems with Git on Win32, Gregory Jefferis, (Wed Jan 9, 9:52 am)
Re: CRLF problems with Git on Win32, Dmitry Potapov, (Wed Jan 9, 11:03 am)
Re: CRLF problems with Git on Win32, Gregory Jefferis, (Wed Jan 9, 1:37 pm)
Re: CRLF problems with Git on Win32, Dmitry Potapov, (Wed Jan 9, 3:05 pm)
Re: CRLF problems with Git on Win32, Johannes Schindelin, (Wed Jan 9, 10:03 am)
Re: CRLF problems with Git on Win32, Dmitry Potapov, (Wed Jan 9, 11:22 am)
Re: CRLF problems with Git on Win32, Johannes Schindelin, (Mon Jan 7, 5:18 pm)
Re: CRLF problems with Git on Win32, Steffen Prohaska, (Mon Jan 7, 5:40 pm)
Re: CRLF problems with Git on Win32, J. Bruce Fields, (Tue Jan 8, 1:29 pm)
Re: CRLF problems with Git on Win32, Steffen Prohaska, (Tue Jan 8, 1:56 pm)
Re: CRLF problems with Git on Win32, Junio C Hamano, (Tue Jan 8, 2:07 pm)
Re: CRLF problems with Git on Win32, Gregory Jefferis, (Thu Jan 10, 3:58 pm)
Re: CRLF problems with Git on Win32, Rogan Dawes, (Thu Jan 10, 4:50 pm)
Re: CRLF problems with Git on Win32, Junio C Hamano, (Thu Jan 10, 9:15 pm)
Re: CRLF problems with Git on Win32, Gregory Jefferis, (Thu Jan 10, 5:15 pm)
Re: CRLF problems with Git on Win32, Linus Torvalds, (Thu Jan 10, 4:20 pm)
Re: CRLF problems with Git on Win32, Gregory Jefferis, (Thu Jan 10, 5:28 pm)
Re: CRLF problems with Git on Win32, Linus Torvalds, (Thu Jan 10, 8:02 pm)
Re: CRLF problems with Git on Win32, Steffen Prohaska, (Fri Jan 11, 3:10 am)
Re: CRLF problems with Git on Win32, Linus Torvalds, (Fri Jan 11, 11:58 am)
Re: CRLF problems with Git on Win32, Steffen Prohaska, (Fri Jan 11, 12:28 pm)
Re: CRLF problems with Git on Win32, Gregory Jefferis, (Fri Jan 11, 3:00 pm)
Re: CRLF problems with Git on Win32, Dmitry Potapov, (Sat Jan 12, 11:26 am)
Re: CRLF problems with Git on Win32, Linus Torvalds, (Fri Jan 11, 1:25 pm)
Re: CRLF problems with Git on Win32, Steffen Prohaska, (Fri Jan 11, 1:56 pm)
Re: CRLF problems with Git on Win32, Linus Torvalds, (Fri Jan 11, 2:10 pm)
Re: CRLF problems with Git on Win32, Christer Weinigel, (Fri Jan 11, 3:53 pm)
Re: CRLF problems with Git on Win32, Steffen Prohaska, (Fri Jan 11, 2:29 pm)
Re: CRLF problems with Git on Win32, Linus Torvalds, (Fri Jan 11, 3:16 pm)
Re: CRLF problems with Git on Win32, Sam Ravnborg, (Fri Jan 11, 3:50 pm)
Re: CRLF problems with Git on Win32, Dmitry Potapov, (Sat Jan 12, 11:08 am)
Re: CRLF problems with Git on Win32, Johannes Schindelin, (Fri Jan 11, 5:18 pm)
Re: CRLF problems with Git on Win32, Sam Ravnborg, (Fri Jan 11, 6:21 pm)
Re: CRLF problems with Git on Win32, Junio C Hamano, (Thu Jan 10, 8:32 pm)
Re: CRLF problems with Git on Win32, Dmitry Potapov, (Thu Jan 10, 7:23 pm)
Re: CRLF problems with Git on Win32, Steffen Prohaska, (Tue Jan 8, 2:58 pm)
Re: CRLF problems with Git on Win32, Dmitry Potapov, (Tue Jan 8, 4:50 pm)
Re: CRLF problems with Git on Win32, Linus Torvalds, (Tue Jan 8, 5:31 pm)
Re: CRLF problems with Git on Win32, Dmitry Potapov, (Tue Jan 8, 6:51 pm)
Re: CRLF problems with Git on Win32, Linus Torvalds, (Tue Jan 8, 8:01 pm)
Re: CRLF problems with Git on Win32, Sean, (Tue Jan 8, 6:09 pm)
Re: CRLF problems with Git on Win32, Junio C Hamano, (Tue Jan 8, 5:15 pm)
Re: CRLF problems with Git on Win32, Robin Rosenberg, (Tue Jan 8, 5:57 pm)
Re: CRLF problems with Git on Win32, Junio C Hamano, (Tue Jan 8, 4:11 pm)
Re: CRLF problems with Git on Win32, Steffen Prohaska, (Tue Jan 8, 4:20 pm)
Re: CRLF problems with Git on Win32, J. Bruce Fields, (Tue Jan 8, 3:09 pm)
Re: CRLF problems with Git on Win32, Steffen Prohaska, (Tue Jan 8, 3:59 pm)
Re: CRLF problems with Git on Win32, Junio C Hamano, (Tue Jan 8, 3:47 pm)
Re: CRLF problems with Git on Win32, Linus Torvalds, (Tue Jan 8, 4:41 pm)
Re: [msysGit] Re: CRLF problems with Git on Win32, Steffen Prohaska, (Tue Jan 8, 4:02 pm)
Re: [msysGit] Re: CRLF problems with Git on Win32, Johannes Schindelin, (Wed Jan 9, 7:03 am)
Re: [msysGit] Re: CRLF problems with Git on Win32, Steffen Prohaska, (Wed Jan 9, 8:45 am)
Re: [msysGit] Re: CRLF problems with Git on Win32, Johannes Schindelin, (Wed Jan 9, 9:32 am)
Re: CRLF problems with Git on Win32, Junio C Hamano, (Tue Jan 8, 4:15 pm)
Re: [msysGit] Re: CRLF problems with Git on Win32, Steffen Prohaska, (Tue Jan 8, 4:39 pm)
Re: CRLF problems with Git on Win32, Junio C Hamano, (Mon Jan 7, 6:06 pm)
Re: CRLF problems with Git on Win32, Steffen Prohaska, (Tue Jan 8, 3:02 am)
Re: CRLF problems with Git on Win32, Junio C Hamano, (Tue Jan 8, 3:29 am)
Re: CRLF problems with Git on Win32, Jeff King, (Tue Jan 8, 6:08 am)
Re: CRLF problems with Git on Win32, Gregory Jefferis, (Tue Jan 8, 8:20 am)
Re: CRLF problems with Git on Win32, Junio C Hamano, (Tue Jan 8, 6:35 am)
Re: CRLF problems with Git on Win32, Linus Torvalds, (Mon Jan 7, 6:58 pm)
Re: [msysGit] Re: CRLF problems with Git on Win32, Marius Storm-Olsen, (Tue Jan 8, 4:55 am)
Re: CRLF problems with Git on Win32, Gregory Jefferis, (Mon Jan 7, 7:46 pm)
git and unicode, Gonzalo Garramuño, (Tue Jan 8, 7:09 am)
Re: git and unicode, Robin Rosenberg, (Tue Jan 8, 4:36 pm)
Re: git and unicode, Remi Vanicat, (Tue Jan 8, 11:09 am)
Re: CRLF problems with Git on Win32, Junio C Hamano, (Mon Jan 7, 6:00 am)
Re: CRLF problems with Git on Win32, Steffen Prohaska, (Mon Jan 7, 8:15 am)