Home » Mailing list archives » git » 2007 » September » 6

Re: [PATCH 1/7] Rework strbuf API and semantics.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Johannes Schindelin <Johannes.Schindelin@...>
To: Pierre Habouzit <madcoder@...>
Cc: <git@...>
Subject: Re: [PATCH 1/7] Rework strbuf API and semantics.
Date: Thursday, September 6, 2007 - 10:09 am

Hi,

let me thank you for this very nicely done patch series.  Except for 5/7, 
they look pretty much obvious changes to me.  I'll review that in detail 
later.

On Thu, 6 Sep 2007, Pierre Habouzit wrote:


Would not "struct strbuf sb = { 0 };" have the same effect?  (I am not so 
standards-keen as other people, who I have no doubt will gladly answer 
this one.)

Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
strbuf API, Pierre Habouzit, (Sun Sep 2, 6:42 pm)
Re: strbuf API, Matthieu Moy, (Mon Sep 3, 4:32 am)
Re: strbuf API, Pierre Habouzit, (Mon Sep 3, 4:49 am)
Re: strbuf API, Matthieu Moy, (Mon Sep 3, 5:02 am)
Re: strbuf API, Junio C Hamano, (Mon Sep 3, 5:18 am)
Re: strbuf API, Johannes Schindelin, (Mon Sep 3, 8:29 am)
Re: strbuf API, Pierre Habouzit, (Mon Sep 3, 7:53 am)
Re: strbuf API, Johan Herland, (Mon Sep 3, 1:43 am)
Re: strbuf API, Pierre Habouzit, (Mon Sep 3, 4:46 am)
Re: strbuf API, Miles Bader, (Mon Sep 3, 9:52 pm)
strbuf new semantics, let's give it a try, Pierre Habouzit, (Tue Sep 4, 4:47 am)
[PATCH] Rework strbuf API and semantics., Pierre Habouzit, (Tue Sep 4, 4:47 am)
Re: [PATCH] Rework strbuf API and semantics., Johannes Schindelin, (Tue Sep 4, 7:11 am)
Re: [PATCH] Rework strbuf API and semantics., Pierre Habouzit, (Tue Sep 4, 7:53 am)
Re: [PATCH] Rework strbuf API and semantics., Miles Bader, (Wed Sep 5, 12:44 am)
Re: [PATCH] Rework strbuf API and semantics., Andreas Ericsson, (Tue Sep 4, 9:34 am)
[PATCH] Simplify strbuf uses in fast-import.c using the prop..., Pierre Habouzit, (Tue Sep 4, 10:01 am)
Re: [PATCH] Simplify strbuf uses in fast-import.c using the ..., , (Tue Sep 4, 7:46 pm)
Re: [PATCH] Simplify strbuf uses in fast-import.c using the ..., Pierre Habouzit, (Wed Sep 5, 3:48 am)
Re: [PATCH] Simplify strbuf uses in fast-import.c using the ..., Junio C Hamano, (Wed Sep 5, 4:05 am)
Re: [PATCH] Simplify strbuf uses in fast-import.c using the ..., Pierre Habouzit, (Wed Sep 5, 4:57 am)
[PATCH] Rework strbuf API and semantics., Pierre Habouzit, (Wed Sep 5, 3:18 pm)
Re: [PATCH] Rework strbuf API and semantics., Junio C Hamano, (Thu Sep 6, 6:03 am)
Re: [PATCH] Rework strbuf API and semantics., Pierre Habouzit, (Thu Sep 6, 6:22 am)
Re: [PATCH] Rework strbuf API and semantics., Junio C Hamano, (Thu Sep 6, 5:31 am)
Re: [PATCH] Rework strbuf API and semantics., Pierre Habouzit, (Thu Sep 6, 5:49 am)
[PATCH] Simplify strbuf uses in archive-tar.c using the prop..., Pierre Habouzit, (Wed Sep 5, 3:18 pm)
Re: [PATCH] Simplify strbuf uses in archive-tar.c using the ..., Junio C Hamano, (Wed Sep 19, 4:06 am)
Re: [PATCH] Simplify strbuf uses in archive-tar.c using the ..., Pierre Habouzit, (Wed Sep 19, 4:36 am)
[PATCH] Simplify strbuf uses in fast-import.c using the prop..., Pierre Habouzit, (Wed Sep 5, 3:18 pm)
Re: [PATCH] Simplify strbuf uses in fast-import.c using the ..., Pierre Habouzit, (Wed Sep 5, 3:21 pm)
[PATCH] Use proper strbuf API, and also simplify cmd_data co..., Pierre Habouzit, (Wed Sep 5, 3:18 pm)
[PATCH] Simplify write_tree using strbuf's., Pierre Habouzit, (Wed Sep 5, 3:18 pm)
[PATCH] Further strbuf re-engineering., Pierre Habouzit, (Wed Sep 5, 3:18 pm)
Re: [PATCH] Further strbuf re-engineering., Junio C Hamano, (Wed Sep 19, 4:05 am)
[PATCH] Eradicate yet-another-buffer implementation in buiti..., Pierre Habouzit, (Wed Sep 5, 3:18 pm)
[PATCH] More strbuf uses in cache-tree.c., Pierre Habouzit, (Wed Sep 5, 3:18 pm)
Re: [PATCH] Simplify strbuf uses in fast-import.c using the ..., , (Tue Sep 4, 7:46 pm)
[PATCH] Rework strbuf API and semantics., Pierre Habouzit, (Tue Sep 4, 10:01 am)
Re: [PATCH] Rework strbuf API and semantics., Johannes Schindelin, (Tue Sep 4, 11:44 am)
Re: [PATCH] Rework strbuf API and semantics., Pierre Habouzit, (Tue Sep 4, 12:18 pm)
Re: [PATCH] Rework strbuf API and semantics., Wincent Colaiuta, (Tue Sep 4, 1:18 pm)
[PATCH] Use proper strbuf API, and also simplify cmd_data co..., Pierre Habouzit, (Tue Sep 4, 10:01 am)
[PATCH] Add strbuf_fread, use it in fast-import.c., Pierre Habouzit, (Tue Sep 4, 4:48 am)
Use strbufs in commit.c (pretty printing), Pierre Habouzit, (Sat Sep 8, 7:53 am)
[PATCH 1/3] Add strbuf_rtrim (to remove trailing spaces)., Pierre Habouzit, (Sat Sep 8, 7:53 am)
Re: [PATCH 1/3] Add strbuf_rtrim (to remove trailing spaces)., , (Sat Sep 8, 12:18 pm)
Re: [PATCH 1/3] Add strbuf_rtrim (to remove trailing spaces)., Pierre Habouzit, (Sat Sep 8, 6:53 pm)
Re: [PATCH 1/3] Add strbuf_rtrim (to remove trailing spaces)., Pierre Habouzit, (Sat Sep 8, 7:44 pm)
[PATCH 2/3] Change semantics of interpolate to work like snp..., Pierre Habouzit, (Sat Sep 8, 7:53 am)
[PATCH 3/3] Rework pretty_print_commit to use strbufs instea..., Pierre Habouzit, (Sat Sep 8, 7:53 am)
Re: [PATCH 3/3] Rework pretty_print_commit to use strbufs in..., , (Sat Sep 8, 2:40 pm)
Re: [PATCH 3/3] Rework pretty_print_commit to use strbufs in..., Pierre Habouzit, (Sat Sep 8, 2:49 pm)
Re: [PATCH 3/3] Rework pretty_print_commit to use strbufs in..., David Kastrup, (Sat Sep 8, 7:59 am)
Re: [PATCH 3/3] Rework pretty_print_commit to use strbufs in..., Pierre Habouzit, (Sat Sep 8, 8:28 am)
Re: [PATCH 3/3] Rework pretty_print_commit to use strbufs in..., Pierre Habouzit, (Sat Sep 8, 8:17 am)
strbuf new API, take 2 for inclusion, Pierre Habouzit, (Thu Sep 6, 7:20 am)
Re: strbuf new API, take 2 for inclusion, Jeff King, (Thu Sep 6, 8:58 am)
Re: strbuf new API, take 2 for inclusion, Pierre Habouzit, (Thu Sep 6, 1:15 pm)
Re: strbuf new API, take 2 for inclusion, Jeff King, (Thu Sep 6, 1:16 pm)
Re: strbuf new API, take 2 for inclusion, Pierre Habouzit, (Thu Sep 6, 1:19 pm)
[PATCH 1/7] Rework strbuf API and semantics., Pierre Habouzit, (Thu Sep 6, 7:20 am)
Re: [PATCH 1/7] Rework strbuf API and semantics., Johannes Schindelin, (Thu Sep 6, 10:09 am)
Re: [PATCH 1/7] Rework strbuf API and semantics., David Kastrup, (Thu Sep 6, 10:43 am)
Re: [PATCH 1/7] Rework strbuf API and semantics., Jeff King, (Thu Sep 6, 10:52 am)
Re: [PATCH 1/7] Rework strbuf API and semantics., Jeff King, (Thu Sep 6, 10:21 am)
Re: [PATCH 1/7] Rework strbuf API and semantics., David Kastrup, (Thu Sep 6, 10:44 am)
Re: [PATCH 1/7] Rework strbuf API and semantics., Jeff King, (Thu Sep 6, 10:50 am)
Re: [PATCH 1/7] Rework strbuf API and semantics., David Kastrup, (Thu Sep 6, 11:06 am)
Re: [PATCH 1/7] Rework strbuf API and semantics., Johannes Sixt, (Thu Sep 6, 11:45 am)
Re: [PATCH 1/7] Rework strbuf API and semantics., Jeff King, (Thu Sep 6, 11:36 am)
Re: [PATCH 1/7] Rework strbuf API and semantics., David Kastrup, (Thu Sep 6, 11:53 am)
Re: [PATCH 1/7] Rework strbuf API and semantics., Kristian , (Thu Sep 6, 1:49 pm)
[PATCH 2/7] Simplify strbuf uses in archive-tar.c using the ..., Pierre Habouzit, (Thu Sep 6, 7:20 am)
Re: [PATCH 2/7] Simplify strbuf uses in archive-tar.c using ..., Kristian , (Thu Sep 6, 1:59 pm)
Re: [PATCH 2/7] Simplify strbuf uses in archive-tar.c using ..., Pierre Habouzit, (Thu Sep 6, 2:08 pm)
Re: [PATCH 2/7] Simplify strbuf uses in archive-tar.c using ..., Kristian , (Thu Sep 6, 2:18 pm)
Re: [PATCH 2/7] Simplify strbuf uses in archive-tar.c using ..., Pierre Habouzit, (Thu Sep 6, 2:27 pm)
Re: [PATCH 2/7] Simplify strbuf uses in archive-tar.c using ..., , (Thu Sep 6, 6:54 pm)
[PATCH 3/7] Use proper strbuf API, and also simplify cmd_dat..., Pierre Habouzit, (Thu Sep 6, 7:20 am)
[PATCH 4/7] Simplify write_tree using strbuf's., Pierre Habouzit, (Thu Sep 6, 7:20 am)
[PATCH 5/7] Further strbuf re-engineering., Pierre Habouzit, (Thu Sep 6, 7:20 am)
[PATCH 6/7] Eradicate yet-another-buffer implementation in b..., Pierre Habouzit, (Thu Sep 6, 7:20 am)
Re: [PATCH 6/7] Eradicate yet-another-buffer implementation ..., Johannes Schindelin, (Thu Sep 6, 10:05 am)
Re: [PATCH 6/7] Eradicate yet-another-buffer implementation ..., Pierre Habouzit, (Thu Sep 6, 1:17 pm)
Re: [PATCH 6/7] Eradicate yet-another-buffer implementation ..., David Kastrup, (Thu Sep 6, 4:16 pm)
Re: [PATCH 6/7] Eradicate yet-another-buffer implementation ..., Pierre Habouzit, (Thu Sep 6, 4:54 pm)
[PATCH 7/7] More strbuf uses in cache-tree.c., Pierre Habouzit, (Thu Sep 6, 7:20 am)