Home » Mailing list archives » git » 2007 » September » 6

Re: [RFC] Convert builin-mailinfo.c to use The Better String Library.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dmitry Kakurin <dmitry.kakurin@...>
To: Matthieu Moy <Matthieu.Moy@...>
Cc: Git <git@...>
Subject: Re: [RFC] Convert builin-mailinfo.c to use The Better String Library.
Date: Thursday, September 6, 2007 - 12:48 am

[ snip ]

When I first looked at Git source code two things struck me as odd:
1. Pure C as opposed to C++. No idea why. Please don't talk about 
portability, it's BS.
2. Brute-force, direct string manipulation. It's both verbose and 
error-prone. This makes it hard to follow high-level code logic.

- Dmitry

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[RFC] Convert builin-mailinfo.c to use The Better String Lib..., , (Tue Sep 4, 4:50 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., , (Fri Sep 7, 6:47 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Kristian , (Wed Sep 5, 11:27 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Kristian , (Wed Sep 5, 10:54 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Matthieu Moy, (Wed Sep 5, 1:29 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Dmitry Kakurin, (Thu Sep 6, 12:48 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Linus Torvalds, (Thu Sep 6, 1:50 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Dmitry Kakurin, (Thu Sep 6, 8:21 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Johannes Schindelin, (Fri Sep 7, 6:21 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Dmitry Kakurin, (Fri Sep 7, 8:32 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Alex Riesen, (Sat Sep 8, 7:25 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., David Kastrup, (Sat Sep 8, 2:24 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., David Kastrup, (Fri Sep 7, 2:47 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Andy Parkins, (Fri Sep 7, 3:41 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., David Kastrup, (Fri Sep 7, 4:08 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Wincent Colaiuta, (Thu Sep 6, 11:06 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Walter Bright, (Fri Sep 7, 4:36 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Wincent Colaiuta, (Fri Sep 7, 7:52 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Walter Bright, (Fri Sep 7, 3:25 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Andreas Ericsson, (Fri Sep 7, 5:41 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Walter Bright, (Fri Sep 7, 3:23 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Andreas Ericsson, (Sat Sep 8, 8:25 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Walter Bright, (Mon Sep 10, 6:33 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Andreas Ericsson, (Tue Sep 11, 4:17 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., David Kastrup, (Sun Sep 9, 4:22 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., David Kastrup, (Fri Sep 7, 3:40 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Andreas Ericsson, (Fri Sep 7, 2:25 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Wincent Colaiuta, (Fri Sep 7, 7:30 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Johannes Schindelin, (Fri Sep 7, 6:56 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., David Kastrup, (Fri Sep 7, 12:09 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Andreas Ericsson, (Fri Sep 7, 7:54 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Wincent Colaiuta, (Fri Sep 7, 8:33 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Andreas Ericsson, (Fri Sep 7, 9:58 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Wincent Colaiuta, (Fri Sep 7, 10:13 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Andreas Ericsson, (Sat Sep 8, 8:09 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Karl , (Fri Sep 7, 8:55 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Linus Torvalds, (Thu Sep 6, 8:38 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Linus Torvalds, (Thu Sep 6, 9:12 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Walter Bright, (Fri Sep 7, 1:09 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Pierre Habouzit, (Fri Sep 7, 5:41 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Walter Bright, (Fri Sep 7, 3:03 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Pierre Habouzit, (Fri Sep 7, 3:41 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Walter Bright, (Fri Sep 7, 4:40 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Pierre Habouzit, (Fri Sep 7, 4:56 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Walter Bright, (Fri Sep 7, 6:54 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., David Kastrup, (Fri Sep 7, 3:51 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Pierre Habouzit, (Fri Sep 7, 3:59 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., David Kastrup, (Fri Sep 7, 3:31 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Walter Bright, (Fri Sep 7, 4:49 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., David Kastrup, (Fri Sep 7, 3:40 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Wincent Colaiuta, (Fri Sep 7, 7:36 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Walter Bright, (Fri Sep 7, 4:15 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., David Kastrup, (Fri Sep 7, 4:26 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Walter Bright, (Fri Sep 7, 5:14 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., alan, (Thu Sep 6, 9:40 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Dmitry Kakurin, (Thu Sep 6, 9:08 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., David Kastrup, (Fri Sep 7, 2:50 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Linus Torvalds, (Thu Sep 6, 9:27 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Johannes Schindelin, (Fri Sep 7, 6:26 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Dmitry Kakurin, (Thu Sep 6, 11:09 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Johannes Schindelin, (Fri Sep 7, 6:28 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., David Kastrup, (Fri Sep 7, 2:52 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Andreas Ericsson, (Fri Sep 7, 2:31 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Dmitry Kakurin, (Fri Sep 7, 6:17 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Andreas Ericsson, (Sat Sep 8, 8:29 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., David Kastrup, (Fri Sep 7, 6:28 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Dmitry Kakurin, (Fri Sep 7, 8:37 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., David Kastrup, (Sat Sep 8, 2:25 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Theodore Tso, (Fri Sep 7, 2:15 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., David Symonds, (Fri Sep 7, 1:48 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Miles Bader, (Thu Sep 6, 1:03 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Johannes Schindelin, (Thu Sep 6, 8:08 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Shawn O. Pearce, (Thu Sep 6, 12:59 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Andreas Ericsson, (Thu Sep 6, 5:12 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., David Kastrup, (Thu Sep 6, 5:52 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Junio C Hamano, (Thu Sep 6, 5:35 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Andreas Ericsson, (Thu Sep 6, 6:21 am)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Miles Bader, (Wed Sep 5, 10:30 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Alex Riesen, (Tue Sep 4, 5:38 pm)
Re: [RFC] Convert builin-mailinfo.c to use The Better String..., Pierre Habouzit, (Tue Sep 4, 7:01 pm)