Re: [PATCH] Function for updating refs.

Previous thread: [PATCH] Function for updating refs. by Carlos Rica on Tuesday, September 4, 2007 - 9:38 pm. (1 message)

Next thread: People unaware of the importance of "git gc"? by Linus Torvalds on Wednesday, September 5, 2007 - 3:09 am. (79 messages)
To: Carlos Rica <jasampler@...>
Cc: Johannes Schindelin <Johannes.Schindelin@...>, <git@...>
Date: Wednesday, September 5, 2007 - 3:04 am

Thanks. Very nice.

I have two comments but I think they are very minor details I
can and should fix in my inbox and apply, instead of asking you

The original I did was sloppy and did not detect this situation;
thanks for fixing it. You do not refuse the primary operation,
which is to update the ref, so this should be a warning instead

This removal makes "struct ref_lock *lock" (not shown in the
context) unused. I will remove the declaration.

-

To: Junio C Hamano <gitster@...>
Cc: Johannes Schindelin <Johannes.Schindelin@...>, <git@...>
Date: Wednesday, September 5, 2007 - 8:03 am

Yes, it is. Also, I tested what would happen when the lock fails. I tried to
lock an already locked ref, and it died printing the message
die("unable to create '%s.lock': %s", path, strerror(errno)); from
lockfile.c. I think this is interesting. There are other failing
reasons that could

Thank you. Also in builtin-update-ref.c the main function could return
directly that value returned from the call to update_ref().
-

Previous thread: [PATCH] Function for updating refs. by Carlos Rica on Tuesday, September 4, 2007 - 9:38 pm. (1 message)

Next thread: People unaware of the importance of "git gc"? by Linus Torvalds on Wednesday, September 5, 2007 - 3:09 am. (79 messages)