Re: Mergetool generating blank files (1.5.3)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Junio C Hamano <gitster@...>
Cc: Theodore Ts'o <tytso@...>, <git@...>
Date: Thursday, September 27, 2007 - 6:23 pm

On 9/27/07, Junio C Hamano <gitster@pobox.com> wrote:

--- a/git-mergetool       2007-09-24 09:08:23.000000000 -0700
+++ b/git-mergetool        2007-09-27 15:04:15.000000000 -0700
@@ -12,6 +12,7 @@
 SUBDIRECTORY_OK=Yes
 . git-sh-setup
 require_work_tree
+prefix=$(git rev-parse --show-prefix)

 # Returns true if the mode reflects a symlink
 is_symlink () {
@@ -162,9 +163,9 @@
     local_mode=`git ls-files -u -- "$path" | awk '{if ($3==2) print $1;}'`
     remote_mode=`git ls-files -u -- "$path" | awk '{if ($3==3) print $1;}'`

-    base_present   && git cat-file blob ":1:$path" > "$BASE" 2>/dev/null
-    local_present  && git cat-file blob ":2:$path" > "$LOCAL" 2>/dev/null
-    remote_present && git cat-file blob ":3:$path" > "$REMOTE" 2>/dev/null
+    base_present   && git cat-file blob ":1:$prefix$path" > "$BASE" 2>/dev/null
+    local_present  && git cat-file blob ":2:$prefix$path" > "$LOCAL"
2>/dev/null
+    remote_present && git cat-file blob ":3:$prefix$path" > "$REMOTE"
2>/dev/null

     if test -z "$local_mode" -o -z "$remote_mode"; then
        echo "Deleted merge conflict for '$path':"
@@ -251,7 +252,7 @@
            ;;
        emerge)
            if base_present ; then
-               emacs -f emerge-files-with-ancestor-command "$LOCAL"
"$REMOTE" "$BASE" "$path"
+               emacs -f emerge-files-with-ancestor-command "$LOCAL"
"$REMOTE" "$BASE" "$(basename "$path")"
            else
                emacs -f emerge-files-command "$LOCAL" "$REMOTE"
"$(basename "$path")"
            fi



Finally got it to work.  emacs (at least the version I'm using,
22.1.1) seems to set the $PWD via its first argument, that is,
$LOCAL's directory, and when it goes to save, it tries to save $path
on top of that.

The updated patch above would be just to use the basename, that is, if
it is certain that $LOCAL and $path will always reside in the same
directory -- and I believe, but am not certain, that this is the case.

Also, I am not sure if this is specific to my version of Emacs, so
perhaps some further testing is required.

-- 
Kelvie
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Mergetool generating blank files (1.5.3), Kelvie Wong, (Thu Sep 27, 2:31 pm)
Re: Mergetool generating blank files (1.5.3), Pierre Habouzit, (Thu Sep 27, 2:57 pm)
Re: Mergetool generating blank files (1.5.3), Kelvie Wong, (Thu Sep 27, 3:24 pm)
Re: Mergetool generating blank files (1.5.3), Junio C Hamano, (Thu Sep 27, 3:58 pm)
Re: Mergetool generating blank files (1.5.3), Kelvie Wong, (Thu Sep 27, 4:12 pm)
Re: Mergetool generating blank files (1.5.3), Junio C Hamano, (Thu Sep 27, 4:28 pm)
Re: Mergetool generating blank files (1.5.3), Kelvie Wong, (Thu Sep 27, 4:38 pm)
Re: Mergetool generating blank files (1.5.3), Junio C Hamano, (Thu Sep 27, 4:47 pm)
Re: Mergetool generating blank files (1.5.3), Junio C Hamano, (Thu Sep 27, 4:51 pm)
Re: Mergetool generating blank files (1.5.3), Kelvie Wong, (Thu Sep 27, 5:17 pm)
Re: Mergetool generating blank files (1.5.3), Kelvie Wong, (Thu Sep 27, 5:22 pm)
Re: Mergetool generating blank files (1.5.3), Junio C Hamano, (Thu Sep 27, 5:33 pm)
Re: Mergetool generating blank files (1.5.3), Junio C Hamano, (Thu Sep 27, 5:41 pm)
Re: Mergetool generating blank files (1.5.3), Theodore Tso, (Thu Sep 27, 6:35 pm)
Re: Mergetool generating blank files (1.5.3), Kelvie Wong, (Thu Sep 27, 6:23 pm)
Re: Mergetool generating blank files (1.5.3), Theodore Tso, (Thu Sep 27, 6:52 pm)
Re: Mergetool generating blank files (1.5.3), Kelvie Wong, (Fri Sep 28, 12:17 am)
Re: Mergetool generating blank files (1.5.3), David Kastrup, (Fri Sep 28, 2:19 am)
Re: Mergetool generating blank files (1.5.3), Jeff King, (Thu Sep 27, 3:12 pm)
Re: Mergetool generating blank files (1.5.3), Pierre Habouzit, (Thu Sep 27, 3:16 pm)
Re: Mergetool generating blank files (1.5.3), Jeff King, (Thu Sep 27, 3:41 pm)
Re: Mergetool generating blank files (1.5.3), Russ Brown, (Thu Sep 27, 3:00 pm)
Re: Mergetool generating blank files (1.5.3), Pierre Habouzit, (Thu Sep 27, 3:11 pm)
Re: Mergetool generating blank files (1.5.3), Theodore Tso, (Thu Sep 27, 6:23 pm)
Re: Mergetool generating blank files (1.5.3), Pierre Habouzit, (Thu Sep 27, 6:28 pm)
Re: Mergetool generating blank files (1.5.3), Peter Baumann, (Fri Sep 28, 1:15 am)
Re: Mergetool generating blank files (1.5.3), Pierre Habouzit, (Fri Sep 28, 2:35 am)