Re: Mergetool generating blank files (1.5.3)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Theodore Ts'o <tytso@...>
Cc: <git@...>, Kelvie Wong <kelvie@...>
Date: Thursday, September 27, 2007 - 5:41 pm

When mergetool is run from a subdirectory, "ls-files -u" nicely
limits the output to conflicted files in that directory, but
we need to give the full path to cat-file plumbing to grab the
contents of stages.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

 * I earlier sent one with cd_to_toplevel but I think the
   approach in this patch is nicer.

 git-mergetool.sh |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/git-mergetool.sh b/git-mergetool.sh
index a0e44f7..3b1ec13 100755
--- a/git-mergetool.sh
+++ b/git-mergetool.sh
@@ -12,6 +12,7 @@ USAGE='[--tool=tool] [file to merge] ...'
 SUBDIRECTORY_OK=Yes
 . git-sh-setup
 require_work_tree
+prefix=$(git rev-parse --show-prefix)
 
 # Returns true if the mode reflects a symlink
 is_symlink () {
@@ -162,9 +163,9 @@ merge_file () {
     local_mode=`git ls-files -u -- "$path" | awk '{if ($3==2) print $1;}'`
     remote_mode=`git ls-files -u -- "$path" | awk '{if ($3==3) print $1;}'`
 
-    base_present   && git cat-file blob ":1:$path" > "$BASE" 2>/dev/null
-    local_present  && git cat-file blob ":2:$path" > "$LOCAL" 2>/dev/null
-    remote_present && git cat-file blob ":3:$path" > "$REMOTE" 2>/dev/null
+    base_present   && git cat-file blob ":1:$prefix$path" >"$BASE" 2>/dev/null
+    local_present  && git cat-file blob ":2:$prefix$path" >"$LOCAL" 2>/dev/null
+    remote_present && git cat-file blob ":3:$prefix$path" >"$REMOTE" 2>/dev/null
 
     if test -z "$local_mode" -o -z "$remote_mode"; then
 	echo "Deleted merge conflict for '$path':"
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Mergetool generating blank files (1.5.3), Kelvie Wong, (Thu Sep 27, 2:31 pm)
Re: Mergetool generating blank files (1.5.3), Pierre Habouzit, (Thu Sep 27, 2:57 pm)
Re: Mergetool generating blank files (1.5.3), Kelvie Wong, (Thu Sep 27, 3:24 pm)
Re: Mergetool generating blank files (1.5.3), Junio C Hamano, (Thu Sep 27, 3:58 pm)
Re: Mergetool generating blank files (1.5.3), Kelvie Wong, (Thu Sep 27, 4:12 pm)
Re: Mergetool generating blank files (1.5.3), Junio C Hamano, (Thu Sep 27, 4:28 pm)
Re: Mergetool generating blank files (1.5.3), Kelvie Wong, (Thu Sep 27, 4:38 pm)
Re: Mergetool generating blank files (1.5.3), Junio C Hamano, (Thu Sep 27, 4:47 pm)
Re: Mergetool generating blank files (1.5.3), Junio C Hamano, (Thu Sep 27, 4:51 pm)
Re: Mergetool generating blank files (1.5.3), Kelvie Wong, (Thu Sep 27, 5:17 pm)
Re: Mergetool generating blank files (1.5.3), Kelvie Wong, (Thu Sep 27, 5:22 pm)
Re: Mergetool generating blank files (1.5.3), Junio C Hamano, (Thu Sep 27, 5:33 pm)
Re: Mergetool generating blank files (1.5.3), Junio C Hamano, (Thu Sep 27, 5:41 pm)
Re: Mergetool generating blank files (1.5.3), Theodore Tso, (Thu Sep 27, 6:35 pm)
Re: Mergetool generating blank files (1.5.3), Kelvie Wong, (Thu Sep 27, 6:23 pm)
Re: Mergetool generating blank files (1.5.3), Theodore Tso, (Thu Sep 27, 6:52 pm)
Re: Mergetool generating blank files (1.5.3), Kelvie Wong, (Fri Sep 28, 12:17 am)
Re: Mergetool generating blank files (1.5.3), David Kastrup, (Fri Sep 28, 2:19 am)
Re: Mergetool generating blank files (1.5.3), Jeff King, (Thu Sep 27, 3:12 pm)
Re: Mergetool generating blank files (1.5.3), Pierre Habouzit, (Thu Sep 27, 3:16 pm)
Re: Mergetool generating blank files (1.5.3), Jeff King, (Thu Sep 27, 3:41 pm)
Re: Mergetool generating blank files (1.5.3), Russ Brown, (Thu Sep 27, 3:00 pm)
Re: Mergetool generating blank files (1.5.3), Pierre Habouzit, (Thu Sep 27, 3:11 pm)
Re: Mergetool generating blank files (1.5.3), Theodore Tso, (Thu Sep 27, 6:23 pm)
Re: Mergetool generating blank files (1.5.3), Pierre Habouzit, (Thu Sep 27, 6:28 pm)
Re: Mergetool generating blank files (1.5.3), Peter Baumann, (Fri Sep 28, 1:15 am)
Re: Mergetool generating blank files (1.5.3), Pierre Habouzit, (Fri Sep 28, 2:35 am)