Re: Use of strbuf.buf when strbuf.len == 0

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Junio C Hamano <gitster@...>, <git@...>
Date: Thursday, September 27, 2007 - 7:37 am

On Thu, Sep 27, 2007 at 11:22:04AM +0000, Pierre Habouzit wrote:

  I find this ugly, so I've even checked if we did assume that, which is
easy now that such places all use strbuf_detach. One place seemed to,
but wasn't, so I patched it so that it's not the case anymore.

  All other places that use strbuf_detach don't use the fact that it can
return NULL to detect error cases, so we are safe.

--=20
=C2=B7O=C2=B7  Pierre Habouzit
=C2=B7=C2=B7O                                                madcoder@debia=
n.org
OOO                                                http://www.madism.org
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Use of strbuf.buf when strbuf.len == 0, Junio C Hamano, (Thu Sep 27, 2:21 am)
Re: Use of strbuf.buf when strbuf.len == 0, Pierre Habouzit, (Thu Sep 27, 7:22 am)
[PROPER PATCH 1/1] Make read_patch_file work on a strbuf., Pierre Habouzit, (Thu Sep 27, 7:33 am)
Re: Use of strbuf.buf when strbuf.len == 0, Pierre Habouzit, (Thu Sep 27, 7:37 am)
[PATCH 1/1] Make read_patch_file work on a strbuf., Pierre Habouzit, (Thu Sep 27, 7:33 am)
Re: Use of strbuf.buf when strbuf.len == 0, Pierre Habouzit, (Thu Sep 27, 6:13 am)
Re: Use of strbuf.buf when strbuf.len == 0, Linus Torvalds, (Fri Sep 28, 8:51 pm)
Re: Use of strbuf.buf when strbuf.len == 0, Pierre Habouzit, (Sat Sep 29, 3:48 am)
[PATCH 1/2] double free in builtin-update-index.c, Pierre Habouzit, (Thu Sep 27, 6:51 am)