Re: [PATCH] Supplant the "while case ... break ;; esac" idiom

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Johannes Schindelin <Johannes.Schindelin@...>

To: Miles Bader <miles@...>

Cc: Eygene Ryabinkin <rea-git@...>, Pierre Habouzit <madcoder@...>, <git@...>

Subject: Re: [PATCH] Supplant the "while case ... break ;; esac" idiom

Date: Monday, September 24, 2007 - 10:04 am

Hi,

On Mon, 24 Sep 2007, Miles Bader wrote:

quoted text> Eygene Ryabinkin <rea-git@codelabs.ru> writes:
> >> The comment "... holds only for a shell where [ is a builtin" doesn't
> >> make any sense to me
> >
> > The 'while case ...' construct does not invoke any external commands.
> > The 'while test ...' too, but only when 'test' is builtin.  When
> > 'test' is the external binary you get one additional fork/exec per
> > each cycle.
> 
> In practice that's not an issue though -- every reasonable shell has 
> test as a builtin these days, so the "works when test is not a builtin" 
> criteria is really important only for robustness.

AAAAAAAAAAAAAARRRRRGGGHHHHHHHHHHHH!

_Exactly_ the same reasoning can be said about the old code: _every_ 
reasonable shell can grok the code that used to be there!

<rhetoric-question>
	So what exactly was your point again?
</rhetoric-question>

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

Re: [PATCH] Supplant the "while case ... break ;; esac" idiom, David Kastrup, (Mon Sep 24, 3:57 am)

Re: [PATCH] Supplant the "while case ... break ;; esac" idiom, Pierre Habouzit, (Mon Sep 24, 4:01 am)

Re: [PATCH] Supplant the "while case ... break ;; esac" idiom, Pierre Habouzit, (Mon Sep 24, 4:04 am)

Re: [PATCH] Supplant the "while case ... break ;; esac" idiom, Johannes Schindelin, (Mon Sep 24, 6:33 am)

Re: [PATCH] Supplant the "while case ... break ;; esac" idiom, Miles Bader, (Mon Sep 24, 7:21 am)

Re: [PATCH] Supplant the "while case ... break ;; esac" idiom, Eygene Ryabinkin, (Mon Sep 24, 7:35 am)

Re: [PATCH] Supplant the "while case ... break ;; esac" idiom, Miles Bader, (Mon Sep 24, 9:45 am)

Re: [PATCH] Supplant the "while case ... break ;; esac" idiom, Johannes Schindelin, (Mon Sep 24, 10:04 am)

Re: [PATCH] Supplant the "while case ... break ;; esac" idiom, Junio C Hamano, (Mon Sep 24, 12:24 pm)

Re: [PATCH] Supplant the "while case ... break ;; esac" idiom, Miles Bader, (Mon Sep 24, 10:58 am)


linux-kernel:
Amit K. Arora	[RFC] Heads up on sys_fallocate()
Rafael J. Wysocki	2.6.27-rc4-git1: Reported regressions from 2.6.26
Dave Hansen	Re: [RFC/PATCH] Documentation of kernel messages
Bart Van Assche	Re: Integration of SCST in the mainstream Linux kernel
git:

linux-netdev:
Gerrit Renker	[PATCH 03/37] dccp: List management for new feature negotiation
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Corey Minyard	[PATCH 3/3] Convert the UDP hash lock to RCU
Tomas Winkler	[PATCH] iwlwifi: RS small compile warnings without CONFIG_IWLWIFI_DEBUG
openbsd-misc:

Re: [PATCH] Supplant the "while case ... break ;; esac" idiom

Online users