login
Header Space

 
 

Re: [PATCH 2/2] git-commit: Add --fast option

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Dmitry V. Levin <ldv@...>
Cc: Git Mailing List <git@...>, Junio C Hamano <gitster@...>
Date: Thursday, September 13, 2007 - 7:43 am

On Thu, Sep 13, 2007 at 02:56:58PM +0400, Dmitry V. Levin wrote:


That is already taken care of elsewhere (I think runstatus is
confusingly written -- it should really only set GIT_INDEX_FILE for the
git-runstatus subcommand. This is an artifact from when runstatus was
implemented completely in shell, and I should have cleaned it up during
that transition).

It's probably not worth cleaning up, though, if the shell version is
going away soon.


Yes, since you have already written the patch and it is fairly trivial,
I think it should be applied. I was trying to subtly hint that you
should make sure the feature makes it into the the new git-commit.

If you can provide a test case for git-runstatus segfaulting, I can help
look at it further.

-Peff
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/2] git-commit, Dmitry V. Levin, (Wed Sep 12, 7:42 pm)
[PATCH 2/2] git-commit: Add --fast option, Dmitry V. Levin, (Wed Sep 12, 7:47 pm)
Re: [PATCH 2/2] git-commit: Add --fast option, Jeff King, (Wed Sep 12, 10:37 pm)
Re: [PATCH 2/2] git-commit: Add --fast option, Dmitry V. Levin, (Thu Sep 13, 6:56 am)
Re: [PATCH 2/2] git-commit: Add --fast option, Jeff King, (Thu Sep 13, 7:43 am)
speck-geostationary