Re: [PATCH 12/13] Add bundle transport

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Johannes Schindelin <Johannes.Schindelin@...>
Cc: Junio C Hamano <junkio@...>, <git@...>
Date: Tuesday, September 11, 2007 - 1:30 pm

On Tue, Sep 11, 2007 at 04:26:14PM +0000, Johannes Schindelin wrote:
=20

  It has nothing to do with latest. I feel that if for some reason
transport_ops need a new function, it will break silentely, whereas if
you use:

 static const struct transport_ops bundle_transport =3D {
+	.set_option    =3D NULL,
+	.get_refs_list =3D &get_refs_from_bundle,
+	.fetch_refs    =3D &fetch_refs_from_bundle,
+	.fetch_objs    =3D NULL,
+	.push          =3D NULL,
+	.disconnect    =3D &close_bundle

  Or even:

 static const struct transport_ops bundle_transport =3D {
+	.get_refs_list =3D &get_refs_from_bundle,
+	.fetch_refs    =3D &fetch_refs_from_bundle,
+	.disconnect    =3D &close_bundle

  It's pretty straightforward to extend the transport_ops API, afaict
it's what the kernel does e.g.. I wasn't suggesting anything else.
--=20
=C2=B7O=C2=B7  Pierre Habouzit
=C2=B7=C2=B7O                                                madcoder@debia=
n.org
OOO                                                http://www.madism.org
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 12/13] Add bundle transport, Johannes Schindelin, (Mon Sep 10, 11:03 pm)
Re: [PATCH 12/13] Add bundle transport, Pierre Habouzit, (Tue Sep 11, 4:23 am)
Re: [PATCH 12/13] Add bundle transport, Johannes Schindelin, (Tue Sep 11, 12:26 pm)
Re: [PATCH 12/13] Add bundle transport, Pierre Habouzit, (Tue Sep 11, 1:30 pm)
Re: [PATCH 12/13] Add bundle transport, Nicolas Pitre, (Tue Sep 11, 2:09 pm)
Re: [PATCH 12/13] Add bundle transport, Johannes Schindelin, (Tue Sep 11, 1:55 pm)
Re: [PATCH 12/13] Add bundle transport, Linus Torvalds, (Tue Sep 11, 1:46 pm)