On Tue, Sep 11, 2007 at 04:26:14PM +0000, Johannes Schindelin wrote:
quoted text
> Hi,
>=20
> On Tue, 11 Sep 2007, Pierre Habouzit wrote:
>=20
> > On Tue, Sep 11, 2007 at 03:03:21AM +0000, Johannes Schindelin wrote:
> > >  static const struct transport_ops bundle_transport =3D {
> > > +	/* set_option */	NULL,
> > > +	/* get_refs_list */	get_refs_from_bundle,
> > > +	/* fetch_refs */	fetch_refs_from_bundle,
> > > +	/* fetch_objs */	NULL,
> > > +	/* push */		NULL,
> > > +	/* disconnect */	close_bundle
> >=20
> >   Not that I care that much, and I don't know what is done in git
> > usually. But aren't C99 initializer safer ? (wrt struct transport_ops
> > API possible changes in the future).
>=20
> No, they are not, since we do not allow such backwards incompatibilifiers=
=20
quoted text
> to creep into git's code.
>=20
> Yes, I know some would prefer the latest and greatest, and another=20
> language altogether, but keep this in mind: what if somebody made git=20
> incompatible with _your_ setup?  So really, don't do it to others that=20
> lightly.

  It has nothing to do with latest. I feel that if for some reason
transport_ops need a new function, it will break silentely, whereas if
you use:

 static const struct transport_ops bundle_transport =3D {
+	.set_option    =3D NULL,
+	.get_refs_list =3D &get_refs_from_bundle,
+	.fetch_refs    =3D &fetch_refs_from_bundle,
+	.fetch_objs    =3D NULL,
+	.push          =3D NULL,
+	.disconnect    =3D &close_bundle

  Or even:

 static const struct transport_ops bundle_transport =3D {
+	.get_refs_list =3D &get_refs_from_bundle,
+	.fetch_refs    =3D &fetch_refs_from_bundle,
+	.disconnect    =3D &close_bundle

  It's pretty straightforward to extend the transport_ops API, afaict
it's what the kernel does e.g.. I wasn't suggesting anything else.
--=20
=C2=B7O=C2=B7  Pierre Habouzit
=C2=B7=C2=B7O                                                madcoder@debia=
n.org
OOO                                                http://www.madism.org