Home » Mailing list archives » git » 2007 » September » 11

Re: [PATCH 01-13/13] builtin-fetch series.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Junio C Hamano <gitster@...>
To: Daniel Barkalow <barkalow@...>
Cc: <git@...>
Subject: Re: [PATCH 01-13/13] builtin-fetch series.
Date: Tuesday, September 11, 2007 - 3:03 am

Very impressed by the entire series and mildly amused.  Thanks.

A few C++ style comments sprinkled here and there were eyesore,
but I'll hopefully survive.

You seem to have a stray printf("connect to ...\n"); as the
command is expected to show the list of refs it fetched from the
other side, this may interfere with what the caller wants to do.

The changes to t5515 test vectors worry me quite a lot, as the
distinction between not-for-merge and others is what decides the
outcome of a pull, but I didn't look very closely.

Unfortunately I do not have enough time for a full review during
the workday evenings.  Hopefully will take a deper look on my
next git day.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 01/13] Refactor http.h USE_CURL_MULTI fill_active_slo..., Daniel Barkalow, (Mon Sep 10, 11:02 pm)
Re: [PATCH 01-13/13] builtin-fetch series., Junio C Hamano, (Tue Sep 11, 3:03 am)
Re: [PATCH 01-13/13] builtin-fetch series., Daniel Barkalow, (Tue Sep 11, 11:27 am)