login
Header Space

 
 

Re: question about git-submodule

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <skimo@...>
Cc: Alex Riesen <raa.lkml@...>, VMiklos <vmiklos@...>, <git@...>
Date: Monday, August 6, 2007 - 1:23 pm

On 2007-08-05 10:59, Sven Verdoolaege wrote:

If you just do "git add sub" (where sub is an existing repo subdir) then
any subsequent "git submodule update" predictably complains:
  No submodule mapping found in .gitmodules for path 'sub'

And if you wire up .gitmodules manually, then "git submodule update"
chokes on the "git-fetch" in modules_update().

So I suggest extending "git submodule add" to handle existing
subdirectories by simply using them as-is instead of creating a new
clone. And "git submodule update" shouldn't try fetching when the commit
is already present locally.

Speaking of which, currently "git submodule" clones/fetches *all*
branches on the remote repository, which seems quite excessive given
that the supermodule's content references just one submodule commit. By
default, "git submodule add" should fetch only the needed head, and "git
submodule update" should fetch only the commit sha1 (if needed).

  Eran
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
question about git-submodule, VMiklos, (Fri Jul 13, 5:46 pm)
Re: question about git-submodule, Sven Verdoolaege, (Sun Jul 15, 4:39 am)
Re: question about git-submodule, Alex Riesen, (Sun Jul 15, 6:47 am)
Re: question about git-submodule, Eran Tromer, (Fri Aug 3, 7:01 pm)
Re: question about git-submodule, Sven Verdoolaege, (Sun Aug 5, 10:59 am)
Re: question about git-submodule, Eran Tromer, (Mon Aug 6, 1:23 pm)
Re: question about git-submodule, Sven Verdoolaege, (Sun Jul 15, 7:51 am)
Re: question about git-submodule, Alex Riesen, (Sun Jul 15, 9:42 am)
Re: question about git-submodule, Sven Verdoolaege, (Sun Jul 15, 9:52 am)
Re: question about git-submodule, VMiklos, (Sun Jul 15, 6:54 am)
Re: question about git-submodule, Alex Riesen, (Sun Jul 15, 9:50 am)
Re: question about git-submodule, VMiklos, (Sun Jul 15, 9:54 am)
Re: question about git-submodule, Sven Verdoolaege, (Sun Jul 15, 10:02 am)
Re: question about git-submodule, VMiklos, (Sun Jul 15, 10:26 am)
Re: question about git-submodule, Sven Verdoolaege, (Sun Jul 15, 10:48 am)
Re: question about git-submodule, VMiklos, (Sun Jul 15, 11:05 am)
Re: question about git-submodule, Sven Verdoolaege, (Sun Jul 15, 11:21 am)
Re: question about git-submodule, VMiklos, (Sun Jul 15, 11:40 am)
Re: question about git-submodule, Sven Verdoolaege, (Sun Jul 15, 5:45 pm)
Re: question about git-submodule, VMiklos, (Sun Jul 15, 6:29 pm)
Re: question about git-submodule, Sven Verdoolaege, (Mon Jul 16, 6:39 am)
Re: question about git-submodule, VMiklos, (Mon Jul 16, 7:07 am)
speck-geostationary