login
Header Space

 
 

Re: Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d)

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Eric Wong <normalperson@...>
Cc: Junio C Hamano <gitster@...>, <git@...>
Date: Friday, August 31, 2007 - 11:31 am

The difference between the version I'm using (1.5.2.4) and this broken
version shows us what's happened. The $hash value was initialised in
the loop, and now it isn't.

Running 'git-svn log' in my git-svn'ed repo shows this up every time,
it's easy to reproduce.

        my ($head, $refs) = @_;
-       my ($fh, $ctx) = command_output_pipe('rev-list', $head);
-       while (my $hash = <$fh>) {
-               chomp($hash);
-               my ($url, $rev, $uuid) = cmt_metadata($hash);
+       my ($fh, $ctx) = command_output_pipe('log', $head);
+       my $hash = "";
+       my %max;
+       while (<$fh>) {
+               if ( m{^commit ($::sha1)$} ) {
+                       unshift @$refs, $hash if $hash and $refs;
+                       $hash = $1;
+                       next;
+               }
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d), Robert Newson, (Fri Aug 31, 8:58 am)
Re: Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d), Junio C Hamano, (Fri Aug 31, 10:52 am)
Re: Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d), Junio C Hamano, (Fri Aug 31, 4:50 pm)
git-svn: Protect against "diff.color = true"., Junio C Hamano, (Fri Aug 31, 5:29 pm)
Re: git-svn: Protect against "diff.color = true"., Eric Wong, (Fri Aug 31, 5:58 pm)
Re: git-svn: Protect against "diff.color = true"., Johannes Schindelin, (Fri Aug 31, 5:38 pm)
Re: git-svn: Protect against "diff.color = true"., Junio C Hamano, (Fri Aug 31, 5:46 pm)
Re: git-svn: Protect against "diff.color = true"., Johannes Schindelin, (Fri Aug 31, 5:53 pm)
Re: git-svn: Protect against "diff.color = true"., Junio C Hamano, (Fri Aug 31, 6:14 pm)
Re: Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d), Junio C Hamano, (Fri Aug 31, 5:22 pm)
Re: Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d), Johannes Schindelin, (Fri Aug 31, 7:51 pm)
Re: Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d), Junio C Hamano, (Fri Aug 31, 12:09 pm)
Re: Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d), Robert Newson, (Fri Aug 31, 12:18 pm)
Re: Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d), Robert Newson, (Fri Aug 31, 12:25 pm)
Re: Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d), Robert Newson, (Fri Aug 31, 12:25 pm)
Re: Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d), Robert Newson, (Fri Aug 31, 11:31 am)
speck-geostationary