Re: EDITOR with tilde not expanded in git-commit

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Matthieu Moy
Date: Tuesday, August 28, 2007 - 9:11 am

merlyn@stonehenge.com (Randal L. Schwartz) writes:


Yes. That's a good reason not to use system() on hardcoded values. I
wouldn't write the line of code above in a real-life program. But
here, the argument of system() comes from the user-configuration. If
he's running on a machine whose shell does tilde expansion, he can use
tilde-expansion in his configuration. On windows, I believe system()
has some windows-specific things, but the user probably expects to be
able to use them if he runs windows.

-- 
Matthieu
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
EDITOR with tilde not expanded in git-commit, Bill Lear, (Tue Aug 28, 7:12 am)
Re: EDITOR with tilde not expanded in git-commit, Nguyen Thai Ngoc Duy, (Tue Aug 28, 7:37 am)
Re: EDITOR with tilde not expanded in git-commit, Bill Lear, (Tue Aug 28, 7:44 am)
Re: EDITOR with tilde not expanded in git-commit, Mike Hommey, (Tue Aug 28, 7:52 am)
Re: EDITOR with tilde not expanded in git-commit, Petr Baudis, (Tue Aug 28, 7:58 am)
Re: EDITOR with tilde not expanded in git-commit, Mike Hommey, (Tue Aug 28, 8:03 am)
Re: EDITOR with tilde not expanded in git-commit, Randal L. Schwartz, (Tue Aug 28, 8:16 am)
Re: EDITOR with tilde not expanded in git-commit, Bill Lear, (Tue Aug 28, 8:17 am)
Re: EDITOR with tilde not expanded in git-commit, Mike Hommey, (Tue Aug 28, 8:20 am)
Re: EDITOR with tilde not expanded in git-commit, Kyle Rose, (Tue Aug 28, 8:22 am)
Re: EDITOR with tilde not expanded in git-commit, Petr Baudis, (Tue Aug 28, 8:24 am)
Re: EDITOR with tilde not expanded in git-commit, Bill Lear, (Tue Aug 28, 8:24 am)
Re: EDITOR with tilde not expanded in git-commit, Mike Hommey, (Tue Aug 28, 8:25 am)
Re: EDITOR with tilde not expanded in git-commit, Petr Baudis, (Tue Aug 28, 8:27 am)
Re: EDITOR with tilde not expanded in git-commit, Bill Lear, (Tue Aug 28, 8:28 am)
Re: EDITOR with tilde not expanded in git-commit, Matthieu Moy, (Tue Aug 28, 8:50 am)
Re: EDITOR with tilde not expanded in git-commit, Matthieu Moy, (Tue Aug 28, 8:58 am)
Re: EDITOR with tilde not expanded in git-commit, Randal L. Schwartz, (Tue Aug 28, 9:00 am)
Re: EDITOR with tilde not expanded in git-commit, Matthieu Moy, (Tue Aug 28, 9:11 am)
Re: EDITOR with tilde not expanded in git-commit, Alex Riesen, (Tue Aug 28, 10:47 am)
Re: EDITOR with tilde not expanded in git-commit, Kyle Rose, (Tue Aug 28, 10:52 am)