Re: EDITOR with tilde not expanded in git-commit

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Randal L. Schwartz
Date: Tuesday, August 28, 2007 - 8:55 am

>>>>> "Bill" == Bill Lear <rael@zopyra.com> writes:

Bill> I was told eval was "wrong on multiple levels".

I should elaborate.

Using "eval" here means that you *then* have to be careful about whitespace
quoting.  For example, if my $HOME had a space in it,
EDITOR="$HOME/bin/superemacs" would be broken if you add the extra eval, since
the whitespace would be treated as a delimeter on the second lexing.  I'd have
to figure out how to set EDITOR with the right quotes or backwhacks in it to
undo the effect of your eval.

Also, eval treats data as code, and if for some reason this should end up in a
setuid environment (perhaps as a web application), eval would generate a
trivially accessed gigantic security hole.

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: EDITOR with tilde not expanded in git-commit, David Kastrup, (Tue Aug 28, 8:25 am)
Re: EDITOR with tilde not expanded in git-commit, Bill Lear, (Tue Aug 28, 8:36 am)
Re: EDITOR with tilde not expanded in git-commit, Randal L. Schwartz, (Tue Aug 28, 8:55 am)
Re: EDITOR with tilde not expanded in git-commit, Matthieu Moy, (Tue Aug 28, 9:05 am)
Re: EDITOR with tilde not expanded in git-commit, Johannes Schindelin, (Tue Aug 28, 2:01 pm)
Re: EDITOR with tilde not expanded in git-commit, David Kastrup, (Tue Aug 28, 2:55 pm)
Re: EDITOR with tilde not expanded in git-commit, Junio C Hamano, (Tue Aug 28, 2:56 pm)
Re: EDITOR with tilde not expanded in git-commit, Thomas Adam, (Tue Aug 28, 2:59 pm)
Re: EDITOR with tilde not expanded in git-commit, David Kastrup, (Tue Aug 28, 3:07 pm)
Re: EDITOR with tilde not expanded in git-commit, David Kastrup, (Tue Aug 28, 3:22 pm)
Re: EDITOR with tilde not expanded in git-commit, Junio C Hamano, (Tue Aug 28, 4:46 pm)
Re: EDITOR with tilde not expanded in git-commit, David Kastrup, (Tue Aug 28, 10:41 pm)