EDITOR with tilde not expanded in git-commit

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Bill Lear
Date: Tuesday, August 28, 2007 - 7:12 am

My co-worker is visually impaired, and he uses a custom emacs.  His
EDITOR is set to something like "~/bin/xemacs -nw".  When git-commit
runs, it complains:

% git-commit
git-commit: line 582: ~/bin/xemacs -nw: No such file or directory

So, I fiddled with the following line in git-commit:

        ${VISUAL:-${EDITOR:-vi}} "$GIT_DIR/COMMIT_EDITMSG"

and changed it to:

        eval ${VISUAL:-${EDITOR:-vi}} "$GIT_DIR/COMMIT_EDITMSG"

and it seems to work as I would expect in this case.

Is this a reasonable fix?


Bill
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
EDITOR with tilde not expanded in git-commit, Bill Lear, (Tue Aug 28, 7:12 am)
Re: EDITOR with tilde not expanded in git-commit, Nguyen Thai Ngoc Duy, (Tue Aug 28, 7:37 am)
Re: EDITOR with tilde not expanded in git-commit, Bill Lear, (Tue Aug 28, 7:44 am)
Re: EDITOR with tilde not expanded in git-commit, Mike Hommey, (Tue Aug 28, 7:52 am)
Re: EDITOR with tilde not expanded in git-commit, Petr Baudis, (Tue Aug 28, 7:58 am)
Re: EDITOR with tilde not expanded in git-commit, Mike Hommey, (Tue Aug 28, 8:03 am)
Re: EDITOR with tilde not expanded in git-commit, Randal L. Schwartz, (Tue Aug 28, 8:16 am)
Re: EDITOR with tilde not expanded in git-commit, Bill Lear, (Tue Aug 28, 8:17 am)
Re: EDITOR with tilde not expanded in git-commit, Mike Hommey, (Tue Aug 28, 8:20 am)
Re: EDITOR with tilde not expanded in git-commit, Kyle Rose, (Tue Aug 28, 8:22 am)
Re: EDITOR with tilde not expanded in git-commit, Petr Baudis, (Tue Aug 28, 8:24 am)
Re: EDITOR with tilde not expanded in git-commit, Bill Lear, (Tue Aug 28, 8:24 am)
Re: EDITOR with tilde not expanded in git-commit, Mike Hommey, (Tue Aug 28, 8:25 am)
Re: EDITOR with tilde not expanded in git-commit, Petr Baudis, (Tue Aug 28, 8:27 am)
Re: EDITOR with tilde not expanded in git-commit, Bill Lear, (Tue Aug 28, 8:28 am)
Re: EDITOR with tilde not expanded in git-commit, Matthieu Moy, (Tue Aug 28, 8:50 am)
Re: EDITOR with tilde not expanded in git-commit, Matthieu Moy, (Tue Aug 28, 8:58 am)
Re: EDITOR with tilde not expanded in git-commit, Randal L. Schwartz, (Tue Aug 28, 9:00 am)
Re: EDITOR with tilde not expanded in git-commit, Matthieu Moy, (Tue Aug 28, 9:11 am)
Re: EDITOR with tilde not expanded in git-commit, Alex Riesen, (Tue Aug 28, 10:47 am)
Re: EDITOR with tilde not expanded in git-commit, Kyle Rose, (Tue Aug 28, 10:52 am)