On Tue, Aug 28, 2007 at 10:15:01AM +0100, Johannes Schindelin wrote:Yes, I considered making it dynamic, which would probably end up saving quite a bit of memory (since most commits use many fewer than 32) I think 32 is a reasonable limit in general, since at some point, do you really want to see that many merge traversals in the resulting name? Let's say we allocate dynamically. The average per-commit number of stored merge traversals for linux-2.6 is 1.79. Each traversal is 5 bytes (though I think we could easily drop it to 3 or 4 -- do we expect generation counters larger 1.7 million?), for an average of 10 bytes stored per commit. Now compare that to the fact that we no longer need to strdup the tip_name. "tags/v2.6.22-rc1~1686^2~1" is _25_ bytes. So it's a net win (though not with a static array, obviously). I am all for making a trade-off if there is a reason. But if memory usage is your only concern, I think we can have our cake and eat it too. -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
| Linus Torvalds | Re: [GIT]: Networking |
| Mark Lord | Re: [Bug #10391] 2.6.25-rc7/8: Another resume regression |
| David Miller | Slow DOWN, please!!! |
| James Bottomley | [Ksummit-2008-discuss] Fixing the Kernel Janitors project |
git: | |
| Ittay Dror | detecting rename->commit->modify->commit |
| Peter Stahlir | Git as a filesystem |
| Junio C Hamano | [ANNOUNCE] GIT 1.5.4 |
| Andreas Hildebrandt | CVS-$Id:$ replacement in git? |
| Gilles Chehade | Re: Real men don't attack straw men |
| carlopmart | About Xen: maybe a reiterative question but .. |
| Christophe Rioux | OpenBSD as host for VMWare Server |
| Kevin Neff | Patching a SSH 'Weakness' |
| David Miller | Re: [BUG] New Kernel Bugs |
| Pavel Emelyanov | [PATCH 4/5] Mark the setup_net as __net_init |
| Chris Snook | [PATCH 0/4] atlx: add atl2 support |
| Jeff Garzik | Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator |
| high memory | 4 hours ago | Linux kernel |
| semaphore access speed | 7 hours ago | Applications and Utilities |
| the kernel how to power off the machine | 8 hours ago | Linux kernel |
| Easter Eggs in windows XP | 11 hours ago | Windows |
| Shared swap partition | 12 hours ago | Linux general |
| Root password | 12 hours ago | Linux general |
| Where/when DNOTIFY is used? | 14 hours ago | Linux kernel |
| How to convert Linux Kernel built-in module into a loadable module | 16 hours ago | Linux kernel |
| Linux 2.6.24 and I/O schedulers | 17 hours ago | Linux kernel |
| USB Driver -- Interrupt Polling -- A Little Help Please | 22 hours ago | Linux general |
