Home » Mailing list archives » git » 2007 » August » 11

Re: [PATCH v2] git-diff: Output a warning about stale files in the index

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Junio C Hamano <gitster@...>
To: Steven Grimm <koreth@...>
Cc: <git@...>
Subject: Re: [PATCH v2] git-diff: Output a warning about stale files in the index
Date: Saturday, August 11, 2007 - 4:07 pm

Actually this is wrong in two points:

 * The filtering should be done upfront at the beginning of the
   diffcore_std(), not before the end.  Otherwise, unchanged but
   cache dirty file could be subject to copy detection.

 * I do not think it should affect the low-level git-diff-* (or
   you should update the tests, documentations and perhaps
   whatever people can find from google).

By the way, I had an updated version of my patch to fix the
first point on 'pu' for a while.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Re: [PATCH v2] git-diff: Output a warning about stale files ..., Junio C Hamano, (Sat Aug 11, 4:07 pm)