Re: [PATCH 2/2] diff: add custom regular expressions for function names

view
thread

Score:

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Junio C Hamano <gitster@...>

To: Linus Torvalds <torvalds@...>

Cc: Johannes Schindelin <Johannes.Schindelin@...>, <git@...>, <gitster@...>

Subject: Re: [PATCH 2/2] diff: add custom regular expressions for function names

Date: Wednesday, July 4, 2007 - 4:44 pm

Linus Torvalds <torvalds@linux-foundation.org> writes:

quoted text> On Wed, 4 Jul 2007, Johannes Schindelin wrote:
>> 
>> This patch introduces a config variable diff.functionNameRegexp
>> which replaces the default heuristics.  If the pattern contains
>> a group, the match of this group is used for the hunk header
>> instead of the whole match.
>
> Umm. Shouldn't it be a path-name based attribute instead?
>
> That way you can set it to be different things for different source files 
> in the same repository.. IOW, think mixed Java/C codebases.

Absolutely.  I'll take it from there.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 2/2] diff: add custom regular expressions for functio..., Johannes Schindelin, (Wed Jul 4, 2:06 pm)

Re: [PATCH 2/2] diff: add custom regular expressions for fun..., Linus Torvalds, (Wed Jul 4, 2:41 pm)

Re: [PATCH 2/2] diff: add custom regular expressions for fun..., Junio C Hamano, (Wed Jul 4, 4:44 pm)

Re: [PATCH 2/2] diff: add custom regular expressions for fun..., Junio C Hamano, (Thu Jul 5, 1:00 am)

Re: [PATCH 2/2] diff: add custom regular expressions for fun..., Johannes Schindelin, (Thu Jul 5, 7:44 am)

Re: [PATCH 2/2] diff: add custom regular expressions for fun..., Florian Weimer, (Thu Jul 5, 4:24 am)

[PATCH 2/2] WIP per-path attribute based hunk header selecti..., Junio C Hamano, (Thu Jul 5, 1:02 am)

Re: [PATCH 2/2] WIP per-path attribute based hunk header sel..., Johannes Schindelin, (Thu Jul 5, 7:25 am)

[PATCH] Per-path attribute based hunk header selection., Junio C Hamano, (Fri Jul 6, 4:39 am)

Re: [PATCH] Per-path attribute based hunk header selection., Linus Torvalds, (Fri Jul 6, 1:59 pm)

Re: [PATCH] Per-path attribute based hunk header selection., Junio C Hamano, (Fri Jul 6, 10:00 pm)

Re: [PATCH] Per-path attribute based hunk header selection., Nicolas Pitre, (Sun Jul 8, 11:22 pm)

Re: [PATCH] Per-path attribute based hunk header selection., Junio C Hamano, (Mon Jul 9, 1:05 am)

Re: [PATCH] Per-path attribute based hunk header selection., Johannes Schindelin, (Mon Jul 9, 7:40 am)

Re: [PATCH] Per-path attribute based hunk header selection., , (Sat Jul 7, 6:08 am)

Re: [PATCH] Per-path attribute based hunk header selection., Junio C Hamano, (Sat Jul 7, 6:22 am)

Re: [PATCH] Per-path attribute based hunk header selection., Johannes Schindelin, (Sat Jul 7, 8:17 am)

Re: [PATCH] Per-path attribute based hunk header selection., Junio C Hamano, (Sun Jul 8, 3:23 am)

Re: [PATCH] Per-path attribute based hunk header selection., Johannes Schindelin, (Sun Jul 8, 7:58 am)

Re: [PATCH] Per-path attribute based hunk header selection., Junio C Hamano, (Sat Jul 7, 4:36 pm)

Re: [PATCH] Per-path attribute based hunk header selection., Johannes Schindelin, (Fri Jul 6, 8:38 am)

[PATCH 1/3] Introduce diff_filespec_is_binary(), Junio C Hamano, (Fri Jul 6, 4:37 am)

Re: [PATCH 1/3] Introduce diff_filespec_is_binary(), Johannes Schindelin, (Fri Jul 6, 8:20 am)

Re: [PATCH 2/2] WIP per-path attribute based hunk header sel..., Junio C Hamano, (Thu Jul 5, 12:43 pm)

[PATCH 1/2] Future-proof source for changes in xdemitconf_t, Junio C Hamano, (Thu Jul 5, 1:02 am)

Re: [PATCH 1/2] Future-proof source for changes in xdemitcon..., Johannes Schindelin, (Thu Jul 5, 7:01 am)

Re: [PATCH 2/2] diff: add custom regular expressions for fun..., Johannes Schindelin, (Wed Jul 4, 5:20 pm)

Re: [PATCH 2/2] diff: add custom regular expressions for fun..., Johannes Schindelin, (Wed Jul 4, 2:45 pm)

Navigation

Mail archive search

Popular discussions


linux-kernel:
Jan Kundrát	kswapd high CPU usage with no swap
Renato S. Yamane	Error -71 on device descriptor read/all
Linus Torvalds	Linux 2.6.27-rc8
Alex Chiang	[PATCH 0/7] Fixups for duplicate slot names
git:
Peter Karlsson	RCS keyword expansion
Wink Saville	Resolving conflicts
Andreas Hildebrandt	CVS-$Id:$ replacement in git?
Olivier Marin	[PATCH] builtin-rerere: fix conflict markers parsing
openbsd-misc:
GVG GVG	ssh_exchange_identification: Connection closed by remote host
Felipe Alfaro Solana	quagga-0.99.11
Pc Nicolas	OpenBSD 4.4 httpd reverse proxy
Martin Schröder	pkg_add with http?
linux-netdev:
Evgeniy Polyakov	[resend take 2 4/4] DST Makefile/Kconfig files.
Volker Armin Hemmann	build error with 2.6.27.6+reiser4+ehci-hub patch. ERROR: "mii_ethtool_gset" [drive...
Krzysztof Oledzki	Re: Error: an inet prefix is expected rather than "0/0".
David Madore	atl1e Ethernet driver not seeing packets sent to 33:33:00:00:00:01 multicast

Latest forum posts


Block Sub System query	1 hour ago	Linux kernel
kernel module to intercept socket creation	2 hours ago	Linux kernel
Image size changing during each build	3 hours ago	Linux kernel
Soft lock bug	7 hours ago	Linux kernel
sysctl - dynamic registration problem	14 hours ago	Linux kernel
Question on swap as ramdisk partition	16 hours ago	Linux kernel
serial driver xmit problem	21 hours ago	Linux kernel
Generic Netlink subsytem	21 hours ago	Linux kernel
'Report spam filter error' page broken	23 hours ago	KernelTrap Suggestions and Feedback
Netfilter kernel module	1 day ago	Linux kernel

Show all forums...

Recent Tags

more tags

Colocation donated by:

Online users

Syndicate