Hi,

On Wed, 4 Jul 2007, Johannes Sixt wrote:

quoted text
> Johannes Schindelin wrote:
> > 
> > On Wed, 4 Jul 2007, Johannes Sixt wrote:
> > 
> > > -     test -r "$workdir/../map/" || echo ""
> > > -     cat "$workdir/../map/"
> > > +     test -r "$workdir/../map/" &&
> > > +     cat "$workdir/../map/" ||
> > > +     echo ""
> > 
> > I think this does not do what you want. If I read it correctly, it will
> > not do anything if $workdir/../map/ is not readable. I think you need
> > this:
> > 
> >         (test -r "$workdir/../map/" &&
> >         cat "$workdir/../map/") ||
> >         echo ""
> > 
> > But that is a little too cute, so I personally would prefer an
> > if-then-else-fi, because that is the idea of that code snippet.
> 
> It does do what I think it should do. I tested it.

Okay. But take me as an example of an average programmer. I got confused. 
Therefore I would greatly appreciate it, if it were written with 
if-then-else-fi, because I get less confused then.

Thanks,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html