git mailing list

FromSubjectsort iconDate
Benjamin Sergeant
http git clone memory problem.
- Sorry for the noise if this has already been reported. - It's on a Mandriva Spring machine with git 1.5.0.4 - It's a glibc detected memory error. If I restart with MALLOC_CHECK_=0 I dont' get the crash. [bsergean@marge1 src]$ git --version git version 1.5.0.4 [bsergean@marge1 src]$ git clone http://www.kernel.org/pub/scm/git/git.git Initialized empty Git repository in /home/bsergean/src/git/.git/ got de9879a91fd7d4d123a303b4bcdc918f43ca3a62 walk de9879a91fd7d4d123a303b4bcdc918f43ca3a62 got ...
Jul 23, 11:44 pm 2007
Junio C Hamano
Re: [PATCH] Fix problematic ']'
Maybe that would have been a better idea. -
Jul 23, 10:01 pm 2007
Johannes Schindelin
[PATCH] rebase -i: exchange all "if [ .. ]" by "if test .."
in vi, after making sure that the other instances of "[..]" are not actually invocations of "test". Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- On Mon, 23 Jul 2007, Junio C Hamano wrote: > Johannes Sixt <johannes.sixt@telecom.at> writes: > > > Not all shells grok a closing ']' of the shell '[' command without > > surrounding space. > > > > Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at> > > --...
Jul 23, 10:18 pm 2007
Johannes Schindelin
[PATCH] mailinfo: fix 'fatal: cannot convert from utf-8 to u...
For some reason, I got this error message. Maybe it does not make sense, but then we should not really try to convert the text when it is not necessary. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- This bit me when I tried to apply the most recent Japanese translation patch to git-gui-i18n. builtin-mailinfo.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/builtin-mailinfo.c b/builtin-mailinfo.c index a37a4ff..b4f6e91 100644 ---...
Jul 23, 8:03 pm 2007
Johannes Schindelin
[PATCH] git am: skip pine's internal folder data
Test if the From: line contains "Mail System Internal Data" and if it is, skip this mail. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- git-am.sh | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/git-am.sh b/git-am.sh index bfd65dc..22d2b5c 100755 --- a/git-am.sh +++ b/git-am.sh @@ -284,6 +284,12 @@ do git mailinfo $keep $utf8 "$dotest/msg" "$dotest/patch" \ <"$dotest/$msgnum" >"$dotest/info" || stop_here $this + +...
Jul 23, 8:02 pm 2007
Johannes Schindelin
Re: update-po
Hi, Thanks, both. Ciao, Dscho
Jul 23, 7:44 pm 2007
Johannes Schindelin
[PATCH] git log -g: Complain, but do not fail, when no reflo...
When asking "git log -g --all", clearly you want to see only those refs that do have reflogs, but you do not want it to fail, either. So instead of die()ing, complain about it, but move on to the other refs. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- reflog-walk.c | 7 ++++--- reflog-walk.h | 2 +- revision.c | 7 ++++--- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/reflog-walk.c b/reflog-walk.c index c983858..7809fad 100644 ---...
Jul 23, 7:39 pm 2007
Robin Rosenberg
git log and --first-parent
I'm puzzled over the behavior of --first-parent. The documentations seems to imply that only the first parent is followed, but when a filter is applied it seems (just guessing) that the "first" parent is selected *after* filtering, a behaviour that I feel does not match the documentation. Should the first-parent filter be applied first. Example: git log --first-parent --pretty=format: --name-only v1.5.2|grep ^var.c|wc -l counts four commits where var.c was changed, while git log --firs...
Jul 23, 7:05 pm 2007
Uwe
when git-rebase -i fails to cherry-pick
Hello, even though git-rebase -i is still young, I'm already a big fan of it. I just want to suggest two minor things: - If a cherry-pick fails, it tells me to resolve my conflicts, 'git add <paths>' and to do 'git commit -c $sha1id'. But it doesn't tell me, how I continue to rebase after that. 'git rebase -i --continue' works. - If a cherry-pick of a commit to be squashed fails, the instruction to do 'git commit -c $sha1id' is wrong, because then I don't get both messag...
Jul 23, 6:54 pm 2007
Johannes Schindelin
Re: when git-rebase -i fails to cherry-pick
Hi, Actually, even "git rebase --continue" works. And you do not really have to commit, either, just updating your index is fine. In fact, if you say Yes, it is a leftover from the bad old days, when this script was called edit-patch-series, and I was a rebase hater. In the meantime, somebody on IRC explained to me how rebase works, and that rebase lovers were quite annoyed not to be able to just resolve the conflicts and "git rebase --continue". I'd appreciate if you prepared a p...
Jul 23, 7:08 pm 2007
Jakub Narebski
Re: [RFC PATCH] Re: Empty directories...
Not true. You can add custom diff driver for files using gitattributes xdiff has binary diff, and git has some kind of "ascii-armored" binary diff output. As to how to merge binary files: I suspect that they always conflict, unless the merge is trivial. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git -
Jul 23, 6:52 pm 2007
Johannes Schindelin
[PATCH] Shut "git rebase -i" up when no --verbose was given
Up to now, git rebase -i was quite chatty, showing through all the nice core programs it called. Now it only shows a progress meter by default. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- git-rebase--interactive.sh | 50 +++++++++++++++++++++++++++++-------------- 1 files changed, 34 insertions(+), 16 deletions(-) diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index 579a45e..ac1f5a2 100755 --- a/git-rebase--interactive.sh +++ b/git-reb...
Jul 23, 6:45 pm 2007
Brett Schwarz
Re: [PATCH] Mark many more strings for i18n.
I not sure if it's worth changing, but you don't necessarily need those [append]'s in there. For example: error_popup [append [mc "Cannot parse Git version string:"] "\n\n$_git_version"] is the same as: error_popup "[mc "Cannot parse Git version string:"]\n\n$_git_version" Again, not sure if it's worth changing the patch, but maybe for future reference. --brett ----- Original Message ---- From: Christian Stimming <stimming@tuhh.de> To: Brett Schwarz <brett_schwa...
Jul 23, 5:10 pm 2007
Peter Oberndorfer
[QGIT4 PATCH 0/6] Some UI Improvements
Hi, the initial reason for this patches is that here on my system qgit4 looks like this http://img77.imageshack.us/my.php?image=qgit4strangewindowgi0.png which is a bit suboptimal for viewing patches :-) this is on a standard qt 4.3 from gentoo While i was there i removed the same problem in the custom action editor and removed some unneed empty space Actually locally i removed even more empty space, like around the main tab view and inside the main tab view. If anyone wants me to remove that t...
Jul 23, 4:32 pm 2007
Marco Costalba
Re: [QGIT4 PATCH 0/6] Some UI Improvements
Hi Peter, OMG that's horrific! I can't understand how it is possible, on my box (Mandriva with QT4.3) everything is fine. Anyway thanks a lot for the patches. Already applied and pushed. > If anyone wants me to remove that too, i would be happy to send more patches Please feel free to send me any patch that could improve the GUI, unfortunately on my box I'm unable to see all these defects, so any Patchview has not changed for me with your patches, fileview yes, I can see the differen...
Jul 23, 6:13 pm 2007
Peter Oberndorfer
Re: [QGIT4 PATCH 0/6] Some UI Improvements
hmm, kmail moved Signed-off-by in patches to mail headers, because there was no message text before it. so here is a Signed-off-by: Peter Oberndorfer <kumbayo84@arcor.de> for all my qgit patches Greetings Peter -
Jul 23, 4:52 pm 2007
Johannes Sixt
[PATCH] Fix problematic ']'
Not all shells grok a closing ']' of the shell '[' command without surrounding space. Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at> --- I didn't go the long way to change all `[ ... ]` into `test ...` git-rebase--interactive.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index 579a45e..e0d1326 100755 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@ -385,7 +385,7 @@ do ...
Jul 23, 4:36 pm 2007
Timo Hirvonen
Re: [PATCH] Fix problematic ']'
That's one good reason to use test instead of /usr/bin/[ hack (yes it has been a shell built-in for a long time). [ is just like test but expects ] as last parameter and ignores it. Very ugly IMO. -- http://onion.dynserv.net/~timo/ -
Jul 23, 4:58 pm 2007
Johannes Schindelin
Re: [PATCH] Fix problematic ']'
Hi, Darn. Thanks for cleaning up behind me, Dscho -
Jul 23, 4:51 pm 2007
Christian Stimming
[PATCH] Mark many more strings for i18n.
Signed-off-by: Christian Stimming <stimming@tuhh.de> --- Has already been applied to the "mob" branch of git-gui-i18n.git. Now we surpass the 250 messages - the translation is actually getting interesting by now. Note that many strings with variables in them had to be rewritten because the variable evaluation has to come after the passing through [mc], not before. Also, the structure of most of the error message is "Some verbose text: \n\n git's error message" and the only i18n'able p...
Jul 23, 3:37 pm 2007
VMiklos
having problems with building the manpages
hi, the man branch of git.git contains the following lines in git-diff.1: EXAMPLES Various ways to check your working tree $ git diff (1) $ git diff --cached (2) $ git diff HEAD (3) 1. changes in the working tree not yet staged for the next commit. 2. changes between the index and your last commit; what you would be committing if you run "git commit" without "-a" option. ...
Jul 23, 2:23 pm 2007
Julian Phillips
Re: having problems with building the manpages
Are you using docbook xsl 1.72? There are known problems building the manpages with that version. 1.71 works, and 1.73 should work when it get released. -- Julian --- Kirkland, Illinois, law forbids bees to fly over the village or through any of its streets. -
Jul 23, 2:40 pm 2007
Johannes Schindelin
[PATCH] filter-branch: Big syntax change; support rewriting ...
We used to take the first non-option argument as the name for the new branch. This syntax is not extensible to support rewriting more than just HEAD. Instead, we now have the following syntax: git filter-branch [<filter options>...] [<rev-list options>] All positive refs given in <rev-list options> are rewritten. Yes, in-place. If a ref was changed, the original head is stored in refs/original/$ref now, for your inspecting pleasure, in addition to the reflogs (sinc...
Jul 23, 1:34 pm 2007
Timur Tabi
git-apply and git-am should provide better errors when chang...
I was trying to apply a patch, and I kept getting this odd error: I'm trying to apply a patch, and I get this error message: git-apply --stat mpc86xx.patch fatal: git-apply: bad git-diff - expected /dev/null on line 55 When I take a look at line 55 of mpc86xx.patch, I see this: # Yes MCA RS/6000s exist but Linux-PPC does not currently support any config MCA diff --git a/arch/powerpc/boot/dts/mpc86xx.dts b/arch/powerpc/boot/dts/mpc86xx.dts$ new file mode 100644 index 0000000..a8a13b4 --...
Jul 23, 1:15 pm 2007
Kumar Gala
git-send-email and pine alias format
I was wondering why we don't parse the pine alias format according to the following spec: http://www.washington.edu/pine/tech-notes/low-level.html I'd expect omething like, to get the address field. @@ -225,7 +238,7 @@ my %parse_alias = ( $aliases{$1} = [ split(/\s+/, $2) ]; }}}, pine => sub { my $fh = shift; while (<$fh>) { - if (/^(\S+)\t.*\t(.*)$/) { + if (/^(\S+)\s+(.*)$/) { $alia...
Jul 23, 12:49 pm 2007
Lars Noschinski
git-gui ignores core.excludesFile
Hello! It seems git-gui (0.7.5 from git 1.5.2.4 tarball) ignores the global ignore file configured with the core.excludesfile option. My ~/.gitconfig contains [core] excludesFile = /home/noschinski/.gitignore which is honoured by git-status but not by git-gui. Greetings, Lars. -
Jul 23, 11:07 am 2007
Steven Grimm
[PATCH v2] Teach git-commit about commit message templates.
These are useful in organizations that enforce particular formats for commit messages, e.g., to specify bug IDs or test plans. Use of the template is not enforced; it is simply used as the initial content when the editor is invoked. Signed-off-by: Steven Grimm <koreth@midwinter.com> --- Updated based on feedback from Dscho. This depends on his patch to add the --strip-comments option to git-stripspace. That seemed like a pretty uncontroversial change to me, but I can easily switch back ...
Jul 23, 9:32 am 2007
Steven Grimm
[PATCH] Test case for "git diff" outside a git repo
Signed-off-by: Steven Grimm <koreth@midwinter.com> --- git-diff --quiet is pretty broken right now. If you do "strace git diff --quiet file1 file2" you will see that it never calls open() on either file! And it always returns a zero exit code whether or not the files are different. I'm trying to follow the code to figure out what's going on, but meanwhile, here's a test case. Perhaps someone more familiar with the diff code will beat me to a fix. t/t4021-diff-norepo.sh | 26 ++...
Jul 23, 9:22 am 2007
Michal Rokos
index-pack died on pread
Hello, it's more and more common that I get an index-pack death for pread that returns 0... Did anybody encountered the same? Some more details: # uname -a HP-UX aa B.11.11 U 9000/800 1009938148 unlimited-user license # git --version git version 1.5.2.4 # git-clone git://git.kernel.org/pub/scm/git/git Initialized empty Git repository in /home/tpiiuser/mr/git/.git/ remote: Generating pack... remote: Done counting 55910 objects. remote: Deltifying 55910 objects... remote: 100% (55910/55910) ...
Jul 23, 8:52 am 2007
Linus Torvalds
Re: index-pack died on pread
Ok, that's bogus. When "n" is zero, the errno (and thus the error string) is not changed by pread, so that's a very misleading error report. So what seems to have happened is that the pack-file is too short, so we got a return value of 0, and then reported it as if it had an errno. The reason for returning zero from pread would be: - broken pread. I don't think HPUX should be a problem, so that's probably not it. - the pack-file got truncated - the offset is corrupt, and poi...
Jul 23, 1:04 pm 2007
Nicolas Pitre
Re: index-pack died on pread
I doubt it can be that. pread() is always used on pack data that we already received and validated, and part of the validation is the final pack SHA1. No code path leads to pread() before the final pack SHA1 is tested OK. The only way for the received pack to be truncated and pread() to fail is if write_or_die() somehow failed to write the pack data without Git noticing. Nicolas -
Jul 23, 2:03 pm 2007
Alex Riesen
Re: index-pack died on pread
strange. pread(2) should not return ENOENT. Not in HP-UX not anywhere. Could you recompile with NO_PREAD=1 and try again? Maybe HP-UX pread(2) implementation is just broken. -
Jul 23, 11:32 am 2007
Luiz Fernando N. Cap...
[ANNOUNCE]: PyGit and libgit-thin
Hi there, I'm the student working on the gsoc libfication project with Shawn and it has reached the point where I need some feedback in order to decide what to do next. The project's goal was/is to change what is needed in GIT in order to make it easier to use as library. This is useful for 'external' applications which wants to be able to perform GIT operations w/o having to fork-exec GIT process (and also w/o having to parse git's programs output). Example of such applications are language bi...
Jul 23, 8:35 am 2007
Johannes Schindelin
[PATCH] Teach "git stripspace" the --strip-comments option
With --strip-comments (or short -s), git stripspace now removes lines beginning with a '#', too. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- Documentation/git-stripspace.txt | 5 ++++- builtin-stripspace.c | 7 ++++++- t/t0030-stripspace.sh | 5 +++++ 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/Documentation/git-stripspace.txt b/Documentation/git-stripspace.txt index 1306d7b..5212358 100644 --- a/Documentation/...
Jul 23, 7:58 am 2007
Marco Costalba
[PATCH] Use Peter J. Weinberger's hash function in xdiff
It seems a little bit faster then current one: WITH CURRENT ONE git tree $ time git diff v0.99.. > /dev/null 0.91user 0.02system 0:01.03elapsed 91%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+0outputs (0major+3594minor)pagefaults 0swaps Linux tree $ time git diff v2.6.22.. > /dev/null 13.61user 0.19system 0:13.90elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+0outputs (0major+27279minor)pagefaults 0swaps WITH NEW ONE git tree $ time git diff v0.99.. > /dev/null 0....
Jul 23, 7:17 am 2007
Sean Kelley
git-apply versus git-am
Why doesn't git-apply include an option for a signoff line like git-am? git-applymbox /tmp/mbox ~/.signoff Or am I missing something? (most likely the case!) Sean -
Jul 23, 3:54 am 2007
Junio C Hamano
Re: git-apply versus git-am
applymbox is going away. -
Jul 23, 4:54 am 2007
Timur Tabi
Re: git-apply versus git-am
That sucks! I like git-am. Is there a replacement command that applies a patch and commits it at the same time? If I use git-apply on a patch that adds new files, I need to use git-add on the files before I can commit it. That's a real pain. -- Timur Tabi Linux Kernel Developer @ Freescale -
Jul 23, 1:20 pm 2007
Peter Baumann
Re: git-apply versus git-am
'git am' isn't going away, but as Junio mentioned, 'git applymbox' is. Those are two *different* programms doing roughly the same, but 'git applymbox' is superceded by 'git am'. -Peter -
Jul 23, 1:37 pm 2007
Johannes Schindelin
Re: git-apply versus git-am
Hi, Read it again. Junio talked about applymbox, not am. Ciao, Dscho -
Jul 23, 1:34 pm 2007
Timur Tabi
Re: git-apply versus git-am
Sorry, for some reason I thought git-am is just a shortcut for git-applymbox. -- Timur Tabi Linux Kernel Developer @ Freescale -
Jul 23, 1:37 pm 2007
Alex Riesen
Re: git-apply versus git-am
git apply is just a safer patch(1). They serve different purpose. -
Jul 23, 4:31 am 2007
David Kastrup
Re: [RFC PATCH] Re: Empty directories...
And of course, it would be a nuisance for people managing a patch-based workflow. But those can actually easily set the repository preferences differently, and even find -type d -empty -delete is not too hard to do. So it would even be feasible as default. But I think that in practice, the "track only what has been added recursively" approach is a good default. And since patches without dir information never add anything recursively, it would mostly keep the directories clean. -- David K...
Jul 23, 3:45 am 2007
Junio C Hamano
[RFH] 3way still has D/F conflict problems...
The four commit series starting at 4c4caaf fixed a few D/F conflict case in merge recursive. 4c4caaf... Treat D/F conflict entry more carefully in unpack-tree... ac7f0f4... merge-recursive: do not barf on "to be removed" entries. 4d50895... merge-recursive: handle D/F conflict case more carefully. 885b981... t3030: merge-recursive backend test. However this ended up regressed the following case (don't bother bisecting, it will point at 4c4caaf). The test case starts with a tree with a ...
Jul 23, 3:22 am 2007
Yasushi SHOJI
[PATCH] describe: Add unlisted option
added unlisted options, --contains, --candidates and --debug, to usage line. also, prints some info when --contains and --debug are given. --- Documentation/git-describe.txt | 4 +++- builtin-describe.c | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/git-describe.txt b/Documentation/git-describe.txt index ac23e28..f0bcb61 100644 --- a/Documentation/git-describe.txt +++ b/Documentation/git-describe.txt @@ -8,7 +8,9 @@ git-describe - Show ...
Jul 23, 2:24 am 2007
Shawn O. Pearce
Re: [PATCH] describe: Add unlisted option
That makes sense. Especially telling the user why --debug --contains doesn't actually print anything. ;-) Originally I left out --candidates and --debug when I wrote the code for them as I thought they were a tad too internal for casual use. But maybe it makes sense to include them in the usage string. Acked-by: Shawn O. Pearce <spearce@spearce.org> -- Shawn. -
Jul 23, 3:03 am 2007
Junio C Hamano
Re: [PATCH] describe: Add unlisted option
I was actually going to suggest removing these options, that were primarily meant for debugging and tweaking while we figure out what the optimum default should be. Do you think they are worth keeping? -
Jul 23, 3:41 am 2007
Shawn O. Pearce
Re: [PATCH] describe: Add unlisted option
Yea, I do. I'd like to keep them in the code as sometimes I do look at their output. I'll even help maintain them, because they change oh so often. ;-) But if you really want them gone, I won't stop you. -- Shawn. -
Jul 23, 3:47 am 2007
Junio C Hamano
Re: [PATCH] describe: Add unlisted option
Nah, I already noticed your Ack and inferred that you would want to keep them. Haven't applied the patches yet, though. -
Jul 23, 4:54 am 2007
Yasushi SHOJI
[RFC] describe: add option --dirty
when --dirty is given, git describe will check the working tree and append "-dirty" to describe string if the tree is dirty. --- I'm not sure this is good idea or the current way (using diff-index in shell script) is more prefered. one thing I found out is that we s/-/./g the out put of describe before we append "-dirty". this patch doesn't take care that. so with this patch what we get is either v1.5.3-rc2-840-g1c0e2-dirty, or v1.5.3.rc2.840.g1c0e2.dirty if we don't put more complecated ...
Jul 23, 2:35 am 2007
previous daytodaynext day
July 22, 2007July 23, 2007July 24, 2007